From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add symbol::matches method
Date: Thu, 31 Aug 2023 13:13:20 -0400 [thread overview]
Message-ID: <e716bd93-979b-4613-b05f-9fd0df0c9e43@polymtl.ca> (raw)
In-Reply-To: <20230829200018.2161784-1-tom@tromey.com>
On 8/29/23 16:00, Tom Tromey wrote:
> This adds symbol::matches, a wrapper for symbol_matches_domain. Most
> places calling symbol_matches_domain can call this method instead,
> which is a bit less wordy and also (IMO) clearer.
This looks nicer indeed. I checked if we could get rid of
symbol_matches_domain (just put the implementation in symbol::matches),
but that doesn't seem possible, other things use symbol_matches_domain
without a struct symbol.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
prev parent reply other threads:[~2023-08-31 17:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 20:00 Tom Tromey
2023-08-31 17:13 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e716bd93-979b-4613-b05f-9fd0df0c9e43@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).