From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7021E3858D3C for ; Mon, 28 Nov 2022 10:51:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7021E3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669632683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zli3qczwuAN3s7AjSvOT6XavSu4cWyboNqC+3kiTdRw=; b=GFJxrw3gz7SJqBH3sQ+hPAPThXLOZtxbbb8nNRZa2O4MD9viFHVIP0geIlsT4JCOPDd1nQ knKyJIBt2mcBZBGs8dxRlPGYNo4n2sjULmb8KSzAEOH3WmYFL5DG28waIJ601sJaRGPWXb XH/+O9nw6PEmoZWYvsyKMQYpHIXpne4= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-554-vDzo1fuSPOWqY0Fno-hcAA-1; Mon, 28 Nov 2022 05:51:21 -0500 X-MC-Unique: vDzo1fuSPOWqY0Fno-hcAA-1 Received: by mail-ed1-f72.google.com with SMTP id w4-20020a05640234c400b004631f8923baso6400187edc.5 for ; Mon, 28 Nov 2022 02:51:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zli3qczwuAN3s7AjSvOT6XavSu4cWyboNqC+3kiTdRw=; b=HFxmIgKpqApBRowdH8RQyDYiFJQ/gz7qPVcyzka2iUk7n58OkmLcl0xkivBX7V+Seq zgJD/ZVpSM/Nwf9bpYwOQW+lgayQlBoL0zM9aajd0PewFSCOFoKAksHuO00767UV+FSM 9wuCbYp2UBpjHLynIcfOXvqsUz1c90nYAj5b+QStIdETojw4E0VF8E2Fi/9D6pqmZYNX lHHT1TzJQfIUps7Jm8pC/7ADnqCb0UkMU/MCarWgI6ujLqQAwyCJV4ATU9zOSrg/z1EN 19rdvZd1fjxav0Z0aab8pWb32YeJxfxzR0ikmFoSwQiNOMkSBjdGtNuR7z2gnvxPy/y8 UsIQ== X-Gm-Message-State: ANoB5pknamGHsFAXxM7fhEfUG3jIcyVoNnldRiCDGQnSf+0CxNB9fVD+ go/aNSsyW2kc30rBwiY2bcn0gT9PSl6Z9UDL46vTSpkKpzvKbx4KxpG52nlR6ZIneEnate3a95E lysmS4lg4vxNorZPFKgHDqg== X-Received: by 2002:a50:fe8d:0:b0:461:9183:834b with SMTP id d13-20020a50fe8d000000b004619183834bmr31907938edt.196.1669632680101; Mon, 28 Nov 2022 02:51:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf5xgnNfJnqsIDA7HvHL40VT1PnRB3EDyhZqFOt7NXRTIFVRjNszhRbVbPj8xJd/M/4U+8O1EA== X-Received: by 2002:a50:fe8d:0:b0:461:9183:834b with SMTP id d13-20020a50fe8d000000b004619183834bmr31907927edt.196.1669632679941; Mon, 28 Nov 2022 02:51:19 -0800 (PST) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 2-20020a170906308200b007838e332d78sm4761362ejv.128.2022.11.28.02.51.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 02:51:19 -0800 (PST) Message-ID: Date: Mon, 28 Nov 2022 11:51:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] gdb/testsuite: fail if gdb_start_cmd fails To: Simon Marchi , gdb-patches@sourceware.org References: <20221118160647.912966-1-simon.marchi@polymtl.ca> From: Bruno Larsen In-Reply-To: <20221118160647.912966-1-simon.marchi@polymtl.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18/11/2022 17:06, Simon Marchi via Gdb-patches wrote: > I broke gdb.ada/start.exp, and did not notice it, because it outputs an > UNTESTED if gdb_start_cmd fails. I don't really see when start would > fail and it's not a problem that should be looked at. Change all spots > that call untested after a gdb_start_cmd failure, use fail instead. > > Doing so caused some failures with the native-gdbserver board. Some > tests that use "start" were relying on the fact that start would fail > with that board to just return with "untested". Change them to add an > early return if use_gdb_stub returns true. > > Some gdb.pascal tests also failed with native-gdbserver, because they > did use gdb_start_cmd to start the inferior, for no good reason. > Convert them to use runto_main instead, which does the right thing if > the target is a stub. > > A further refactoring could be to make gdb_start_cmd match the expected > breakpoint hit and the prompt, which it doesn't do currently (it leaves > that to the callers, but not all of them do). > > Change-Id: I097370851213e798ff29fb6cf8ba25ef7d2be007 Hi Simon, This patch makes sense to me, and testing shows no regressions. Reviewed-By: Bruno Larsen -- Cheers, Bruno