From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 501D53858D20 for ; Wed, 16 Mar 2022 01:21:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 501D53858D20 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 22G1LeBg005418 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Mar 2022 21:21:45 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 22G1LeBg005418 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D38531F0BB; Tue, 15 Mar 2022 21:21:39 -0400 (EDT) Message-ID: Date: Tue, 15 Mar 2022 21:21:39 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/2] gdb: testsuite: remove pass statement in can_spawn_for_attach Content-Language: en-US To: Tiezhu Yang , gdb-patches@sourceware.org References: <1646388927-28165-1-git-send-email-yangtiezhu@loongson.cn> From: Simon Marchi In-Reply-To: <1646388927-28165-1-git-send-email-yangtiezhu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 16 Mar 2022 01:21:40 +0000 X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 01:21:55 -0000 Hi Tiezhu, Did you consider changing the approach to what Pedro suggested here? https://sourceware.org/pipermail/gdb-patches/2022-March/186311.html I have to admit that I approved your patch because I didn't really have a better suggestion, and I know that it's a real problem (which I encounter myself sometimes). But Pedro's suggestion seems more straightforward. Simon On 2022-03-04 05:15, Tiezhu Yang wrote: > After execute the following command: > > make check-gdb TESTS="gdb.base/attach-pie-noexec.exp" > > we can see the following messages in gdb/testsuite/gdb.log: > > (gdb) gdb_do_cache_wrap ignoring pass: can spawn for attach > > the pass statement is ignored, just remove them in can_spawn_for_attach. > > Signed-off-by: Tiezhu Yang > --- > gdb/testsuite/lib/gdb.exp | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index a35d08a..f21b22c 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -5111,7 +5111,6 @@ gdb_caching_proc can_spawn_for_attach { > file delete $obj > gdb_test_multiple "attach $test_pid" "can spawn for attach" { > -re -wrap "Attaching to process $test_pid\r\n.*No executable file now.*" { > - pass $gdb_test_name > kill_wait_spawned_process $test_spawn_id > return 1 > } > @@ -5126,7 +5125,6 @@ gdb_caching_proc can_spawn_for_attach { > return 0 > } > -re -wrap "Attaching to process $test_pid\r\n.*XML support was disabled at compile time.*" { > - pass $gdb_test_name > kill_wait_spawned_process $test_spawn_id > return 1 > }