From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by sourceware.org (Postfix) with ESMTPS id C73493858D28 for ; Thu, 26 Jan 2023 17:37:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C73493858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f45.google.com with SMTP id l8so1645348wms.3 for ; Thu, 26 Jan 2023 09:37:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uFtR48rUPR9VatXvgGGOA1/LGcxoI1zYwk8XRGfNO5w=; b=idmuiA7jqk3l59HGFcfOA6UQyOnhs7RtAq2TTGd8Ii4e2yl8X4l+frQqDyA3uOfQT5 4Jg4P1FzJU0yvF1uH1mXP9EYKsQD9tB++mI4i8hJsYC2fWFrpY44FY3c0LEF4X2kC7Qk tEJjFgS2eXsjBoH2GirVgsFbhT/YW/YCptZN6h0RMapOvCd13rCjnYjE7HMBjnlde5Em GtbIlnUmdrPkLZzly4eO12UuAutRibsEMq3XS1e9gSNwJJC9Qb2Rr4RXLzdyeE5FFuaF nn61vaovca40G/hjMzi8PGt1vtmNVrE1QlGXuiX1zw1Hjtnmq19Jff/HFjxfeG5kddSl UIKg== X-Gm-Message-State: AFqh2kpV6c1igsJBdX7MX6k8ZhBzR/PIf9CMg62jixP36l85rexXQ7Sx VyenIRjzeaY3MnF+HNww33LUmFHbEL6XnQ== X-Google-Smtp-Source: AMrXdXvepsVYBs6cDjZwQpgWc62lhfX31RWaZBQ7bD6L33MSSDa3Q2mGwy4pKEUq3opDZyUrh1zfHg== X-Received: by 2002:a05:600c:202:b0:3da:f80d:7230 with SMTP id 2-20020a05600c020200b003daf80d7230mr36341989wmi.8.1674754625637; Thu, 26 Jan 2023 09:37:05 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id ay6-20020a05600c1e0600b003db00747fdesm5321283wmb.15.2023.01.26.09.37.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 09:37:05 -0800 (PST) Subject: Re: [PATCH 00/27] Many small testsuite cleanups To: Tom Tromey , gdb-patches@sourceware.org References: <20230125224614.1006886-1-tom@tromey.com> From: Pedro Alves Message-ID: Date: Thu, 26 Jan 2023 17:37:04 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20230125224614.1006886-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-01-25 10:45 p.m., Tom Tromey wrote: > I noticed a few things in the test suite that looked off, so I wrote > some patches to clean it up. Each patch should be reasonably > self-explanatory. > I read the whole thing, and the only thing that jumped out at me was the gdb_file_cmd vs gdb_load issue I pointed out in another email. Everything else looked OK. Thanks for doing this.