From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2083.outbound.protection.outlook.com [40.107.115.83]) by sourceware.org (Postfix) with ESMTPS id 6E4313858404 for ; Tue, 12 Sep 2023 17:54:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E4313858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=THLt0XIb5q4Aywv7LSzULSYQ11i3GdqhM+YtTPgv/0B9BL4rPlUOjISWycDmYN9mz7zpS4yYUA2NS7ANZay6uJLL65wEtILecymiJQl9h4zlYst8AoXWtiK/EAL0l3c4HM6+D6MA/MNWxbP/uK9JqiuzS+msJRQVDH3jba0+8KRQyx8uCe0sZCxE6h0uGprzwVNbR+vJ0VFc7wTqxXLZD8CBMdO1lGAKL9unXBKGTf/5O0xDie2vyirQLvsv0NZap2zoP/wa9aLCnzSEs+SM+pfh97i2z1hL5CuJCE1ccc842O+msMGqm9y2Q40SSzV22cfZtIZWTsTx/377TGJKwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wVtAMViNjpkXDZ3lo6/SM/EJ2Q383oIb+qns0j3ZslA=; b=WQ5NJz1jysifObrHewcuwfzOmkopv2zsqUHhfzhj3BAM27pMdbFx1uinSP6fHj2pQU3mm1+3v8DSV464meVKKtdk5H1G0MiMZW51WCmIRCIrUlTUmVD/yP7hoEkGj0arsZ3uf3tU/G/j98dFYCDo2FJie7AIF+Q5227zpuimfiXFP+hnYJ0pX33126tWPuiKho5BSTCx5bLwXNevkQgSq2H/O1hj/yNzr21zcwQj3+TO8qAiJ2sXTJpv4mtKsJpNL/H5EeUVEjXai4nxAgCIC4AqWBNGDt1XiEClOG+Sq8fxhhCsAUeB3HJDBD4LWwGaGjGdpS4kAd7lWF/rSEVfUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wVtAMViNjpkXDZ3lo6/SM/EJ2Q383oIb+qns0j3ZslA=; b=P01nmPjIdpCyMl8MUf4vVAzkxswYAVST4kgj7fvDTDq+mdyjBL6zMJZCZP9JpOCuWy3TxtG+6nFgtNERyb7mFj1a/jvRrMfG7TuDm7oSCxdQ0onXhByqA2kuKnRLW9JQalCTVtpRKeZHt3bkWSPrDTan6SvxjT7ATe5M4zWzXpRVTJIXwdRwEX2uS9Nvg/At967v/PxHgFIrxcpEGWv3S00uGUdBWXQn9VMYE7uLu9nCmzT1vybKpYRNG5rIuWfHTucaNLmvsegGoVtb6n7S8sgPdH+xSj7iyQaT8ur+yBfmsPfeyB9Xm8z9fCG6sl7+7Q58A+qqA/hGR0f3Pa3wig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YQBPR0101MB8927.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:5b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.35; Tue, 12 Sep 2023 17:54:14 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::a015:84e9:f0da:66ec]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::a015:84e9:f0da:66ec%4]) with mapi id 15.20.6768.036; Tue, 12 Sep 2023 17:54:14 +0000 Message-ID: Date: Tue, 12 Sep 2023 13:54:12 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21/21] gdb: make top_level_interpreter a method of struct ui Content-Language: fr To: Andrew Burgess , Simon Marchi via Gdb-patches References: <20230908190227.96319-1-simon.marchi@efficios.com> <20230908190227.96319-22-simon.marchi@efficios.com> <87zg1ripzp.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87zg1ripzp.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0041.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2::13) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YQBPR0101MB8927:EE_ X-MS-Office365-Filtering-Correlation-Id: 13afa833-c953-4dc6-15d5-08dbb3b946eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BSzHtd6qBfFHmvCq2wWmaUzTqCjqYBWGBePSlwAzj9NF3af8eTk3TJnUbYM3lcgRIvDkEezxfllilOyB28Bz7na5ZPdnYIPkLiXKXJ8aZcwNMiijx8Uq4oKwjHlDW7iK1saMUsCsOyXiS7t4nPdSdr+A7QsnHq90UYE3ZShyYNsomSHdy90NTNyFU3zh0vmMJKL0/oesksyPeps0L1IRZkZb3vVC/jp/XS80L5CpghjNbfXNLXEzgJH6+CSere6uSo5odx47PPtsEUmnSXksa9zN/QCnwVS9TRB3WwIOBKLoCzjnIXoxAWhpPDjDNHPegzm77a1jhcN8Mzam41PyIWcJ/SEex2UwphT/53i07G+fQzkPnQxu0WAfDBy0R+HxkpTbvf6VcQic/WFUeMkUzHQ8gmCIo9kQKgoVBWxWeB/oBcftppnDP+ZLlsqm8yjjmWQVAAxAIyseuuK7BCyblqeYMpIT0nPezY2s6nsjAjujQQR2oFvUiP1JgJIU8HHpKwmOLxA6du/jGZhmNV96V9QPwB89EWKqucu2HExiiWwSF9+HjUzG1S5Y2wbqrQWgQB7wmc0XYeVebGgV2XLiyumYETnakniqrsbxQ64KG4YgxY7OWfjc35wO3BtPmRFY1XTx9cZpSieTabbBr0Oubw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(366004)(136003)(396003)(376002)(39830400003)(346002)(186009)(1800799009)(451199024)(6506007)(6486002)(6512007)(38100700002)(31696002)(36756003)(2616005)(66476007)(26005)(4744005)(2906002)(110136005)(66556008)(316002)(66946007)(41300700001)(44832011)(8676002)(5660300002)(31686004)(478600001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmlHWWgvdXlGRDZ3b1hDRjFVM2JUdHFGYTJCSXJ2RGFXc282czFLM2M1cFhn?= =?utf-8?B?NWFNWjNkaUlZYmNaWTBXVFRJNW9sSGRtRVNkSzlpdTg2VE5aY1hwL0ZpYk9J?= =?utf-8?B?SU5wN1cvdUJpZWIyZmFNNUlkbEFsZUhUVlM1QWZvbXFBbno4NXRucjg1MG9v?= =?utf-8?B?dyswcUFWSzNKUCtCNlFXTHV3bTByc1lYQXlVRnV1MEoxcW5kNDlxdmdIVFZ4?= =?utf-8?B?eUpTVklhWDNVeVduODlLNWVEZHIrajlEV01kbFZHbnd6WVZHdlNyQTBsRFpp?= =?utf-8?B?MkU4QnJyS1NhYzc0QXlMVUdxbTdUN3FQeE40UFlGTzE2SCtlLzFUcmVtcnhN?= =?utf-8?B?SFhIWkdyTENtUFNSWlUvRDRDQW5YZ1ZLK1A3RzR4OXVwQ1ZjVUxkaksvYloz?= =?utf-8?B?b2VYZTBFNzc1cXNwME1TdDJwUWJENzBTVTQxT3R6cjB0RTNxUHI1eFhVQlpR?= =?utf-8?B?RVUyQ1VNbmFqQ0JFYmFCazhxSnoxRUo3RE1GbldicmdmRUllZkRQaXd4TXdh?= =?utf-8?B?YVlSZk42eGEreTBidmdJclNCUkUyenoxRnBydzE1S3pIdE83Y1l1NEtieEFI?= =?utf-8?B?YzhTMGJsRGo2MUJUR3NYRitHd1dvZ1JyN3cvbTJpMmVYbm9mU0I3ZVdVK1Vv?= =?utf-8?B?NlNpdUVPTG5hdnNEcjlTckN4VzRsTVVOdFJDMTU0S0pTaXZnNEk3cWI0dU04?= =?utf-8?B?M1lkRk9GUnJMV1ZBVXZkYjFZRGNmUy9tODFiOW1VbzVuN3BGVmpra2FJeXJQ?= =?utf-8?B?U3Jyd3BnOWdlUytqK01FNnBIa3pmT0pXaXpFNXRDc0FJLzQ4L2NPRmRZaWJ6?= =?utf-8?B?ajNwZmVidWIxbm5IZ3o3UElid2VON3htV3JjMFNvdU4zT2txanZSZGZSNTRw?= =?utf-8?B?Q1FKT3E2SmNpazErRkM3RktUcWJsOVN1Tno5UnBXT1dCWEp4c2c1c0V5UE1P?= =?utf-8?B?N3JaNzJqNlEzSDYrT2Jza0dVOEF4UHE4b01JVUo5bjFSZ09KdHdUbXpTZllr?= =?utf-8?B?eTdEdnVNalROVmNxYTFDOFgyb1ZTRUhINUUzeTlVenNRS1hRY042Umg2dzlk?= =?utf-8?B?ZWxmWlBnVHppM1NuRDYyb0lkUEpoSzROZCt5RHRyTEFoUTZSL3VtU0hManhB?= =?utf-8?B?eUxkR1NUVmlBUm9aRmhRK2ZNZElTblcySWtvbkFnckNLaXMyajk1bU5sR1pl?= =?utf-8?B?c2IwT1BpeGtsbkdMc1NuL1RzTFVNTWVoVHlDdVk2SkNVcXhqV0NlNFg2N1o4?= =?utf-8?B?QmE1S1ZQdTArbHVRK2hjQ3ZjTWRvT3EzODlTeW12VStVem1CY1ZKVkpXQkh3?= =?utf-8?B?Wld1NzRDd1lBa29mR1ZwVnJ3SmR5ZzhPQWkvck0zZ3FYOGlXS3FDRy9VS1FE?= =?utf-8?B?b3djc09JMG1GR1Z5QmRsd2NqYkY0VFkxbUFaRUNrNnNjQ002OUN6T3FXVmFZ?= =?utf-8?B?bjBxY3o4Z1cwaDdQVmRDUndrWGp4Z3VrMGhEOEtsZkloVkx4T2JkbzlQN1Fz?= =?utf-8?B?VHJpZlZqTzVWdE5MSmdpVHdkOUJ5Q3RUV3I2SDUyTlp4Ym5tUDRiSlpnUFBP?= =?utf-8?B?SEVEVDZpaGZDYXh5RG9WMmZIOEdKMHBMNXFsa3NLTmxtUjVsTDVTcE5RcHVC?= =?utf-8?B?TlZQa3BxOXQzT1UzZStvaW9DQ1J6MWJWYlpaZUhETTdWMnowL2k3ZFU1QTdo?= =?utf-8?B?ZlphWDFXNzc2ZWhtNytmSUdqNTRuZzI1TTBuVXF3WnVNOWliTCt5QW5EWC9r?= =?utf-8?B?cEI1V2dITDNjRjRYcUt5R1duUjRBbi9YTmtmUU9LOFZXVEdzd1BQK25ycnlU?= =?utf-8?B?QkxOMVlicmhSK0pyazNLQm4yc1hQRkJGaUxaMkNaRWFnT09lcXJEaWxLQlVk?= =?utf-8?B?YXdkdlQ2TUhuNzYvdDRUVUJlZDgwMWhCSVB0emRzUzZhamRUVklwbXlpT1Br?= =?utf-8?B?RW14eFE3MVMrZHZoU0xjZnNVV1dLSVJYVXJWSTFVblJndDFCelFBV1cwTFlm?= =?utf-8?B?Tkl3Vkt4WGFnN3duUS9wWU5zclE1RTF3S0hJNFI0b3RFbzZBK3hnUURNd3Nj?= =?utf-8?B?aWEvYnVRQXVUelJUVnhhZmJ4Y1ZMYnVCQnI5TlJiQllzNjBuZXJuMkVoVjRC?= =?utf-8?B?QWhzMWp6eThQM3FFbmVmRG1tUzA0SC8xcDUwbGVGK2dHWnB0RXhNZDdzRVlP?= =?utf-8?B?cWc9PQ==?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13afa833-c953-4dc6-15d5-08dbb3b946eb X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 17:54:14.4436 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hPQeEDnZf/V4ySk4mZLa3gcHG0fDKwD5YxPAiddK0XRTQDJdaixBs2jibt+nl8PKTTDX0HQ+he7vHY32NNKrDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB8927 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> @@ -185,6 +184,13 @@ struct ui : public intrusive_list_node >> Throws an error if NAME is not a known interpreter or the interpreter fails >> to initialize. */ >> void set_top_level_interpreter (const char *name); >> + >> + /* Return this UI's top level interpreter. */ >> + interp *top_level_interpreter () >> + { return m_top_level_interpreter; } > > I think this function should be marked const. If we want things to be const-correct, then I guess a const version of this method should return a const interp. And that would be a bunch more work (if even possible). But I guess that marking the method const and returning a non-const interp doesn't have downsides versus what I have above, so let's add const. Simon