From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tdevries@suse.de>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by sourceware.org (Postfix) with ESMTPS id 78A403858400
 for <gdb-patches@sourceware.org>; Wed, 10 Nov 2021 13:32:09 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 78A403858400
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id B394F1FD63;
 Wed, 10 Nov 2021 13:32:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8F5EA13BFF;
 Wed, 10 Nov 2021 13:32:08 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 52+zIdjJi2E8IQAAMHmgww
 (envelope-from <tdevries@suse.de>); Wed, 10 Nov 2021 13:32:08 +0000
Subject: Re: [gdb/build] Fix Wimplicit-exception-spec-mismatch in clang build
To: Pedro Alves <pedro@palves.net>, Simon Marchi <simon.marchi@polymtl.ca>,
 Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
References: <20211102203434.3889269-1-simon.marchi@efficios.com>
 <39183fd0-d31d-feb4-9cfd-8c928b5eaf06@suse.de>
 <972f3e77-0788-e0e7-e524-e8617e4a4aee@polymtl.ca>
 <915b1bef-6553-dddc-e274-384e49607dbb@suse.de>
 <5684dfa8-572d-f21c-c3dd-a9610d036f06@palves.net>
From: Tom de Vries <tdevries@suse.de>
Message-ID: <e8024414-57f8-ff32-af8c-20c4bae1f758@suse.de>
Date: Wed, 10 Nov 2021 14:32:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <5684dfa8-572d-f21c-c3dd-a9610d036f06@palves.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Nov 2021 13:32:11 -0000

On 11/5/21 6:07 PM, Pedro Alves wrote:
> On 2021-11-05 10:03, Tom de Vries via Gdb-patches wrote:
>>  
>> +extern void
>> +operator delete (void *p, std::size_t) noexcept;
> 
> The convention is to not format declarations with function name at column 0.  So here:
> 
> extern void operator delete (void *p, std::size_t) noexcept;
> 

Done.

>> +
>>  void
>>  operator delete (void *p, std::size_t) noexcept
>>  {
>>    return ::operator delete (p, std::nothrow);
>>  }
>>  
>> +extern void operator delete[] (void *p) noexcept;
>> +
> 
> ... like you did here.
> 
> I suggest a comment mentioning the need to declare these if compiling in C++11.
> 

Done, and split off into separate patch, refiled at
https://sourceware.org/pipermail/gdb-patches/2021-November/183311.html .

I'll commit in a few days unless there are further comments.

Thanks,
- Tom