From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81013 invoked by alias); 24 Jan 2020 14:58:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81004 invoked by uid 89); 24 Jan 2020 14:58:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.17.22) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Jan 2020 14:58:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1579877904; bh=jskVyF97RQVgc1oy6ikhbmZDHNP4GLGEuJEBiZ8eHAA=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=goQKnFuhOpwS2Z+/Q8N0moU4ZIMDALPXb2gcEp/gC4EB+kh3et0l2UbmRzW4rEeaC +0V8FQIoal5bQ8CZ8s0HFXohEMX9XMg0jyQy9HmpToJ2JusQG5BFpTil9EQZj47v9u TiIq34rLEvuT3Yhu31O07X/91jnZ56T39BaRjESo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.71.135.231]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MUXtY-1j3uOe2ITY-00QPCc; Fri, 24 Jan 2020 15:58:24 +0100 Subject: Re: [PATCH 1/3] Support the NetBSD version of pthread_setname_np To: cbiesinger@chromium.org, gdb-patches@sourceware.org Cc: Christian Biesinger References: <20200124141458.171392-1-cbiesinger@chromium.org> <20200124141458.171392-2-cbiesinger@chromium.org> From: Kamil Rytarowski Message-ID: Date: Fri, 24 Jan 2020 14:59:00 -0000 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200124141458.171392-2-cbiesinger@chromium.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q74oKBpa9mJNz5bXYK7jHChvW9YI9aaKa" X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00797.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q74oKBpa9mJNz5bXYK7jHChvW9YI9aaKa Content-Type: multipart/mixed; boundary="3GIuVyTSxT61V786oWzTTJMuEkjEtdXoh"; protected-headers="v1" From: Kamil Rytarowski To: cbiesinger@chromium.org, gdb-patches@sourceware.org Cc: Christian Biesinger Message-ID: Subject: Re: [PATCH 1/3] Support the NetBSD version of pthread_setname_np References: <20200124141458.171392-1-cbiesinger@chromium.org> <20200124141458.171392-2-cbiesinger@chromium.org> In-Reply-To: <20200124141458.171392-2-cbiesinger@chromium.org> --3GIuVyTSxT61V786oWzTTJMuEkjEtdXoh Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 1630 On 24.01.2020 15:14, cbiesinger@chromium.org wrote: > From: Christian Biesinger >=20 > On NetBSD, pthread_setname_np takes a printf-style format string plus > one argument: > https://netbsd.gw.com/cgi-bin/man-cgi?pthread_setname_np++NetBSD-current >=20 > This patch makes thread-pool.c handle that. >=20 > gdbsupport/ChangeLog: >=20 > 2020-01-24 Christian Biesinger >=20 > * thread-pool.c (set_thread_name): Add an overload for the NetBSD > version of pthread_setname_np. >=20 Looks fine. > Change-Id: I61e664a813eaa7f52b6811b1a43e08ac3082d8ef > --- > gdbsupport/thread-pool.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) >=20 > diff --git a/gdbsupport/thread-pool.c b/gdbsupport/thread-pool.c > index fc83ff765f..be9ca22682 100644 > --- a/gdbsupport/thread-pool.c > +++ b/gdbsupport/thread-pool.c > @@ -40,8 +40,16 @@ > #include >=20=20 > /* Handle platform discrepancies in pthread_setname_np: macOS uses a > - single-argument form, while Linux uses a two-argument form. This > - wrapper handles the difference. */ > + single-argument form, while Linux uses a two-argument form. NetBSD > + takes a printf-style format and an argument. This wrapper handles the > + difference. */ > + > +ATTRIBUTE_UNUSED static void > +set_thread_name (int (*set_name) (pthread_t, const char *, void *), > + const char *name) > +{ > + set_name (pthread_self (), "%s", const_cast (name)); > +} >=20=20 > ATTRIBUTE_UNUSED static void > set_thread_name (int (*set_name) (pthread_t, const char *), const char *= name) >=20 --3GIuVyTSxT61V786oWzTTJMuEkjEtdXoh-- --Q74oKBpa9mJNz5bXYK7jHChvW9YI9aaKa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl4rBdwACgkQS7MI6bAu dmxAtw//d2yGR7aG2pH4CH6JU1aueTb25PbjsTE5mEFwW50Ygvz0jcgV08ZBkMAm JycHqDfodGkQA9KpQkZFlP+RSpit118i+eAUKlwfQelRsQB2h4zvMtdlfMTCq+qX kO1d+BmyxaXX7Xp5eakHDKnrUa6nPjPL54wgH8vQfgvMpeENUNslyz4Wt7ETOHJ1 te0RcV4wyCBb8VP+i7VDhWrZzvk5ZKc9llccRIoTshOuYdhJ6Wb91lscSskNNVxv tnFQND1D5gF3KKHhI6r/uZB5Qvxpk5WcZoEiDy8S+Iw2kZbTlDMxTnDRoofXUW29 t0njQVBjuUPbySX7UWm/ws2sFe1yUb3R7zSmTH7EIVEjBSYxtKpaa+ObxQQbN4t1 40lSiTZhNyfVl8V/ZXaiT6CqKHul+Nb9flzqqzN7+0LVEK2nhmTKDy3y0UadRp0r EgG8xwC5BHys5SU0te8coV4kvm62Z1M7GTioJuYmsi671PBIBgUXNkpTMH5RnuNs 8HSBt8s2slVb9uwoUOCDV12fC0zikSXbfCpj63gz3cGZkKgWDaRm2CZi8b5qVRFo uA6gbrGCq3TUBY7B3spUa6x4T6FQOEkJZVCFp3/3NTWqQ7ZOxuHYK8spvGcqg3SP V67gwqjvVGne5fiAb5ervIVF7FnPwOJKKhLVYmMgLsx+tdpreJw= =AoXN -----END PGP SIGNATURE----- --Q74oKBpa9mJNz5bXYK7jHChvW9YI9aaKa--