From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107929 invoked by alias); 27 Jun 2018 14:34:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107911 invoked by uid 89); 27 Jun 2018 14:34:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 14:34:17 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5REYA9I007247 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 27 Jun 2018 10:34:15 -0400 Received: by simark.ca (Postfix, from userid 112) id E7ED91EF29; Wed, 27 Jun 2018 10:34:10 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 469CA1E059; Wed, 27 Jun 2018 10:34:10 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 27 Jun 2018 14:34:00 -0000 From: Simon Marchi To: Thomas Petazzoni Cc: gdb-patches@sourceware.org, Pedro Alves Subject: Re: [PATCH] nat/fork-inferior: include linux-ptrace.h In-Reply-To: <20180627163123.6da3d93c@windsurf.home> References: <20180625080547.7629-1-thomas.petazzoni@bootlin.com> <3acce11a3e5ed352af945ab71739468b@polymtl.ca> <20180627163123.6da3d93c@windsurf.home> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00651.txt.bz2 On 2018-06-27 10:31, Thomas Petazzoni wrote: >> fork-inferior.c is also included in native builds for BSDs, AIX, >> Solaris >> and Darwin (see gdb/configure.nat). I am a bit concerned that >> linux-ptrace.h could use some Linux-specific things, and thus would >> break the other builds. However, I built-tested on FreeBSD and it >> seems >> fine. Worst case, we can probably wrap this include in "#ifdef >> __linux__" if that becomes a problem. > > Or better, this horrible mess of __UCLIBC__ and HAS_NOMMU macros should > be replaced by a proper autoconf check testing for the availability of > fork(). Agreed, and I think Pedro will agree too (unless you can think of a simpler solution that doesn't involve autoconf?). Simon