[PATCH]: texinfo remove broken links Previous and Up from contents

[PATCH]: texinfo remove broken links Previous and Up from contents

[Jonny Grant]

2020-05-27  Jonny Grant  <jg@jguk.org>

	* doc/gdb.texinfo: Remove broken links Previous and Up from contents


 From 5720d8615a6ac74299c5e56f1d1bcb0f1fd73b49 Mon Sep 17 00:00:00 2001
From: Jonny Grant <jg@jguk.org>
Date: Wed, 27 May 2020 23:11:17 +0100
Subject: [PATCH] texinfo remove broken links Previous and Up from contents

Signed-off-by: Jonny Grant <jg@jguk.org>
---
  gdb/doc/gdb.texinfo | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 6418162849..d90c33d67a 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -108,7 +108,7 @@ ISBN 978-0-9831592-3-0 @*
  @page

  @ifnottex
-@node Top, Summary, (dir), (dir)
+@node Top, Summary

  @top Debugging with @value{GDBN}

-- 
2.17.1

Re: [PATCH]: texinfo remove broken links Previous and Up from contents

[Eli Zaretskii]

> From: Jonny Grant <jg@jguk.org>
> Date: Sat, 30 May 2020 01:00:30 +0100
> 
> 2020-05-27  Jonny Grant  <jg@jguk.org>
> 
> 	* doc/gdb.texinfo: Remove broken links Previous and Up from contents

Thanks, this is OK, except that the ChangeLog entry should end with a
period.

Re: [PATCH]: texinfo remove broken links Previous and Up from contents

[Andreas Schwab]

On Mai 30 2020, Jonny Grant wrote:

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 6418162849..d90c33d67a 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -108,7 +108,7 @@ ISBN 978-0-9831592-3-0 @*
>   @page
>
>   @ifnottex
> -@node Top, Summary, (dir), (dir)
> +@node Top, Summary

They are not broken, (dir) is the info directory.  If you want to leave
out node pointers, leave them all out, so that makeinfo generates them
on its own.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: [PATCH]: texinfo remove broken links Previous and Up from contents

[Jonny Grant]

On 30/05/2020 08:27, Andreas Schwab wrote:
> On Mai 30 2020, Jonny Grant wrote:
> 
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index 6418162849..d90c33d67a 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -108,7 +108,7 @@ ISBN 978-0-9831592-3-0 @*
>>    @page
>>
>>    @ifnottex
>> -@node Top, Summary, (dir), (dir)
>> +@node Top, Summary
> 
> They are not broken, (dir) is the info directory.  If you want to leave
> out node pointers, leave them all out, so that makeinfo generates them
> on its own.

Ah ok. Maybe you can propose a better patch?

I don't have the time at the moment to take the changes further.
Jonny

Re: [PATCH]: texinfo remove broken links Previous and Up from contents

[Jonny Grant]

On 30/05/2020 07:17, Eli Zaretskii wrote:
>> From: Jonny Grant <jg@jguk.org>
>> Date: Sat, 30 May 2020 01:00:30 +0100
>>
>> 2020-05-27  Jonny Grant  <jg@jguk.org>
>>
>> 	* doc/gdb.texinfo: Remove broken links Previous and Up from contents
> 
> Thanks, this is OK, except that the ChangeLog entry should end with a
> period.

Hi eli,

Would you like me to re-send it?

Jonny

Re: [PATCH]: texinfo remove broken links Previous and Up from contents

[Eli Zaretskii]

> From: Jonny Grant <jg@jguk.org>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 9 Jun 2020 13:51:55 +0100
> 
> >> 	* doc/gdb.texinfo: Remove broken links Previous and Up from contents
> > 
> > Thanks, this is OK, except that the ChangeLog entry should end with a
> > period.
> 
> Hi eli,
> 
> Would you like me to re-send it?

No, it just needs to be fixed by whoever pushes this change.

Re: [PATCH]: texinfo remove broken links Previous and Up from contents

[Simon Marchi]

On 2020-06-09 10:45 a.m., Eli Zaretskii wrote:
>> From: Jonny Grant <jg@jguk.org>
>> Cc: gdb-patches@sourceware.org
>> Date: Tue, 9 Jun 2020 13:51:55 +0100
>>
>>>> 	* doc/gdb.texinfo: Remove broken links Previous and Up from contents
>>>
>>> Thanks, this is OK, except that the ChangeLog entry should end with a
>>> period.
>>
>> Hi eli,
>>
>> Would you like me to re-send it?
> 
> No, it just needs to be fixed by whoever pushes this change.
> 

Eli, since you reviewed it and Jonny doesn't have push access, would you mind pushing it?

Thanks,

Simon

Re: [PATCH]: texinfo remove broken links Previous and Up from contents

[Eli Zaretskii]

> Cc: gdb-patches@sourceware.org
> From: Simon Marchi <simark@simark.ca>
> Date: Wed, 10 Jun 2020 19:29:47 -0400
> 
> > No, it just needs to be fixed by whoever pushes this change.
> > 
> 
> Eli, since you reviewed it and Jonny doesn't have push access, would you mind pushing it?

Fine with me, but where's the final patch, please?

Re: [PATCH]: texinfo remove broken links Previous and Up from contents

[Simon Marchi]

On 2020-06-10 10:35 p.m., Eli Zaretskii wrote:
>> Cc: gdb-patches@sourceware.org
>> From: Simon Marchi <simark@simark.ca>
>> Date: Wed, 10 Jun 2020 19:29:47 -0400
>>
>>> No, it just needs to be fixed by whoever pushes this change.
>>>
>>
>> Eli, since you reviewed it and Jonny doesn't have push access, would you mind pushing it?
> 
> Fine with me, but where's the final patch, please?
> 

You said the original patch was fine with the ChangeLog entry fixed (adding a period),
then said that it could be fixed by whoever pushed the patch, so I thought you could
do just that.

Anyway, I just fixed it and pushed the patch.

Simon

Re: [PATCH]: texinfo remove broken links Previous and Up from contents

[Eli Zaretskii]

> Cc: jg@jguk.org, gdb-patches@sourceware.org
> From: Simon Marchi <simark@simark.ca>
> Date: Wed, 10 Jun 2020 22:59:48 -0400
> 
> > Fine with me, but where's the final patch, please?
> > 
> 
> You said the original patch was fine with the ChangeLog entry fixed (adding a period),
> then said that it could be fixed by whoever pushed the patch, so I thought you could
> do just that.

Yes, I just got confused with what was the final version, and wanted
to be sure I do TRT.

> Anyway, I just fixed it and pushed the patch.

Thanks, and sorry for my confusion.

Re: [PATCH]: texinfo remove broken links Previous and Up from contents

[Jonny Grant]

On 11/06/2020 03:59, Simon Marchi wrote:
> On 2020-06-10 10:35 p.m., Eli Zaretskii wrote:
>>> Cc: gdb-patches@sourceware.org
>>> From: Simon Marchi <simark@simark.ca>
>>> Date: Wed, 10 Jun 2020 19:29:47 -0400
>>>
>>>> No, it just needs to be fixed by whoever pushes this change.
>>>>
>>>
>>> Eli, since you reviewed it and Jonny doesn't have push access, would you mind pushing it?
>>
>> Fine with me, but where's the final patch, please?
>>
> 
> You said the original patch was fine with the ChangeLog entry fixed (adding a period),
> then said that it could be fixed by whoever pushed the patch, so I thought you could
> do just that.
> 
> Anyway, I just fixed it and pushed the patch.
> 
> Simon

Great!

I saw the web pages just need to be re-generated when someone has a moment, they're from 7th March.
https://sourceware.org/gdb/current/onlinedocs/gdb/

Kind regards
Jonny