From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70]) by sourceware.org (Postfix) with ESMTPS id 430573853804 for ; Tue, 4 Oct 2022 08:15:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 430573853804 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cfCVU1VbQM8IZsvsgrw5qimTSfxlBSaHjkaQleb7Ni8Ga5eODvXdrEEdxlQPgDUCnk7gullNdL+mebuUX/wR4Fx4a4tHs/ju/d4fPNPbN+0iB2KU7uwRuiRwcVU1JY1vMuhtgtso6BopR1SHTs/xqGGr3m9BQujAQE/e0mVDrDBT0Ryt27gJXrzZ5UiG77AIs8S/gckcZg8is0Huqn3vK9h4QnRTzx4l4A4tTDf07/mLjOyeqVmEsG1+Z+LunSrCRkrn1KcyHx/kxczo87UIpx4e2O0IkQs8kTOixpwwEVp1FU5P8yg42dSKPS8zaZKTcAZswoR+aj5a1bbok5pu7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tj7QW8pt0aT6bz0luX4E2Y1ONb9dzg4gmtDbxG9MV4E=; b=eVFwpJ6H+OV8obqiVIbxQ5QjsxE8JHD22ZTRxTmkevnwiPhSpG7a6J0mdV2hH9ue5yLvqZdRKi/YMD/ZFqOAvDtMcqHFRAZc9aE7UhWUKE6/uXGyueCg3t5kzRCmHYW40S6QOgRXE5seEYLBY18/NcPOkigbqapTdHNUznqN8VnrmA4LaL6kpkyAB2093TmVM1nYrIcHqgIAj/lXlDPWeryLe76buYAopBv104uo3XhZPauvsuoMkky527oI3G2oVpSJo6F+YktWSex1rAPk8AUaexx1CqyqiSXgxd0oA5nuMSsiw+V8BT0LdfAnh4LA1dYuyCv6eyP+ziaO5la0eQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM5PR0701CA0014.eurprd07.prod.outlook.com (2603:10a6:203:51::24) by AM7PR08MB5496.eurprd08.prod.outlook.com (2603:10a6:20b:de::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Tue, 4 Oct 2022 08:15:30 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::65) by AM5PR0701CA0014.outlook.office365.com (2603:10a6:203:51::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.8 via Frontend Transport; Tue, 4 Oct 2022 08:15:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Tue, 4 Oct 2022 08:15:30 +0000 Received: ("Tessian outbound c2c2da38ad67:v128"); Tue, 04 Oct 2022 08:15:30 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 503a873e2782a2c1 X-CR-MTA-TID: 64aa7808 Received: from adc4288d6ca9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2D5FB102-A254-4936-A2CC-6F3CE349C4E4.1; Tue, 04 Oct 2022 08:15:24 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id adc4288d6ca9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Oct 2022 08:15:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pr3wI1txIcrp9Wzz5Ai+jIWifOy08C4MpywrOLHzMVYzLsU3/g3TQZUs3WPBVAXgk8GYV41tkiW6r1euvCDTQIoeGsKFysI34wz080ez0GMRb5lpYlkUKYLG85KT0BiDnRKFUABLZ+5pt2mgVCjD72ZKbFdd2YR44nVL45Jb0NQcY9IizqwtTZjeiToU725kzCDFoIpOqIUE19sEAYa4z22V+OlBA64FEds273sqTKZBFZ2xSS2KfusTh2/6v2/xdAGaKmU/jH5vs1bR+2ikdgprFVSqlaLY7M/QSdITgQTFcW18o7zoT4BvWBhOfBa1VA4LXq8d94Mxji+0kMCsuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tj7QW8pt0aT6bz0luX4E2Y1ONb9dzg4gmtDbxG9MV4E=; b=UAOy1VIO1zqEtF1H5nqFJGvzX9ej1YMYY6ox+4K4s4nDE48u1/qYLhmlWQq6Pfl8MamwVjK/+UpnJ5E6AMSp4xcj0PpzJJdxE/qvmxVUjyHvA2fOlx3BE/BkRxvvhsuPstBYoULrnjIFCc1NZeQ2BKaDwDYDzk1WxRUfV6LhMqGPLndDn01HWb4VODYrohUIt2aF/U8Up9jZw9M0DMOA7YrJUnI5cYUFgBOfzAiACdjk3UFTx7N84fRoaiEetYratU5vVDGY7Jxes7vbo2ru4+A3fPqOSyw25kn4ePDMqKPeUtbuQogo9HeMxAvPtJFqL/LplsbnuEfS5ykfRJ7kKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by GV2PR08MB7929.eurprd08.prod.outlook.com (2603:10a6:150:ac::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Tue, 4 Oct 2022 08:15:22 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094%5]) with mapi id 15.20.5676.028; Tue, 4 Oct 2022 08:15:22 +0000 Message-ID: Date: Tue, 4 Oct 2022 09:15:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] [AArch64] Update FPSR/FPCR fields for FPU and SVE Content-Language: en-US To: gdb-patches@sourceware.org References: <20220923103946.96804-1-luis.machado@arm.com> From: Luis Machado In-Reply-To: <20220923103946.96804-1-luis.machado@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0103.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::19) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|GV2PR08MB7929:EE_|AM7EUR03FT023:EE_|AM7PR08MB5496:EE_ X-MS-Office365-Filtering-Correlation-Id: bcc447ab-7d0f-400b-4841-08daa5e09a4a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NCz9tJobYZNAHxGMsKCC2exxS3X96jUSUBvh8iqkN/KTh0KRH5+Xr0/QyRdIGHPZxxoobvJbYDP1aGzkGumCW6WJ5YQJR1iUPFPE67rDOKYcjpiZY1dLYZ0bQNvb5HCFuP+sXF9faOdXGcThuWnCIKBUUIjHCZTdeqqNIhwZjYuS8Li+0gsqCICZETmUWQeXmdiVJGM+UUYxTJv+3wqallP8AlHenakPYfSjXZxQnTKtxV9A9rDcrqFUgCEHwGJqaPad8sYekPF+4hBSQK7tALkX8Zalj1G43HndPar6/nN9g/HOYgJsuo/F6pnOHSXmb0UltiHeLLAHL2KOOUYzDislnIqcL+w43zcOhFeKlQWbCAX7DjzJ3uRgNwEu4R1Wu/Kkmh4eBvMZiHkI0Ez95lyBcvkILEKIy+rKPut5d+QScDj71zjmZzC2BBPTXQOMBK6EGcOj9r4eUcKI3lpOrOm1WNkrmHArV/j7Yz01io50Jgz36Zmbc18/0k4FQhUzg1TladOhJJW/kShcHA8xzJ3hIJKT47t5eoaEfYIgNBsufSz4OQyGtXmg3IUIoy2OvWWbb79zYWK24YvVFN9EekOpkCUw7jIN5E2iDLzktKyWu6kjqhc1GPoOwapyeBxoIuSHVEzS8WvEdiVk6ZhuTm3j8dwxIBxh5GukuFs9JqHsgNs4MPnu2arz+aOs8fOpGwj+z3ufHlerDTdb2ymqE09f8mziUuXQQ5M57E/7q8lvlaJrv4xqwgB7k4b3f8Dybx6LeNf6r+t+aN6n5JmuX+bcDhVHcKUmgD222RCVgtU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(451199015)(31696002)(5660300002)(31686004)(186003)(6512007)(66476007)(26005)(2616005)(38100700002)(478600001)(316002)(6506007)(6486002)(8936002)(2906002)(83380400001)(53546011)(15650500001)(6916009)(36756003)(41300700001)(66946007)(86362001)(66556008)(8676002)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB7929 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e3693f75-d985-4b47-bb8a-08daa5e09537 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x2uhsNBQ+woz66aVbGSXcpsVQHghTkAQgVZVzJlS+H9hyb2SB+1djFOO5bd71eQKSuRGCuW9KfJyBoZcHerRE+DgSD+AAsdXtZBA19kZ4LrghZRTwZLBPNxVDilV75RVKMKkEUYfj/BPkKDoR6fun2padrM9CaZx9+x/B2DBxGS3NgH32txeIqG2odT/44DmJP9RkFXvpuUIDpPD9mHOMChSJZOKOOW7k8nrEh8HDd4Tq/EawZ+8JTKyPiHzQzSPBgtaVtgkQ14feJZkv/FmUy4iAnYeEvD5LUJ23H2kjo1zZm6w73NlOcSkY1lqa7/kmc9GEMe1D+OE1Scol7qy6yxeGSelKGKP1RtopsRfmfrVxp4ABu75EywKlNJKsWuPjxMizKqAcwh+U596UPAlZ4cuMl1C7QxUhtJN+KoG4PzD54iUZELtc7Dk/c219IqQ/L+tbAIFK0PoLNhOCsXLi6w6wFgZDgOaGjwtO003EoX0SmCz/J7Ks9+d/EL1B7HxQj1MQYahiLOjctO5Vfb52oP8E7pQ3G01YcAXYWPboYUzeugHMdiBdBH0n/1eUpitCMHmtVW25enEQ9XTJs9lkCOOREw4/KWqQVCF6xZ73RrAgIsV+dEbz2ge0sIGd4skW9ztqTpbxm0l3krZimqd646bz0zj6mmQGmuXu4CplNk++xqoTP6ZmH3YLjrpEI53+IV2HSUDOvIdjoVEDtgyCEZg15EYv170GFsRzl2P6hN6IFaM2NxOQPKWR5XJ3gEHrUI8KB3qgBKNUA8qth7lDQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(376002)(39850400004)(346002)(136003)(451199015)(36840700001)(46966006)(31686004)(2906002)(5660300002)(316002)(15650500001)(44832011)(36860700001)(8676002)(70206006)(70586007)(6486002)(82310400005)(6916009)(86362001)(36756003)(8936002)(41300700001)(31696002)(478600001)(53546011)(26005)(83380400001)(336012)(6506007)(2616005)(40480700001)(82740400003)(47076005)(356005)(81166007)(6512007)(186003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 08:15:30.5382 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bcc447ab-7d0f-400b-4841-08daa5e09a4a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5496 X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2022 08:15:39 -0000 On 9/23/22 11:39, Luis Machado via Gdb-patches wrote: > I noticed some missing flags/fields from FPSR and FPCR registers in > both the FPU and SVE target descriptions. > > This patch adds those and makes the SVE versions of FPSR and FPCR > use the proper flags/bitfields types. > --- > gdb/features/aarch64-fpu.c | 3 +++ > gdb/features/aarch64-fpu.xml | 14 +++++++++++++ > gdb/features/aarch64-sve.c | 39 ++++++++++++++++++++++++++++++++++-- > 3 files changed, 54 insertions(+), 2 deletions(-) > > diff --git a/gdb/features/aarch64-fpu.c b/gdb/features/aarch64-fpu.c > index a80b7d4c1b8..27e75524cfe 100644 > --- a/gdb/features/aarch64-fpu.c > +++ b/gdb/features/aarch64-fpu.c > @@ -126,8 +126,11 @@ create_feature_aarch64_fpu (struct target_desc *result, long regnum) > tdesc_add_flag (type_with_fields, 10, "OFE"); > tdesc_add_flag (type_with_fields, 11, "UFE"); > tdesc_add_flag (type_with_fields, 12, "IXE"); > + tdesc_add_flag (type_with_fields, 13, "EBF"); > tdesc_add_flag (type_with_fields, 15, "IDE"); > + tdesc_add_bitfield (type_with_fields, "Len", 16, 18); > tdesc_add_flag (type_with_fields, 19, "FZ16"); > + tdesc_add_bitfield (type_with_fields, "Stride", 20, 21); > tdesc_add_bitfield (type_with_fields, "RMode", 22, 23); > tdesc_add_flag (type_with_fields, 24, "FZ"); > tdesc_add_flag (type_with_fields, 25, "DN"); > diff --git a/gdb/features/aarch64-fpu.xml b/gdb/features/aarch64-fpu.xml > index 4db5c50f250..89bbcc0a855 100644 > --- a/gdb/features/aarch64-fpu.xml > +++ b/gdb/features/aarch64-fpu.xml > @@ -142,11 +142,25 @@ > > > > + > + > > > + > + > > > + > + > > > > diff --git a/gdb/features/aarch64-sve.c b/gdb/features/aarch64-sve.c > index 9f6c2522b4c..7b4a510633d 100644 > --- a/gdb/features/aarch64-sve.c > +++ b/gdb/features/aarch64-sve.c > @@ -40,6 +40,41 @@ create_feature_aarch64_sve (struct target_desc *result, long regnum, > size_t p_size = scale << 4; > tdesc_create_vector (feature, "svep", element_type, p_size >> 3); > > + /* FPSR register type */ > + tdesc_type_with_fields *type_with_fields > + = tdesc_create_flags (feature, "fpsr_flags", 4); > + tdesc_add_flag (type_with_fields, 0, "IOC"); > + tdesc_add_flag (type_with_fields, 1, "DZC"); > + tdesc_add_flag (type_with_fields, 2, "OFC"); > + tdesc_add_flag (type_with_fields, 3, "UFC"); > + tdesc_add_flag (type_with_fields, 4, "IXC"); > + tdesc_add_flag (type_with_fields, 7, "IDC"); > + tdesc_add_flag (type_with_fields, 27, "QC"); > + tdesc_add_flag (type_with_fields, 28, "V"); > + tdesc_add_flag (type_with_fields, 29, "C"); > + tdesc_add_flag (type_with_fields, 30, "Z"); > + tdesc_add_flag (type_with_fields, 31, "N"); > + > + /* FPCR register type */ > + type_with_fields = tdesc_create_flags (feature, "fpcr_flags", 4); > + tdesc_add_flag (type_with_fields, 0, "FIZ"); > + tdesc_add_flag (type_with_fields, 1, "AH"); > + tdesc_add_flag (type_with_fields, 2, "NEP"); > + tdesc_add_flag (type_with_fields, 8, "IOE"); > + tdesc_add_flag (type_with_fields, 9, "DZE"); > + tdesc_add_flag (type_with_fields, 10, "OFE"); > + tdesc_add_flag (type_with_fields, 11, "UFE"); > + tdesc_add_flag (type_with_fields, 12, "IXE"); > + tdesc_add_flag (type_with_fields, 13, "EBF"); > + tdesc_add_flag (type_with_fields, 15, "IDE"); > + tdesc_add_bitfield (type_with_fields, "Len", 16, 18); > + tdesc_add_flag (type_with_fields, 19, "FZ16"); > + tdesc_add_bitfield (type_with_fields, "Stride", 20, 21); > + tdesc_add_bitfield (type_with_fields, "RMode", 22, 23); > + tdesc_add_flag (type_with_fields, 24, "FZ"); > + tdesc_add_flag (type_with_fields, 25, "DN"); > + tdesc_add_flag (type_with_fields, 26, "AHP"); > + > tdesc_create_reg (feature, "z0", regnum++, 1, nullptr, z_size, "svez"); > tdesc_create_reg (feature, "z1", regnum++, 1, nullptr, z_size, "svez"); > tdesc_create_reg (feature, "z2", regnum++, 1, nullptr, z_size, "svez"); > @@ -72,8 +107,8 @@ create_feature_aarch64_sve (struct target_desc *result, long regnum, > tdesc_create_reg (feature, "z29", regnum++, 1, nullptr, z_size, "svez"); > tdesc_create_reg (feature, "z30", regnum++, 1, nullptr, z_size, "svez"); > tdesc_create_reg (feature, "z31", regnum++, 1, nullptr, z_size, "svez"); > - tdesc_create_reg (feature, "fpsr", regnum++, 1, nullptr, 32, "int"); > - tdesc_create_reg (feature, "fpcr", regnum++, 1, nullptr, 32, "int"); > + tdesc_create_reg (feature, "fpsr", regnum++, 1, nullptr, 32, "fpsr_flags"); > + tdesc_create_reg (feature, "fpcr", regnum++, 1, nullptr, 32, "fpcr_flags"); > tdesc_create_reg (feature, "p0", regnum++, 1, nullptr, p_size, "svep"); > tdesc_create_reg (feature, "p1", regnum++, 1, nullptr, p_size, "svep"); > tdesc_create_reg (feature, "p2", regnum++, 1, nullptr, p_size, "svep"); Pushed now.