From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 9C4973898534
 for <gdb-patches@sourceware.org>; Tue, 19 May 2020 17:13:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9C4973898534
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.193] (unknown [192.222.164.54])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 270B11E79B;
 Tue, 19 May 2020 13:13:39 -0400 (EDT)
Subject: Re: [PATCH 2/2] gdb/testsuite: add inferior arguments test
To: Pedro Alves <palves@redhat.com>, Simon Marchi
 <simon.marchi@efficios.com>, gdb-patches@sourceware.org,
 Michael Weghorn <m.weghorn@posteo.de>
References: <1190e73a-8f10-dc6d-4d59-b9a2929530ad@simark.ca>
 <20200510155937.1064329-1-simon.marchi@efficios.com>
 <20200510155937.1064329-2-simon.marchi@efficios.com>
 <c367468e-9892-ced5-1b71-7a7d7ced8e9a@redhat.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <e8c678ce-9714-6199-db7d-41c9f04f3bce@simark.ca>
Date: Tue, 19 May 2020 13:13:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <c367468e-9892-ced5-1b71-7a7d7ced8e9a@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2020 17:13:40 -0000

On 2020-05-15 4:07 p.m., Pedro Alves via Gdb-patches wrote:
> On 5/10/20 4:59 PM, Simon Marchi via Gdb-patches wrote:
> 
>> +++ b/gdb/testsuite/gdb.base/inferior-args.c
>> @@ -0,0 +1,8 @@
>> +#include <stdio.h>
>> +
>> +int main(int argc, char **argv) {
>> +	for (int i = 0; i < argc; i++)
>> +		printf("[%d] %s\n", i, argv[i]);
>> +
>> +	return 0;
>> +}
> 
> Formatting.  Also missing copyright header.
> 
>> +standard_testfile .c
>> +
>> +if {[build_executable "failed to prepare" $testfile $srcfile debug] == -1} {
>> +    return
>> +}
>> +
>> +clean_restart $binfile
> 
> This seems unnecessary, since do_test already calls it.
> 
> Otherwise, you can use prepare_for_testing here.
> 
>> +
>> +proc do_test { method } {
>> +    global binfile hex
>> +
>> +    # The second arg is an empty string on purpose.
>> +    set inferior_args { "first arg" "" "third-arg" }
>> +
>> +    clean_restart $binfile
> Otherwise LGTM.
> 
> Thanks,
> Pedro Alves
> 

Thanks for the comments.  Michael, would you mind addressing these changes
in my patches in your branch?

Simon