From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/2] Add Rust support to source highlighting
Date: Mon, 19 Aug 2019 18:29:00 -0000 [thread overview]
Message-ID: <e8ccd456-a42f-00ed-d820-383a55cc66a7@redhat.com> (raw)
In-Reply-To: <87imqtqga7.fsf@tromey.com>
On 8/19/19 5:19 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> This is v2 of the patch to add Rust support to source highlighting.
> Tom> This version addresses the --static-libstdc++ problem that was found
> Tom> with the previous patch, using the approach suggested by Pedro.
>
> Tom> Let me know what you think. If this seems ok, my plan is to send the
> Tom> top-level configury patch to gcc-patches for approval, and only then
> Tom> check everything in. This plan avoids any problem if the gcc
> Tom> maintainers request a different option name.
>
> I've checked in the gcc patch, and I've updated the gdb patch to account
> for other recent changes to source-cache.c. I am going to check this in
> now.
Thanks for doing this. I didn't realize until now that this series
included such a patch, but reading it now I'm quite happy with it.
Thanks for tackling that, and working with gcc upstream.
Thanks,
Pedro Alves
prev parent reply other threads:[~2019-08-19 18:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 15:52 Tom Tromey
2019-07-27 15:52 ` [PATCH v2 1/2] Add --with-static-standard-libraries to the top level Tom Tromey
2019-07-27 15:52 ` [PATCH v2 2/2] Add Rust support to source highlighting Tom Tromey
2019-09-04 17:22 ` Tom de Vries
2019-09-10 15:56 ` Tom Tromey
2019-09-12 19:20 ` Tom de Vries
2019-09-17 18:24 ` Tom Tromey
2019-09-18 22:16 ` Tom de Vries
2019-09-19 12:54 ` Tom Tromey
2019-09-19 16:18 ` [PATCH][gdb] Catch exception when constructing the highlighter Tom de Vries
2019-08-19 16:19 ` [PATCH v2 0/2] Add Rust support to source highlighting Tom Tromey
2019-08-19 18:29 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8ccd456-a42f-00ed-d820-383a55cc66a7@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).