From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46370 invoked by alias); 19 Aug 2019 18:29:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46357 invoked by uid 89); 19 Aug 2019 18:29:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Aug 2019 18:29:24 +0000 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 422FF7BDB0 for ; Mon, 19 Aug 2019 18:29:23 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id k8so4535148wrx.19 for ; Mon, 19 Aug 2019 11:29:23 -0700 (PDT) Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id f192sm13468206wmg.30.2019.08.19.11.29.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2019 11:29:21 -0700 (PDT) Subject: Re: [PATCH v2 0/2] Add Rust support to source highlighting To: Tom Tromey References: <20190727155155.32417-1-tom@tromey.com> <87imqtqga7.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Mon, 19 Aug 2019 18:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87imqtqga7.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00418.txt.bz2 On 8/19/19 5:19 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> This is v2 of the patch to add Rust support to source highlighting. > Tom> This version addresses the --static-libstdc++ problem that was found > Tom> with the previous patch, using the approach suggested by Pedro. > > Tom> Let me know what you think. If this seems ok, my plan is to send the > Tom> top-level configury patch to gcc-patches for approval, and only then > Tom> check everything in. This plan avoids any problem if the gcc > Tom> maintainers request a different option name. > > I've checked in the gcc patch, and I've updated the gdb patch to account > for other recent changes to source-cache.c. I am going to check this in > now. Thanks for doing this. I didn't realize until now that this series included such a patch, but reading it now I'm quite happy with it. Thanks for tackling that, and working with gcc upstream. Thanks, Pedro Alves