From: Paulo Neves <ptsneves@gmail.com>
To: Andrew Burgess <aburgess@redhat.com>,
Paulo Neves via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 2/3] gdb/python doc: Add enable property to the unwinder example
Date: Fri, 3 Jun 2022 17:54:36 +0200 [thread overview]
Message-ID: <e8d59e08-2a85-2f2a-d32a-e6039aaa27ad@gmail.com> (raw)
In-Reply-To: <87sfore40u.fsf@redhat.com>
On 5/30/22 11:57, Andrew Burgess wrote:
> Paulo Neves via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> The enable property is now also in the example code making it clear how
>> it is used and how it influences the operation of an unwinder.
>> ---
>> gdb/doc/python.texi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
>> index 5b7fba798a9..444e332d752 100644
>> --- a/gdb/doc/python.texi
>> +++ b/gdb/doc/python.texi
>> @@ -2796,6 +2796,11 @@ class FrameId(object):
>> class MyUnwinder(Unwinder):
>> def __init__(....):
>> super(MyUnwinder, self).__init___(<expects unwinder name argument>)
>> + # If set to True the unwinder will be enabled.
>> + # If upon registration the enable property is True, the unwinder
>> + # will be usable immediately.
>> + # gdb or code may change value.
>> + self.enabled = <True|False>
> Everything I said about patch #1 applies here too.
>
> I think your comment could be shortened to just:
>
> # If set to True the unwinder will be enabled and available for use.
>
> Given that text I think most users will assume that setting the field to
> `True` in the constructor will result in the unwinder being available
> upon registration.
I think that part can be indeed removed but I think the hint that gdb
may change values of your unwinder is important. I wrote these changes
though the eyes of the difficulties I had as an absolute GDB extension
newbie.
> Thanks,
> Andrew
>
>
>>
>> def __call__(pending_frame):
>> if not <we recognize frame>:
>> --
>> 2.25.1
next prev parent reply other threads:[~2022-06-03 15:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 11:55 python unwinder doc improvement Paulo Neves
2022-05-28 11:55 ` [PATCH 1/2] gdb/python doc: Add register_unwinder to code example Paulo Neves
2022-05-28 12:20 ` Eli Zaretskii
2022-06-21 11:17 ` Paulo Neves
2022-06-21 12:19 ` Eli Zaretskii
2022-09-30 11:59 ` Paulo Neves
2022-09-30 12:25 ` Eli Zaretskii
2022-05-28 11:55 ` [PATCH 2/2] gdb/python doc: Add enable property to the unwinder example Paulo Neves
2022-05-28 12:22 ` Eli Zaretskii
2022-05-28 13:35 ` Paulo Neves
2022-05-28 13:29 ` [PATCH v2 1/3] gdb/python doc: Add register_unwinder to code example Paulo Neves
2022-05-28 13:29 ` [PATCH v2 2/3] gdb/python doc: Add enable property to the unwinder example Paulo Neves
2022-05-30 9:57 ` Andrew Burgess
2022-06-03 15:54 ` Paulo Neves [this message]
2022-05-28 13:29 ` [PATCH v2 3/3] gdb/python doc: Fix confusion between gdb.unwinders and gdb.unwinder Paulo Neves
2022-05-30 9:33 ` Andrew Burgess
2022-05-30 9:55 ` [PATCH v2 1/3] gdb/python doc: Add register_unwinder to code example Andrew Burgess
2022-05-30 10:12 ` Paulo Neves
2022-06-03 16:01 ` [PATCH v3 1/4] " Paulo Neves
2022-06-03 16:01 ` [PATCH v3 2/4] gdb/python doc: Add enable property to the unwinder example Paulo Neves
2022-06-03 16:17 ` Eli Zaretskii
2022-06-03 16:01 ` [PATCH v3 3/4] gdb/python doc: Fix confusion between gdb.unwinders and gdb.unwinder Paulo Neves
2022-06-03 16:17 ` Eli Zaretskii
2022-06-03 16:01 ` [PATCH v3 4/4] gdb/python doc: Move unwinder skeleton code Paulo Neves
2022-06-03 16:20 ` Eli Zaretskii
2022-06-03 16:38 ` Paulo Neves
2022-09-30 14:50 ` Pedro Alves
2022-09-30 15:53 ` Eli Zaretskii
2022-09-30 16:41 ` Pedro Alves
2022-09-30 17:37 ` Eli Zaretskii
2022-10-21 21:07 ` Pedro Alves
2022-10-22 6:41 ` Paulo Neves
2022-10-22 6:41 ` Paulo Neves
2022-06-03 16:17 ` [PATCH v3 1/4] gdb/python doc: Add register_unwinder to code example Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8d59e08-2a85-2f2a-d32a-e6039aaa27ad@gmail.com \
--to=ptsneves@gmail.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).