From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by sourceware.org (Postfix) with ESMTPS id 831CA38323E5 for ; Tue, 21 Feb 2023 12:52:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 831CA38323E5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x829.google.com with SMTP id h19so1331037qtk.7 for ; Tue, 21 Feb 2023 04:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=XkXjAb5Vxlb/6stkQf/k6RlyNT3XG4RhK6L6r+4Kk+o=; b=Y5fhJh1rXTJSE0U19KhnP3XeG8ZFsRbZtlE5lECSe6L1vTgBb5W0OI/KFDVuCVzZBs i4f+DZj3V1A7S8Dvqu8iH9uG9X1E5H4Xy7OvGWPwKWKvjN9tg2xHIsQqLbx9mtGgiB30 bGuMuQFpxoF/f59Y9QKfIt/NsxJGnr7iaxLYSuJcLvP/Lw+RlldvzwBENc/L8nntMsMv aHSIgLSLmYoGTvRFK5qR2e0iJ9SbH2E34cUKCB9ChNuLHtwOJha1uuy8ZF4lWHDGPrGE XGxZz8QbunA4zSzYuZOIIvbu6Q8BJ/Qhd4iMkhGjzb4x/th2oOfbvMEZaXBgbddJnvXi BorQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XkXjAb5Vxlb/6stkQf/k6RlyNT3XG4RhK6L6r+4Kk+o=; b=GNJcXr/LD+6s+8txsEgUsoUzdkxySAYnX2hC5rxYwf8zuODjkFyJtVx2oB4qppwphq RMDWdR0ifQkzAOK0MbAIprhiuwsRA/2SYVtV2lXyGz0bGhH+VFYBFJrd3iqBpHVgLJ6X ptsxXoA857By0bHoBozQgEeZq6x9DlpEjDamjqjIRKXs9EdOMSyqrFkAjO3D6mUcmGVz ZJJR9rgys1NsH7D+OSFL7sx8JhxuncbSaPx2xFkBBKyChU8L+F+iMsHnFgV1Grlp7A7J qzHMQBCAEeQ0eccGI2qzJhgLZTNsDCDUe02amsiUJf2X+W9nMDV9S5syqwvDeXn1Kp6G b3fA== X-Gm-Message-State: AO0yUKXz9yGGxqOGOj9OLH97rjp5t03TmYh1tyuxvA8Jf0Oz7C7iadzV JB0MNABoKkPCFsEiAM0bpD7CNHk+UdA= X-Google-Smtp-Source: AK7set/UvH0WY/+KK6e9DJHP80C7INhOqpy+R2qak6hwcF6aEIg0lRy8s0c/5AJqu3sDBZvEwxdMAQ== X-Received: by 2002:a05:622a:34a:b0:3b1:80ab:38e with SMTP id r10-20020a05622a034a00b003b180ab038emr21149645qtw.0.1676983958549; Tue, 21 Feb 2023 04:52:38 -0800 (PST) Received: from [192.168.1.128] (173-246-5-136.qc.cable.ebox.net. [173.246.5.136]) by smtp.gmail.com with ESMTPSA id el15-20020a05622a430f00b003bb8c60cdf1sm802243qtb.78.2023.02.21.04.52.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 04:52:37 -0800 (PST) Subject: Re: [PATCH v2] gdb: add --with-curses to --configuration output To: Simon Marchi , gdb-patches@sourceware.org References: <20230211-configuration-show-curses-v2-1-a28c6ea6f00a@gmail.com> <7a7dbf0d-c6d6-22bc-5bb1-c671b7720424@simark.ca> From: Philippe Blain Message-ID: Date: Tue, 21 Feb 2023 07:52:57 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <7a7dbf0d-c6d6-22bc-5bb1-c671b7720424@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, Le 2023-02-20 à 12:08, Simon Marchi a écrit : >> diff --git a/gdb/configure.ac b/gdb/configure.ac >> index 7c7bf88b3fb..6ad0f9d8815 100644 >> --- a/gdb/configure.ac >> +++ b/gdb/configure.ac >> @@ -563,11 +563,11 @@ if test x"$prefer_curses" = xyes; then >> # search /usr/local/include, if ncurses is installed in /usr/local. A >> # default installation of ncurses on alpha*-dec-osf* will lead to such >> # a situation. >> - AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses]) >> - >> - if test "$ac_cv_search_waddstr" != no; then >> - curses_found=yes >> - fi >> + AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses], >> + [curses_found=yes && >> + AC_DEFINE([HAVE_LIBCURSES], [1], >> + [Define to 1 if curses is enabled.]) >> + ]) > > I don't think the `&&` is needed, you can just put each action on its > own line. It becomes regular shell script in the end. I tried removing > it on my side, it seems to work fine. If that work for you too, I can > push the patch with that little change. Yes, that sounds good to me. Thanks! Philippe.