Re: [RFC] [gdb/cli] Allow source highlighting to be interrupted

[Tom de Vries <tdevries@suse.de>]

On 10/11/23 23:56, Tom de Vries wrote:
> On 10/11/23 19:02, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>>
>> Tom> Breakpoint 1, Solution::numOfSubarrays (this=0x7fffffffdbcf, 
>> arr=...) at test.cpp:56
>> Tom> ^Cwarning: Couldn't highlight source file 
>> /data/vries/gdb/test.cpp: Interrupted
>> Tom> 56            return (int) t;
>> Tom> (gdb)
>> Tom> ...
>>
>> Tom> RFC: is the warning a good idea, or overkill?
>>
>> I'm on the fence,
> 
> Hmm, I just realized that the line can be (and in the setup I'm looking 
> at actually is) highlighted, not by GNU source-hightlight but by python 
> pygments, which makes the warning in the current form confusing.
> 
>> though I guess if it can't be done it might be nice if
>> gdb kept track of this and just didn't try highlighting that file again.
>>
> 
> Sounds doable.
> 

I've submitted a patch series ( 
https://sourceware.org/pipermail/gdb-patches/2023-October/203179.html ) 
that:
- drops the warning, and
- adds the tracking of files for which highlighting fails.

Thanks,
- Tom