From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 4EF0D385E038 for ; Thu, 12 Oct 2023 14:52:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4EF0D385E038 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3FB831F8A4; Thu, 12 Oct 2023 14:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1697122325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KCWHlxk2OAdLbZ2o5qdhoUyzX2POe3QuhQD/ShBzkyo=; b=xSSIHRhsRUd1h9LdMwoVVp7qR0j9vAIkzkE8Vd0rAlkAhcDwEH4yT8j2Yfm6KXSIs1eQQT 2z1kach+LaJtiU0qHf/UTnVJOgVNFJnv39uRFqhvt5eoaBZRqHFspud0zW4h6aVWFC81wG Vcuja+mBzHc8xbyUIuEce5f5UYLqMyM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1697122325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KCWHlxk2OAdLbZ2o5qdhoUyzX2POe3QuhQD/ShBzkyo=; b=yZVDfYV4Ra5tPmhd+xJmSnxpTuOhWNCpU0yJe7868YZOJRsYQoTp6g3rTVWo8mszIzcv2J S5mwhJqI3ZGKWNCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 235E7139F9; Thu, 12 Oct 2023 14:52:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id R4g4BxUIKGXGIgAAMHmgww (envelope-from ); Thu, 12 Oct 2023 14:52:05 +0000 Message-ID: Date: Thu, 12 Oct 2023 16:52:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] [gdb/cli] Allow source highlighting to be interrupted Content-Language: en-US From: Tom de Vries To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231011134247.3832-1-tdevries@suse.de> <87jzrtt7lp.fsf@tromey.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -4.10 X-Spamd-Result: default: False [-4.10 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-0.01)[45.66%]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-3.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/11/23 23:56, Tom de Vries wrote: > On 10/11/23 19:02, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries writes: >> >> Tom> Breakpoint 1, Solution::numOfSubarrays (this=0x7fffffffdbcf, >> arr=...) at test.cpp:56 >> Tom> ^Cwarning: Couldn't highlight source file >> /data/vries/gdb/test.cpp: Interrupted >> Tom> 56            return (int) t; >> Tom> (gdb) >> Tom> ... >> >> Tom> RFC: is the warning a good idea, or overkill? >> >> I'm on the fence, > > Hmm, I just realized that the line can be (and in the setup I'm looking > at actually is) highlighted, not by GNU source-hightlight but by python > pygments, which makes the warning in the current form confusing. > >> though I guess if it can't be done it might be nice if >> gdb kept track of this and just didn't try highlighting that file again. >> > > Sounds doable. > I've submitted a patch series ( https://sourceware.org/pipermail/gdb-patches/2023-October/203179.html ) that: - drops the warning, and - adds the tracking of files for which highlighting fails. Thanks, - Tom