From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] [gdb] Fix segfault in for_each_block, part 1
Date: Tue, 7 Nov 2023 14:32:08 +0100 [thread overview]
Message-ID: <e9194c6a-366c-49af-ae31-8940779add53@suse.de> (raw)
In-Reply-To: <3040273d-76d9-43a3-a9a6-5b7225276cc6@simark.ca>
On 11/6/23 18:05, Simon Marchi wrote:
> Implementation question: is there any reason you didn't choose
> std::shared_ptr? For objects that are new'ed / delete'd, that seems like
> a good choice.
No particular reason other than that I'm unfamiliar with std::shared_ptr.
In the v2 (
https://sourceware.org/pipermail/gdb-patches/2023-November/203850.html )
I've used std::shared_ptr.
Thanks,
- Tom
next prev parent reply other threads:[~2023-11-07 13:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 15:57 [PATCH 0/2] [gdb] Fix segfault in for_each_block Tom de Vries
2023-11-04 15:57 ` [PATCH 1/2] [gdb] Fix segfault in for_each_block, part 1 Tom de Vries
2023-11-06 15:24 ` Andrew Burgess
2023-11-07 13:28 ` Tom de Vries
2023-11-06 17:05 ` Simon Marchi
2023-11-07 11:16 ` Andrew Burgess
2023-11-07 13:32 ` Tom de Vries [this message]
2023-11-04 15:57 ` [PATCH 2/2] [gdb] Fix segfault in for_each_block, part 2 Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9194c6a-366c-49af-ae31-8940779add53@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).