From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=tgSc=GU=suse.de=tdevries@sourceware.org>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
	by sourceware.org (Postfix) with ESMTPS id 124C0385703F
	for <gdb-patches@sourceware.org>; Tue,  7 Nov 2023 13:30:49 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 124C0385703F
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 124C0385703F
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1c
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699363850; cv=none;
	b=G3KTJZiN3KpE2AId4UQJyhJf5oxBUFBAkR+26+aSAsB+kzsGDxD/rjayZdVYFv44WiypSNBtuV4BPdPaP/rilFdNjGEbYkQiJIcA/21XlenNKzHCgU8LbfQXUQWjTdgrxU7FiXriXeeFVtqGYA0lCH2XW+iq179O+8nERmGIyfg=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1699363850; c=relaxed/simple;
	bh=kMfnOTgHVkWi10d2cF5nvgHpIvZH+2A499L6ScF41oM=;
	h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version:
	 Subject:To:From; b=U/sbKtAVxeGfRnR1JW7X2Ar7tuTSKJ2DlfA+iX+xuJ+66GHC+eJ40pB+44IAGUe7lM0b5BQ/IAXZdk8oOSROEdKXu3tpuHoAo12PGbTbJJGmOxBaKWA9AWeXMiCyT9s9rL0tncdowGafMYAWrNklaaekwpO7fOxWNwoShT9nUrA=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by smtp-out1.suse.de (Postfix) with ESMTPS id 4143721901;
	Tue,  7 Nov 2023 13:30:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1699363848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xvrXofAVTRWi+nkccBJ32hEpxaYelQA3SbUSSlHHtgE=;
	b=AFIk2FrUG+d9vpjmivfXSWPlMTeiO9QGCDt65dfFOgGoA1TcjBeml8OUn4Xsp3ce7YOlpz
	Fy39A7a0v11GwQlRqDkT8s51BAcaMxAuu6IsdCtwJrL5e4m9umoNscc41cR3wU/sn0VaiY
	9Ou2vx7IpgRYPy4hRpfbbECduDDWwSw=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1699363848;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xvrXofAVTRWi+nkccBJ32hEpxaYelQA3SbUSSlHHtgE=;
	b=bnp0C4jHWf/kfP7dg8VCg9U+2weqIR6FqKJ30ERfQ1Mw4AhTWGqrPIXU5ryPibYmHj3sHP
	5PxvT2IFZFZA4xDA==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2EFC513907;
	Tue,  7 Nov 2023 13:30:48 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
	by imap2.suse-dmz.suse.de with ESMTPSA
	id YiZQCgg8SmVfYwAAMHmgww
	(envelope-from <tdevries@suse.de>); Tue, 07 Nov 2023 13:30:48 +0000
Message-ID: <e9194c6a-366c-49af-ae31-8940779add53@suse.de>
Date: Tue, 7 Nov 2023 14:32:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] [gdb] Fix segfault in for_each_block, part 1
Content-Language: en-US
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
References: <20231104155757.16649-1-tdevries@suse.de>
 <20231104155757.16649-2-tdevries@suse.de>
 <3040273d-76d9-43a3-a9a6-5b7225276cc6@simark.ca>
From: Tom de Vries <tdevries@suse.de>
In-Reply-To: <3040273d-76d9-43a3-a9a6-5b7225276cc6@simark.ca>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 11/6/23 18:05, Simon Marchi wrote:
> Implementation question: is there any reason you didn't choose 
> std::shared_ptr? For objects that are new'ed / delete'd, that seems like 
> a good choice.

No particular reason other than that I'm unfamiliar with std::shared_ptr.

In the v2 ( 
https://sourceware.org/pipermail/gdb-patches/2023-November/203850.html ) 
I've used std::shared_ptr.

Thanks,
- Tom