From: John Baldwin <jhb@FreeBSD.org>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 00/19] Simplify GDB output functions
Date: Sat, 22 Jan 2022 09:40:17 -0800 [thread overview]
Message-ID: <e92c221f-9ebe-0db2-0536-78e230c415b8@FreeBSD.org> (raw)
In-Reply-To: <20220122013801.666659-1-tom@tromey.com>
On 1/21/22 5:37 PM, Tom Tromey wrote:
> This series tries to untangle and simplify the GDB output functions.
>
> By the end of this series, whether a particular bit of output goes
> through the filter will largely depend on the particular stream that
> is being written to. This means that new code can be much simpler --
> there's no need to decide between using a _filtered or _unfiltered
> form of a function, and in fact, that distinction will no longer
> exist. (Some unfiltered output is still needed, but only to
> gdb_stdout, and only via a single API. New such cases should be
> rare.)
>
> A few cleanups are still possible after this series goes in. For
> example, ui-file.c could be broken up a bit, and the pager
> implementation should be moved out of utils.c. I also have a couple
> of pager bug fixes that I will apply afterward.
>
> This series is based on a couple of still-pending output series that
> I've already sent. I'll probably check those in reasonably soon.
>
> Regression tested on x86-64 Fedora 34.
I only skimmed the patches, but I like the idea in general. I wasn't
previously really aware of when to use filtered vs unfiltered and
just depended on matching existing code in other targets, etc. To
that end I appreciate making the "default" API clearer. I do think
having to use 'gdb_*' for functions that would alias stdio is slightly
unfortunate, but I understand the reason and I don't have a
better naming suggestion (gdb_* is consistent with other things like
our local versions of STL types, etc. so is the best choice I think)
--
John Baldwin
next prev parent reply other threads:[~2022-01-22 17:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 1:37 Tom Tromey
2022-01-22 1:37 ` [PATCH 01/19] Use unfiltered output in annotate.c Tom Tromey
2022-01-22 1:37 ` [PATCH 02/19] Remove some uses of printf_unfiltered Tom Tromey
2022-01-22 1:37 ` [PATCH 03/19] Only have one API for unfiltered output Tom Tromey
2022-01-22 1:37 ` [PATCH 04/19] Add puts_unfiltered method to ui_file Tom Tromey
2022-01-22 1:37 ` [PATCH 05/19] Add style-escape methods " Tom Tromey
2022-01-22 1:37 ` [PATCH 06/19] Remove vfprintf_styled_no_gdbfmt Tom Tromey
2022-01-22 1:37 ` [PATCH 07/19] Change the pager to a ui_file Tom Tromey
2022-01-22 1:37 ` [PATCH 08/19] Remove fputs_styled_unfiltered Tom Tromey
2022-01-22 1:37 ` [PATCH 09/19] Unify vprintf functions Tom Tromey
2022-01-22 1:37 ` [PATCH 10/19] Unify gdb puts functions Tom Tromey
2022-01-22 1:37 ` [PATCH 11/19] Unify gdb putc functions Tom Tromey
2022-01-22 1:37 ` [PATCH 13/19] Rename print_spaces_filtered Tom Tromey
2022-01-22 1:37 ` [PATCH 14/19] Rename puts_filtered_tabular Tom Tromey
2022-01-22 1:37 ` [PATCH 15/19] Rename fprintf_symbol_filtered Tom Tromey
2022-01-22 1:37 ` [PATCH 16/19] Remove ui_out_flag::unfiltered_output Tom Tromey
2022-01-22 1:37 ` [PATCH 17/19] Remove vfprintf_styled Tom Tromey
2022-01-22 1:38 ` [PATCH 18/19] Minor comment updates in utils.h Tom Tromey
2022-03-24 18:05 ` Pedro Alves
2022-03-28 20:29 ` Tom Tromey
2022-01-22 1:38 ` [PATCH 19/19] Remove unnecessary calls to wrap_here and gdb_flush Tom Tromey
2022-01-22 17:40 ` John Baldwin [this message]
2022-03-24 16:25 ` [PATCH 00/19] Simplify GDB output functions Tom Tromey
2022-03-24 18:08 ` Pedro Alves
2022-03-29 19:38 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e92c221f-9ebe-0db2-0536-78e230c415b8@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).