From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Hui Li <lihui@loongson.cn>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb/testsuite: Add support for LoongArch in gdb.base/float.exp
Date: Thu, 16 Mar 2023 23:04:39 +0800 [thread overview]
Message-ID: <e95c9d3a-4779-a579-a076-3c3acb2688a3@loongson.cn> (raw)
In-Reply-To: <20230309125437.32662-1-lihui@loongson.cn>
On 3/9/23 20:54, Hui Li wrote:
> The test results on LoongArch as follows:
>
> Without this patch:
>
> ```
> $ make check-gdb TESTS="gdb.base/float.exp"
> === gdb Summary ===
>
> # of expected passes 2
> # of unexpected failures 1
>
> ```
> With this patch:
>
> ```
> $ make check-gdb TESTS="gdb.base/float.exp"
> === gdb Summary ===
>
> # of expected passes 3
>
> ```
>
> Signed-off-by: Hui Li <lihui@loongson.cn>
> ---
> gdb/testsuite/gdb.base/float.exp | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
> index 7f230cb6f61..5e9be538b73 100644
> --- a/gdb/testsuite/gdb.base/float.exp
> +++ b/gdb/testsuite/gdb.base/float.exp
> @@ -126,6 +126,8 @@ if {[is_aarch64_target]} {
> pass "info float (without FPU)"
> }
> }
> +} elseif {[istarget "loongarch*-*-*"]} {
> + gdb_test "info float" "f.*fcc0.*fcsr.*" "info float"
> } else {
> gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)"
> }
Looks good to me, tested on LoongArch, pushed.
Thanks,
Tiezhu
prev parent reply other threads:[~2023-03-16 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 12:54 Hui Li
2023-03-11 3:00 ` Simon Marchi
2023-03-16 15:04 ` Tiezhu Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e95c9d3a-4779-a579-a076-3c3acb2688a3@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=gdb-patches@sourceware.org \
--cc=lihui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).