From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2069.outbound.protection.outlook.com [40.107.93.69]) by sourceware.org (Postfix) with ESMTPS id BAB1B3858C5E for ; Wed, 18 Oct 2023 08:33:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BAB1B3858C5E Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BAB1B3858C5E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.93.69 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697617989; cv=pass; b=nTytaLT8uwDlDOiGXvtLCo/3nr7W4j81DFkTVeVfbs2auikugUyCCAk+8NHZXHg4iDR3d+Ro7vxt9xrxSDuLkttqBY1iKJx80eePFCBCTYlhOpI4JAy9Kt2mf05QfLqVbI+HOKl8lmnXon8EyS7X2Ln4A0n+haA0kzmpNJ9Hf94= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697617989; c=relaxed/simple; bh=VfofvzqDLINxj77jwFXwcqz+siuU0kxU4FY0H4+l2PE=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=R1LfnMETriXjlZsHmaxf2Boy1w1+5smQGFu2WAkdS/6+1iJ+ZG+ceRldBMrK09oZccIl9AR5/0LixUPl14T6ZB12SM2uX+Dj+DGXF25Wkgswm+2MomsfyA5+1oe8RtKHORoNMCeuA3OXGOkkLxwcEJBWNUgQXxBnQFo0NTdzXsg= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WkYj6QOwWoAUX2vJYHGiF1LY0+FLgZoEmuvuwrtzOYEGL0y5JR6ra5iv/OeV51kiFROc5yMlQ57+eYXu7mRNHHSmTspSyzMWiixPLE+uIlLzfM5hidNNz5UwOzenZRPKjFKCKeigXITTPmfek2ippTF5UkyU8aKkobV01To2IXPKW+VOzfeL1QXJMGEnYX6XZLXTkrcOmlmExPziTdBUukdYnqvbTVUyT+pcNkvRnUBrEfFk4w3QOCbCIAuroKHW8tI29CzCDsHpzDObgrFbioyugGnbwammaupITq8r35ogon9X/0qcf7o56M7feZnu8TB9D8CKx/0EfJ8dfbTjlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ed31HLhRSIIT72EIqY6OWxKZvN5zd3iQcBNNZzYd5FU=; b=RCJFXk93TfmyjAOaOnk9pSfUCIATrsLlQcZbuVQVPhjLiKyYDP+DaHPc2GQmamZ14r07GoRZ/KhwUMGV5u6KHv+uWP7utX8cV3juOdNWR3diL9y0sQ3CU81maDJ0FIVAZLu7fGOP+h3jd1GQo7nFb1GuOWi1EVpe3F4nZXrSgL0cO+4gxY5hPn3ClVt7Dlk2Qqy8Mj0+JSjfiPvaX1YKZtDhFVKIlu9woBm7j7CIVwF47+DENDC7ftGYS7a98PoxYb1XRDO402SaBXZ1H1crjUi8wXvFKJ1a7eRftesMnoxk1XB7M748WK2qxzWn5+ROpRHfULO8cQfphvAzzGzdyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ed31HLhRSIIT72EIqY6OWxKZvN5zd3iQcBNNZzYd5FU=; b=HK4L7Pj8wkE9lgIU+cBeP0HktrwsQsN59xc71cPkWpB75M6YKBpUIhsSmGrDxtWP+F/u8S/5L1sWB3eVBvjPK6MIC74w9x/ZvQ341V6Tmnci/DD+c7ZVJYuCJlqF0uHQ0w7mRMCEMKnN3Wl0CCOMoQgDsyHkG+KCsRZDIvQpTko= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by CH3PR12MB9251.namprd12.prod.outlook.com (2603:10b6:610:1bd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Wed, 18 Oct 2023 08:33:03 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f%7]) with mapi id 15.20.6863.047; Wed, 18 Oct 2023 08:33:03 +0000 Message-ID: Date: Wed, 18 Oct 2023 09:32:58 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite/gdb.rocm: Fix incorrect use of continue N in multi-inferior-gpu.exp Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20231017111629.307261-1-lancelot.six@amd.com> <6e3b93f0-f9b1-4e92-aa8b-65ee0d56ebc1@simark.ca> <60a7f9cd-3c64-4100-9334-5879db42a62a@amd.com> <0a223be2-f3c8-4cf1-90ea-1084232622ea@simark.ca> From: Lancelot SIX In-Reply-To: <0a223be2-f3c8-4cf1-90ea-1084232622ea@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR4P281CA0185.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ca::18) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|CH3PR12MB9251:EE_ X-MS-Office365-Filtering-Correlation-Id: b3a671b1-f4df-490c-e950-08dbcfb4d863 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h2os3DGoDQfDseO3FbZnDh7DKTzWQqY3ek7mnE+w2VQEUWL1VVsYRWb1bn+05bQN6pMqx5TKQInxQYfkDXSAUJnQ+EoXKsxn0itP6/Y9uKxzPg08WB09IAFBKTSjwMzRv5gBaCbgLimwntTto0Q+arRT2Mb9bpCXgrcRQc4BSgLSjWQ969+Ez+sVp5L8TSdDLqVfO40sr7aqF70zD3y3LxrzAA/dQjpqSuN4Zl3c3anwTWK7ljweu1GFCN6aS08kiwARUDd9PFDdmiqMiLFJtCWSZ/WT4TYvwB8XSCZuekbv0AeEJHjVo+Zjit6juZLxedQGxp7Zjmi6vV0SZcmhXJB45kp7/K+OmvmcgxWxpA/48EO7DBD2TpMw9FWe5UdjcAOuC3k3JMYKNRUWSsccCbpIbVhOSzEr/zo+sOIz6nwISPuSe/Ks8f6DrSWDyhVwfQ2Z/0CDD+5+LXT8R0yiCWo0xyzveaEoaehJUhdbArRqCkQuw9o+gRgIMUP9wYNar6fV/LSzeUFk/IvZ1tB/W5DKOPN0m7S21az+z8CuDvoz6vr5Zp25XfTpOhBefU4wo391WJ8NM3kZDHnEz4UAPUD8L4C3dWnkhTJBHTRWKkL/xOmFq2bUQmzKIsePOnmIEg46pUmLZyciOOuOrCiGIA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB9079.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(136003)(396003)(39860400002)(366004)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(53546011)(6506007)(5660300002)(2906002)(36756003)(83380400001)(26005)(6666004)(2616005)(38100700002)(86362001)(31696002)(6512007)(478600001)(316002)(6486002)(66476007)(66556008)(84970400001)(41300700001)(66946007)(8676002)(8936002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1ZTWHZHWjZ0MXNRSjNXOGRGa2pYa0YxU0t0UU4wWnFlbVcxN2xCWnVqQ0Zp?= =?utf-8?B?djVGb3RjZVJvZ25rN1JFZ2k2RTN0NVpRVnFRS1FDNWFqRGxoMEhrL1ZCSGVE?= =?utf-8?B?N2Fhb1dwSmtYWGhvQ3BKMkU3YlI5RDh4dWZMaFJMUGdUVjd6WWxxWDlPcEFx?= =?utf-8?B?S1QzeExDMW1pRCtqTmxwSGc5MWV6d3Iwd2tsNGJwajBrc0RIK3VRQjQxRVYx?= =?utf-8?B?S25PaFJicmRseGtPRk5qbzE2UXIzRVBNUndReG5wVVR4S1MxVW1MdC9OdC9q?= =?utf-8?B?UnpncXh2U3JRYkcyNUNoaEJwdjA4K2pKSlRvT1BUZGtVVTllSWtZeEhiUnBY?= =?utf-8?B?d2xKM1NHVk5GVisxa244SDRET2VFQy82eDN0NE1KeUZIZ1NidGxBWUNCRTAy?= =?utf-8?B?NFNpalFaZTMxZVA2MDVMSFF4aFNLUTJsSHNIZVdOYXpTVjBlWGgxRW9LZXd3?= =?utf-8?B?SGhIZjFOQlRVYnZRRWVaWG9NangrTnovWGJpc3Z5a3hjZ2RUczcyWEJBUThW?= =?utf-8?B?aVJZVGpFQU83c2o3bWxVKzM0N3VSRDZrNVlSOUo5Y2J1djNqcW9qdW9xMU1O?= =?utf-8?B?VXp5YnhaRDhnYVNUU0l5YmFDaWxNaEg3MTArUHdQZDZOTWtRYVpTb1JSR2lq?= =?utf-8?B?eWN6NCtmbUdnMGFTNVRWUVZRVnlURURFenN4Uy85T2czUXE3L1dNZzZMVFht?= =?utf-8?B?WkgvaUdlMWN3dTVxSEI5SnFKdmxGK2xPUjJaaWNEZjRkNy9HRW9xYmFzaXU0?= =?utf-8?B?Ty9UaGt2K0lWMUJHVllHSEt4T25TWndrUXY4dHlVa3Vlb3p1WUZPRTZyVmpH?= =?utf-8?B?Z0RiY2lKRjBMWEFFZGxHS3F1cnFlSmJUZ0czYTE2UDc5MmJUQTVFbEwvUVdL?= =?utf-8?B?ZmsxYXpLNnlIUWlUTnUwTm1pZmd4ZmNmRys2MVpkeDlNY21tS0tZRXUwRDhF?= =?utf-8?B?K2JMUWk4cE1SMkR0aDZMYmQwQXZZaW9vbUF0RGh6S2VXWndKcG11eXRCOUVF?= =?utf-8?B?RmN6NVJyd2dOd2V1Y3lzOWRjWVpBa3NoTTQ0K2lLMzBRUmZNMDZNa0xFTWhy?= =?utf-8?B?WlpzRFROSUphb1FoZDFrWkI4VmdmQVplT0RDRGtvN09KYTh5cVRhZ2pZdERy?= =?utf-8?B?OU5TN3VGSFJTSEFZS28yNEZzMGJSTkZOQ2VyMUlpV2hBS25mMlBIeVhQR1VE?= =?utf-8?B?dndDQXBONFhvTHNaSm52bElBTDF2NEFxVnpWdmljR21Xa0VMZ0l0bk9MM0dD?= =?utf-8?B?ek0wT1RtamFDTlk4M3ZpV0RkU1ptMHI4OUQydGpab3BsM0tTdzZQOExDdVdB?= =?utf-8?B?TnpaSlhRN0xLNlVUM3lNQ0xhcE9Vb2VaMXAxYTZra3FFS1dHR3Z3U3hqbElR?= =?utf-8?B?dXR6bnNuYWQzSjdidEtqUTdXMUEwaE42V0dYdVpIQ1Nkd3ZjVDJINkMxQ1l0?= =?utf-8?B?VmRYZ2NZeVJhSjdneUl6aDFyTFA1QTZZWWVDRUViQWlmVjdERCtzOUxUWHdP?= =?utf-8?B?RjZJdUQ2bmJQR0l3RkE5RzVOOVQ5ODVPQXRpbkZzR0R4dWNzZXcrdWJFZzFG?= =?utf-8?B?ZGloRlFzNUF1UTk4RmdZK09vK1NGU3Jab1cvRkJScXdTK0hyQzJzZGs1UHJR?= =?utf-8?B?RjlLUnl2MW1vc0ZWMUJDRXRodnc1RWdkamhEQU1xaThMT1pSRFhVdXpyY2J6?= =?utf-8?B?cGR2b1E0SFVEUU9uWVozVmxBMFJnM3JnL0p0QWFVcDU4K0xCYVdrMWwrV05Y?= =?utf-8?B?aVhBWmxZNUdHWjZWZW50TGR5a2M4Y3FpT09HbjJWNkpBRFlLUlRvak1vVGpq?= =?utf-8?B?bm85VlVDS2JUaEhKYnE3L0Yxd3lGUTdnTkJUVVVnTUFPS1JZY1VVQjh0emtz?= =?utf-8?B?M1NiSlhoaHFpNVc5WTVCckN2emUxeFNpd0xHREJ1UzVIbU5VNTNVVTZ6ZHo3?= =?utf-8?B?cStiMjRvaFh0aVhnSWJveWVkMi9kVHZUV1JDMkZGUGdxMUluQTRjcnJYb2xS?= =?utf-8?B?WTBJRWl4T2toWGpJM3c1Y1BFRll5aElpTWg3ZzJ0MHRKaHFJTmI1bjFyTkN1?= =?utf-8?B?NmRnN0UyVll2TFc4WVp3U3ppOTNYbEd2RjNDTTNwY094aGVQNVF6K3FSbXFV?= =?utf-8?Q?AmkpwE4M1eCRTAldoSE6I3+tI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3a671b1-f4df-490c-e950-08dbcfb4d863 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 08:33:03.6520 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aN4edYEtoMcJsfNLQoRhuGzFZ61HIujkmde4Y9Qq7PV/16mKh3/uJjdi5Z/u8EuyTuPkuSrQWNkouVtKbs2gTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9251 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17/10/2023 15:48, Simon Marchi wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > On 10/17/23 10:41, Lancelot SIX wrote: >> >>> On 10/17/23 07:16, Lancelot Six wrote: >>>> The gdb.rocm/multi-inferior-gpu.exp testcase uses a "continue $thread" >>>> command, but this is incorrect. If "continue" is given an argument, it >>>> sets the ignore count of the breakpoint the thread stopped at. >>>> >>>> For this testcase it does not really matter since the breakpoint is not >>>> meant to be hit anymore, so whatever the ignore count is won't influence >>>> the outcome of the test. It is worth fixing nevertheless. >>>> >>>> While at changing it, switch to using "continue&" to consume the GDB >>>> prompt right away. This makes the following pattern matching more >>>> reliable. >>> >>> I don't understand the "more reliable" part, can you explain? >>> >>> Simon >> >> There will be a "(gdb) " prompt appearing at some point after a "continue", but in non-stop we don't really control when it appears (if I understand correctly). It seems that other non-stop tests use the "&" variant and consume the prompt immediately. >> >> With this, before the next command is issued, we know that 1) we got a prompt and 2) we have seen the process we just released finish. >> >> Overall, I am mostly trying to follow patterns I caught in other non-stop tests. > > Ah, I missed that we were in non-stop. > > If we run a single thread at a time, I think it will be reliable to use > the sync variant of continue. Using the async variant is useful when > you resume multiple threads and expect multiple events (like breakpoint > hits) which can happen in any order. At least that's my understanding. > > Simon OK, if you find it is overdoing it, I'll revert this part of the patch and submit a V2 shortly. Thanks, Lancelot.