From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2043.outbound.protection.outlook.com [40.107.21.43]) by sourceware.org (Postfix) with ESMTPS id C112F3858C36 for ; Mon, 24 Apr 2023 12:53:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C112F3858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RZbKdd0TB8QZdKnlXm5NJvOgTSvWVcL3W36iJHP+By4=; b=u6OKWivRp0Uj4GuhjSJrthEaUyc8ETic+uVUJNpd2PteVtiMCOBlSnjphoD2Ds+RFFB7hOMOIjlYvRH5fFaWST1IiFlMDxWOA1GrdDVJkQR39VCAEGt6RUwV171vgQhQ6goN0+xshXXOaEjlvQo8Of6tkY9GWTlqmQHfzHEGems= Received: from DB6PR0501CA0016.eurprd05.prod.outlook.com (2603:10a6:4:8f::26) by PAXPR08MB6381.eurprd08.prod.outlook.com (2603:10a6:102:151::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 24 Apr 2023 12:53:52 +0000 Received: from DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::a0) by DB6PR0501CA0016.outlook.office365.com (2603:10a6:4:8f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33 via Frontend Transport; Mon, 24 Apr 2023 12:53:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT005.mail.protection.outlook.com (100.127.142.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.19 via Frontend Transport; Mon, 24 Apr 2023 12:53:52 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Mon, 24 Apr 2023 12:53:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1b4cff795869fdee X-CR-MTA-TID: 64aa7808 Received: from d2c2a6a0ba18.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1241AA97-FC15-45A3-AF1E-77A97C329206.1; Mon, 24 Apr 2023 12:53:45 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d2c2a6a0ba18.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 24 Apr 2023 12:53:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kf+4Ps69wHDQzx6Did27Uy7dWazfW8hfaavAi23ECb/mPQggKXvnWh5+ICUjPE2LiJnfRIkg8ng4oezkwqEzIDzWn5G04lmYJy4j6pbzWi6nP9ozspX+wpEuONdV86THjGd5K2UOCrBBgVW0wok/LMGpt82467Y1I2V39J0frqW8wUnOsbv/KTSJJaLXgov4Wt8EKEbAXLED82pKOPzGcXVR4uokRyYskOA2xeXR3Nx54rN2FKYAqwPepPjTdbecCnvmpUYHcDORF6umcjqgtV/Ft/DGCM+ZA/j3Mfq/OwHvtxp3cLPi33wOlkjGyw1RR8MWO5VMSBq67sBwZFU4SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RZbKdd0TB8QZdKnlXm5NJvOgTSvWVcL3W36iJHP+By4=; b=GxvZtadzrz4HFF6fLhf01wxid0BQHwat5xz1OnLWb7U26wCbVMGzldiKzRKnUxMhVmGEXeWj5aQKIy61gLFdIAOtArekLE9BFkGWwgyiIOkQkHRxWOTwVNY9GDfAZ4vvd014EQm9+vA+p0bCnzsgCWQaMhxMFyomiA4wN2Acz0kjN6QN/KWDBVDGec4966QRXd9H+E3P0issDkktswfBDbt7wtRv4Rz+CjHFIG8BhEwLzPFrbBNI430LkfuAkFs7BuDeWBCzZl4xYRvLTCpczbXPkxbQhx3IvgZatjgjWtX51+8fiELFQK63PNeHkvo74beArHz9W79LYASatOAJCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RZbKdd0TB8QZdKnlXm5NJvOgTSvWVcL3W36iJHP+By4=; b=u6OKWivRp0Uj4GuhjSJrthEaUyc8ETic+uVUJNpd2PteVtiMCOBlSnjphoD2Ds+RFFB7hOMOIjlYvRH5fFaWST1IiFlMDxWOA1GrdDVJkQR39VCAEGt6RUwV171vgQhQ6goN0+xshXXOaEjlvQo8Of6tkY9GWTlqmQHfzHEGems= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DU0PR08MB7566.eurprd08.prod.outlook.com (2603:10a6:10:31e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 24 Apr 2023 12:53:42 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::61f2:6a3c:f256:8616]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::61f2:6a3c:f256:8616%3]) with mapi id 15.20.6319.032; Mon, 24 Apr 2023 12:53:42 +0000 Message-ID: Date: Mon, 24 Apr 2023 13:53:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3] gdb: Fix false match issue in skip_prologue_using_linetable Content-Language: en-US To: Tom de Vries , Kevin Buettner , Tom de Vries via Gdb-patches Cc: WANG Rui References: <20230418120939.29102-1-tdevries@suse.de> <1a4148e1-1376-3bc6-e398-4c611922c58f@suse.de> <20230421110346.7ca9b163@f37-zws-nv> <276f25d7-ab32-268f-0875-70cab6180e8d@suse.de> From: Luis Machado In-Reply-To: <276f25d7-ab32-268f-0875-70cab6180e8d@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0090.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bc::11) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DU0PR08MB7566:EE_|DBAEUR03FT005:EE_|PAXPR08MB6381:EE_ X-MS-Office365-Filtering-Correlation-Id: 23800294-9894-418a-09b6-08db44c2f4ce x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sAut/K3Cv8PJojIzf6SVdFaFEAamCnqhUTNXhNYPr7UiFbEltut5GXAE3ssGWLqLv3e1McmgTWyatamVEcBDK93A0VzLvaMEf90ZPmSi11j7/iF4nRXsKhqpUTpOk3n2/geCKb8c+TdQxJxSbSVTtSiBXJ1x4vcHCjn0gNrZtc/z8o4pSmz1vc/XQ4Ilrai9mR5w5bgt7qVc71JUkjVakDIYdTjJFflgMk6mW/zQ7mqcrovozopuFNkpTZIvL2uisZQrQz0iTacvegaQ1UpBK/34dKMPm3qIdHRCu1vxwgerRHGt1dAnDbr3qNvxqkYt3vaue0HP8x8H3LKDUSav+ySPD3NgzqlehwLBYE/HQELfXNW21X6futQbwE03yDJ+WQJTyrXT0atlbU4r1dEajj7IqM5NkcAzHsgEH7GYrbs6iWXSzL7P8vUex172iMN1aRWtg9B99nX+jjkuhzRZgyMjRnLOaqoCvMjxowh+RoC+fngfTmW8u66WVSY30gslt7H8bs2Jx67l1IPwDpMVscP9Qt0uQEm+RViXUYq+wvDKsucY9jZzXCYmgiQUnY7nmmzOhNn0iT2B5CxK7iIJXDn5DHhcSYQExw1k7NZf5s2iSFncYbYF8ys+S885Fz4fgsaP4lEfCMW7DLtuDe+K1g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(376002)(366004)(346002)(451199021)(966005)(53546011)(6506007)(26005)(6512007)(2616005)(36756003)(186003)(38100700002)(66946007)(31696002)(478600001)(86362001)(66556008)(66476007)(31686004)(8936002)(8676002)(44832011)(110136005)(5660300002)(6486002)(66899021)(41300700001)(2906002)(4326008)(6666004)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7566 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 25e6c784-564f-4727-8941-08db44c2ed9f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6t5F5ZJO1PQn9dzxMDoNSH2cifGbZdlGWnJjN9cxOM9+wuMOLFORqBMXEctAlcTcwbZzlrVtsbNK/A9rqwCyhkCRGLTdjwRNVpJ75TJ+w1N6+e5SlOZ8mvyk6WJflkrD3C/7GjGrfSVlBQcM/E2CaNBy5mQdHCnYG+tbLdHimc3ILPpVJm/hUKq+Rw7vN9Czzd3YyOCZSZi+t1X7GrLxPgbdcPxFfEEWD2qEtwrYHDskPTq79shi0BLMqjbOjPY8tGGXv6e/aVE3bskZfpswMRuO3VWaUsluahw4Fx9et02Q/wfwl0V/RGR+nAuVpfJz+SRAoet/3T/uvm+nLey2Yaslb7iNQe9ZyW3Tp4gSmbxUi3ycrQGx4zmiko9cRqDkFmnNGTTR+UfybMf9Sp1VSRE6zwq/MKO7/al8o8Z/XTQKG5OLb2u+7RQvo7kU8ErUq0tFDT+tLfNxOaaXop7sQh6rd7FNIt41Ww9/JLbrLnY4EC2hbxC94gpjWD/eizhTw7YWDB0nMavYa7Xd/g7uk8aUKMlz605HdLUq66bKYJYKzKzmj1hvgjhxMSDhJNvcq4qT7fAAz4WXksOXEdEG0dqRRShs5GyMKjDZlzxJH859IWyvaxiY0nT4/WXWj2c3Nb6lGYgVwmb9yCeE+141IEQzVWpW2Zp0YwpFqzGlDVn/oX7Pg/W5flgDJOBZVpklGX3dHlTQIu9b+HeIEIdo2zVASnw3xG+sKtyabd3CPHI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199021)(36840700001)(46966006)(40470700004)(478600001)(40460700003)(31696002)(66899021)(110136005)(86362001)(966005)(36756003)(186003)(53546011)(6486002)(26005)(82310400005)(6506007)(6512007)(40480700001)(6666004)(4326008)(316002)(82740400003)(44832011)(70206006)(70586007)(36860700001)(2906002)(336012)(356005)(41300700001)(81166007)(8676002)(8936002)(31686004)(5660300002)(47076005)(2616005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 12:53:52.4388 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 23800294-9894-418a-09b6-08db44c2f4ce X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6381 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/22/23 09:01, Tom de Vries via Gdb-patches wrote: > On 4/21/23 20:03, Kevin Buettner wrote: >> Hi Tom, >> >> On Tue, 18 Apr 2023 14:15:06 +0200 >> Tom de Vries via Gdb-patches wrote: >> >>> On 4/18/23 14:09, Tom de Vries via Gdb-patches wrote: >>>> Co-Authored-By: WANG Rui (fix, tiny change [1]) >>>> Co-Authored-By: Tom de Vries (test-case) >>>> >>>> [1] https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html >>> >>> I'm not used to deal with these matters, so I'd appreciate some >>> review/approval on this.  Is my copyright status assessment correct, and >>> did I write it up correctly? >> >> I refreshed my memory via the link you provided above.  Based on what >> is written there, I conclude that Wang Rui's change is not legally >> signficant for copyright purposes. >> >> Also, I've looked over the Rui's patch as well as your test case, and >> it looks good to me.  So... >> >> Approved-by: Kevin Buettner >> > > Hi Kevin, > > Thanks for review. > > Committed and also backported to gdb-13-branch, because it was a 12 -> 13 regression. > > Thanks, > - Tom > For some reason aarch64 is grumpy with this test, and it FAIL's the last comparison. Maybe aarch64 is broken in this regard?