From: Simon Marchi <simark@simark.ca>
To: Kamil Rytarowski <n54@gmx.com>, gdb-patches@sourceware.org
Cc: tom@tromey.com, jhb@FreeBSD.org
Subject: Re: [PATCH v3] Add SVR4 psABI specific parser for AUXV entries
Date: Wed, 8 Apr 2020 21:00:01 -0400 [thread overview]
Message-ID: <ea1ca3b9-04b2-ffae-2733-f85105ff0f94@simark.ca> (raw)
In-Reply-To: <20200409005630.25839-1-n54@gmx.com>
On 2020-04-08 8:56 p.m., Kamil Rytarowski wrote:
> NetBSD and OpenBSD always use an int to store the type as
> defined in the SVR4 psABI specifications rather than long
> as assumed by the default parser.
>
> Define svr4_auxv_parse() that shares code with default_auxv_parse().
>
> Remove obsd_auxv_parse() and switch OpenBSD to svr4_auxv_parse().
> Remove not fully accurate comment from obsd-tdep.c.
>
> Use svr4_auxv_parse() on NetBSD.
>
> gdb/ChangeLog:
>
> * auxv.h (svr4_auxv_parse): New.
> * auxv.c (default_auxv_parse): Split into default_auxv_parse
> and generic_auxv_parse.
> (svr4_auxv_parse): Add.
> * obsd-tdep.c: Include "auxv.h".
> (obsd_auxv_parse): Remove.
> (obsd_init_abi): Remove comment.
> (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
> from `obsd_auxv_parse' to `svr4_auxv_parse'.
> * nbsd-tdep.c: Include "auxv.h".
> (nbsd_init_abi): Call set_gdbarch_auxv_parse.
>
Thanks, this is ok.
Simon
prev parent reply other threads:[~2020-04-09 1:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 2:14 [PATCH] " Kamil Rytarowski
2020-04-08 4:11 ` Simon Marchi
2020-04-08 14:59 ` Kamil Rytarowski
2020-04-08 14:58 ` [PATCH v2] " Kamil Rytarowski
2020-04-09 0:04 ` Simon Marchi
2020-04-09 0:57 ` Kamil Rytarowski
2020-04-09 0:56 ` [PATCH v3] " Kamil Rytarowski
2020-04-09 1:00 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea1ca3b9-04b2-ffae-2733-f85105ff0f94@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=n54@gmx.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).