From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 43D2C3858D20 for ; Tue, 30 May 2023 13:36:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43D2C3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 34UDaW58032454 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 May 2023 09:36:37 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 34UDaW58032454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1685453797; bh=bV9GNcKuDbwcaUhQ6WCRKX9VYeZrq0d3gx4SDdQw6YY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=khEImpYi9PfraAjHNMWpn4dx8GIPjd6oT9Eb+o+0BEejM3Fl6UJUmY24+frYfdUin dIsQFKse3pOCdbexbxCzX/sUKAyQ8tZ8Wpbqg5v3XL8ppm6iHd4KUvgeIT+4LjTYVk ldYx0dhNXJT4OdknqURVKliNTB9k1scRxhPUPQ6I= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 854A81E0D4; Tue, 30 May 2023 09:36:32 -0400 (EDT) Message-ID: Date: Tue, 30 May 2023 09:36:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] [gdb] Mention --with/without-system-readline for --configuration Content-Language: fr To: Tom de Vries , gdb-patches@sourceware.org References: <20230530093344.12517-1-tdevries@suse.de> From: Simon Marchi In-Reply-To: <20230530093344.12517-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 30 May 2023 13:36:32 +0000 X-Spam-Status: No, score=-3030.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/30/23 05:33, Tom de Vries wrote: > Simon reported that the new test-case gdb.tui/pr30056.exp fails with system > readline. > > This is because the test-case requires a fix in readline that's present in our > in-repo copy of readline, but most likely not in any system readline yet. > > Fix this by: > - mentioning --with-system-readline or --without-system-readline in the > configuration string. > - adding a new proc with_system_readline that makes this information available > in the testsuite. > - using this in test-case gdb.tui/pr30056.exp to declare it unsupported for > --with-system-readline. > > Tested on x86_64-linux. > > Reported-By: Simon Marchi I confirm this makes the test skipped on my machine. Once the fix is merged and in a readline release, could we make the skip conditional on the readline version? We could have a maintenance command or something like that that outputs RL_READLINE_VERSION, and skip only for old readline versions. Simon