From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Pass inferior to terminal_inferior
Date: Tue, 23 Oct 2018 09:14:00 -0000 [thread overview]
Message-ID: <ea51df65461589496ad2a504a56eaaf5@polymtl.ca> (raw)
In-Reply-To: <ec9cf6a6-1ffe-ff19-2c05-ecd7fa42955c@redhat.com>
On 2018-10-22 16:54, Pedro Alves wrote:
> On 10/16/2018 04:38 AM, Simon Marchi wrote:
>
>> diff --git a/gdb/target.h b/gdb/target.h
>> index c37405205a0a..310c942bbe5b 100644
>> --- a/gdb/target.h
>> +++ b/gdb/target.h
>> @@ -581,7 +581,14 @@ struct target_ops
>> TARGET_DEFAULT_RETURN (false);
>> virtual void terminal_init ()
>> TARGET_DEFAULT_IGNORE ();
>> - virtual void terminal_inferior ()
>> +
>> + /* If INF shares a terminal with GDB, restore the saved terminal
>> settings
>> + associated to INF (see terminal_save_inferior) to the current
>> + terminal. In a scenario where multiple inferiors share GDB's
>> terminal,
>> + don't apply the settings of another inferior's settings are
>> currently
>
> s/of/if/.
Fixed.
>> + applied (in other words, the first inferior's settings win and
>> should not
>> + be overwritten). */
>
>> + virtual void terminal_inferior (inferior *inf)
>> TARGET_DEFAULT_IGNORE ();
>>
>> /* If INF shares a terminal with GDB, save the current terminal
>> settings
>>
>
> OK.
Thanks.
Simon
next prev parent reply other threads:[~2018-10-23 9:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 3:38 [PATCH 1/3] Pass inferior to terminal_save_inferior Simon Marchi
2018-10-16 3:38 ` [PATCH 3/3] Avoid GDB SIGTTOU on catch exec + set follow-exec-mode new (PR 23368) Simon Marchi
2018-10-17 17:05 ` Pedro Alves
2018-10-20 15:14 ` Simon Marchi
2018-10-20 15:38 ` Simon Marchi
2018-10-22 20:56 ` Pedro Alves
2018-10-23 9:49 ` Simon Marchi
2018-10-23 10:55 ` Pedro Alves
2018-10-24 9:41 ` Andreas Schwab
2018-10-24 14:08 ` Simon Marchi
2018-10-16 3:38 ` [PATCH 2/3] Pass inferior to terminal_inferior Simon Marchi
2018-10-22 20:54 ` Pedro Alves
2018-10-23 9:14 ` Simon Marchi [this message]
2018-10-22 20:54 ` [PATCH 1/3] Pass inferior to terminal_save_inferior Pedro Alves
2018-10-23 9:01 ` Simon Marchi
2018-10-23 11:11 ` Pedro Alves
2018-10-23 20:56 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea51df65461589496ad2a504a56eaaf5@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).