From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B967F3858C50 for ; Fri, 10 Feb 2023 02:08:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B967F3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4198A1E110; Thu, 9 Feb 2023 21:08:03 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1675994883; bh=nDqOkMSqe8B3JdvMVwohjJ0+5SYjvB3Qx/9pH59ZyYU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=pmoqC4dsXAeHP3wbW473upA9QVEwei46fPFRimIBrCdQrcffGC5E0WhASnv2/LNpy 0HsP/qurTZTDkhfwqiKi+H3S96NpGQpTFHpJtDShLUObs36T6C2bUuv9HFORi7ItvP foLE1jCDSgqLlncsDYaGy1C3YLXi1w5YzrH/mbpc= Message-ID: Date: Thu, 9 Feb 2023 21:08:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 06/47] Turn value_arch into method Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230209-submit-value-fixups-2023-v1-0-55dc2794dbb9@tromey.com> <20230209-submit-value-fixups-2023-v1-6-55dc2794dbb9@tromey.com> From: Simon Marchi In-Reply-To: <20230209-submit-value-fixups-2023-v1-6-55dc2794dbb9@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > diff --git a/gdb/value.h b/gdb/value.h > index cb92b872bc6..31ec0b5c202 100644 > --- a/gdb/value.h > +++ b/gdb/value.h > @@ -169,6 +169,9 @@ struct value > void deprecated_set_type (struct type *type) > { m_type = type; } > > + /* Return the gdbarch associated with the value. */ > + struct gdbarch *get_arch () const; We typically don't use the "get_" prefix for getters. Is there a reason to use it here? Simon