From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id B5D613858D37 for ; Wed, 2 Mar 2022 00:31:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B5D613858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 8E1ED727E8; Wed, 2 Mar 2022 00:31:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K7Zn73QN4z4WPt; Wed, 2 Mar 2022 00:31:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646181115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ehe8mltn1YJH64nOv4E1LmpWZ8PhjD2CAc5VI/eyvv4=; b=EWWY4gvMLS/LQQF8cr4ltn15JTZMUk8UIXvVk/cZNgXCUVtvDV45Y/yK4ffL6x6+JagpXX cV035UGepk+hChJOnnGYvM3C4rsOL1rTMwsO2mB2ADKfuVV687UFdGhTDO34agCF5R99T6 ABu+8WAiFdsgngFZqTx3PpCQXjrUITqPAxdkck7t3IehEpe77OwY1HiWmPJX9j2eifso0V zsM85h39BH+bCMsfhSr3hR7tumWw10JnD0ecmysyz6hpBPtB3PzTMG55tZRRfFCVLhVMrD nycFi+FTbbUXDMb/DwWgnPmXXCLn+sMOpcG77h/vybQ0pTjSopzIprPSFL0qFQ== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 0A9B6CE24; Wed, 2 Mar 2022 00:31:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 1 Mar 2022 16:31:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH users/roland/event-pipe] Avoid conflict with gnulib open/close macros. Content-Language: en-US To: Roland McGrath , GDB References: From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646181115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ehe8mltn1YJH64nOv4E1LmpWZ8PhjD2CAc5VI/eyvv4=; b=WUCYvLklKaydWNxXzhjJKi9uh55OS9PcOuVkTeeGz+YBqlZqbFkhCaClBQPuRH0XC9Yfvb NFYxMPHc224FS00A6YHtjJpvF5H+X+KJ4D/u/EjKGVg8worsxkyOStTm6Isj+c/Vggvz8s nE1FXd6rtR3p3VY7UtOhEZWjuBrSElpYFUINiBG4Myu7jxsEi87Bm1z6CnJ5ZruLLpc9xT FfkcSZlM7HkOFxAt9aKOelZZusOIw7g7xu996EVz07Yoc0nH2kaPMsOGrokyjP2mm/q0qj PA2sdWx86MJzAntSCnlxXRbrYPTMB4wEwDZ45lIyO7bWDVZi0nB84rlebXu2jg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646181115; a=rsa-sha256; cv=none; b=yklw7XOBEXTwVYnBB9xH8PfPcOSGhVY/kmfwyGbV3zGy6/VGT8/BaIDlZWNN8+5wo0YnYz 0tqNNoI3ofi4h9S4+y6SZ41E7rI7NY0645s8mRCQW7y594pKdS+Ljge5DrWyHWMYECuBBx n2h4A4tsBDc3JZgq87waJq2iN58MeXO6Y3xEEMPnPyvtcRGr21EpumtKzcqpAZlnDoXtEd PtmXNmVfgIcFivJDdRFAuzPC/yMO88sKITwe432xTgqvQmXYC2LL43rVTiGYJSI7CqIDNC v/03OWCNuB0dCqsAWv28cVq+DbSdOKTSVoyn5gzNDAM3XuEslhCiTHinl6Hwpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 00:31:56 -0000 On 3/1/22 4:26 PM, Roland McGrath via Gdb-patches wrote: > [This patch is on sourceware branch users/roland/event-pipe for your > convenience. I can merge it in myself after approval.] > > On some systems, the gnulib configuration will decide to define open > and/or close as macros to replace the POSIX C functions. This > interferes with using those names in C++ class or namespace scopes. I noticed this recently as well (and I authored the event-pipe.cc file). This is an unfortunate consequence of the gnulib #define approach. I think this patch is fine (but I'm not an approver). -- John Baldwin