From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by sourceware.org (Postfix) with ESMTPS id 0AAA13857404 for ; Mon, 21 Mar 2022 16:55:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0AAA13857404 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f41.google.com with SMTP id h16so8384789wmd.0 for ; Mon, 21 Mar 2022 09:55:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=o3hlRBM3YO/1BKOv5yv94dZHusCEScn9U92zeM+V8j0=; b=CK+3uv7exGBM16eq3KKib0+UUA9TXR8AHvTcU4CuyDOWveq/XA82Fik65nirLDfxQK EVzYYwPTeHkhnEhVGPOkc00bqspsE4Gy+XfwNwqQKL/xcxE4paeEjQBfCs6kRFSXjyVT +GD9FD1hMbvPNRI6uP7M73d2CdQFXzWuRyiBBH7LQNfpqereCnaV9npq1eVpeTmNNwU9 5YTaUxeKpmUCPv+bTGDWkBHpyr+uI0dnZws0y9I5deXs2qJZEj6Ic/avLR375tdh3uE8 xvUoqOpr0SMReC4+IcGfblYAPjpx7RiZxA2CwgKvpQITYbe/PhQxJZRJhcU+DmM0GKGZ vXVg== X-Gm-Message-State: AOAM531cTtcqNgSKMRghQbs2FMDiwrtAFUmaCcYZVkCLxjgTpzUEIQrm izYeLatFBjPE/SfBZRofPw8EpdHTsFg= X-Google-Smtp-Source: ABdhPJx4unIwdRo6XGAcqvfztBdgz9SXXIPEcBZDm+PaPs4jaxy8b9Xd+ekegjCP22lYJe/tj3NLmA== X-Received: by 2002:a05:600c:651:b0:381:3d7b:40e0 with SMTP id p17-20020a05600c065100b003813d7b40e0mr20267wmm.17.1647881740645; Mon, 21 Mar 2022 09:55:40 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id h188-20020a1c21c5000000b0038c6c37efc3sm56895wmh.12.2022.03.21.09.55.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 09:55:39 -0700 (PDT) Message-ID: Date: Mon, 21 Mar 2022 16:55:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/2] gdb/python: remove Python 2 support Content-Language: en-US To: Simon Marchi , Eli Zaretskii , Simon Marchi Cc: gdb-patches@sourceware.org References: <20220107152921.2858909-1-simon.marchi@polymtl.ca> <20220321144624.1450968-1-simon.marchi@efficios.com> <20220321144624.1450968-2-simon.marchi@efficios.com> <83lex3fj3h.fsf@gnu.org> <89a0c3a3-b891-bdfc-e7cc-7ca628d30f16@simark.ca> <099c15b0-71e1-2249-82b2-d0456ec240b4@palves.net> From: Pedro Alves In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 16:55:44 -0000 On 2022-03-21 16:31, Simon Marchi wrote: > On 2022-03-21 11:33, Pedro Alves wrote: > > Using this PPA > > https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa > > on Ubuntu 18.04, I tried Python 3.1 and above. Python 3.1 didn't build > because of this: > > CXX python/py-record-btrace.o > ../../gdb/python/py-record-btrace.c: In function 'PyObject* btpy_list_slice(PyObject*, PyObject*)': > ../../gdb/python/py-record-btrace.c:504:25: error: cannot convert 'PyObject* {aka _object*}' to 'PySliceObject*' for argument '1' to 'int PySlice_GetIndicesEx(PySliceObject*, Py_ssize_t, Py_ssize_t*, Py_ssize_t*, Py_ssize_t*, Py_ssize_t*)' > &step, &slicelength)) > ^ > ... which is a "bug" in the Python 3.1 API, fixed in 3.2. Python 3.2 > built fine (although I didn't test further, other than starting GDB). > > So I would replace "2.6" with "3.2" in there. Sounds good? Sounds good to me.