public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] [gdb/testsuite] Add xfail case in gdb.python/py-record-btrace.exp
Date: Mon, 20 Feb 2023 11:36:44 +0100	[thread overview]
Message-ID: <eacc481e-13ca-b039-18d5-bd5a09947271@suse.de> (raw)
In-Reply-To: <BN0PR11MB5757E0EEBD5B2A2AFDDF5473DEA49@BN0PR11MB5757.namprd11.prod.outlook.com>

On 2/20/23 08:38, Metzger, Markus T wrote:
> Hello Tom,
> 
>> I came across:
>> ...
>> gdb) PASS: gdb.python/py-record-btrace.exp: prepare record: stepi 100
>> python insn = r.instruction_history^M
>> warning: Non-contiguous trace at instruction 1 (offset = 0x3e10).^M
>> (gdb) FAIL: gdb.python/py-record-btrace.exp: prepare record: python insn = r.i\
>> nstruction_history
>> ...
>>
>> I'm assuming it's the same root cause as for the already present XFAIL.
>>
>> Fix this by recognizing above warning in the xfail regexp.
>>
>> Tested on x86_64-linux, although sofar I was not able to trigger the warning
>> again.
>> ---
>> gdb/testsuite/gdb.python/py-record-btrace.exp | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
> 
> Looks good to me.
> 


Thanks, added approved-by tag and committed.

- Tom


> Markus.
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
> 


      reply	other threads:[~2023-02-20 10:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 14:22 Tom de Vries
2023-02-20  7:38 ` Metzger, Markus T
2023-02-20 10:36   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eacc481e-13ca-b039-18d5-bd5a09947271@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).