From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-145487-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 106880 invoked by alias); 21 Feb 2018 12:57:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 104976 invoked by uid 89); 21 Feb 2018 12:57:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=
X-HELO: smtp.polymtl.ca
Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Feb 2018 12:57:50 +0000
Received: from simark.ca (simark.ca [158.69.221.121])	(authenticated bits=0)	by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w1LCvh0Q029724	(version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)	for <gdb-patches@sourceware.org>; Wed, 21 Feb 2018 07:57:48 -0500
Received: by simark.ca (Postfix, from userid 112)	id 830061E76B; Wed, 21 Feb 2018 07:57:43 -0500 (EST)
Received: from simark.ca (localhost [127.0.0.1])	by simark.ca (Postfix) with ESMTP id 038471E059;	Wed, 21 Feb 2018 07:57:43 -0500 (EST)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 21 Feb 2018 12:57:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 09/10] Move register_dump to regcache-dump.c
In-Reply-To: <CAH=s-PO4iN2sSSm-kv9USnx3u6mjigQ2X1kp1JMG4urq0_L=Fw@mail.gmail.com>
References: <1517999572-14987-1-git-send-email-yao.qi@linaro.org> <1517999572-14987-10-git-send-email-yao.qi@linaro.org> <9c0e590fd8e1d5d54a426aefe7c78650@polymtl.ca> <CAH=s-PO4iN2sSSm-kv9USnx3u6mjigQ2X1kp1JMG4urq0_L=Fw@mail.gmail.com>
Message-ID: <ead1cc4666c2644dc3c740f60ee87d24@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.3.4
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 21 Feb 2018 12:57:43 +0000
X-IsSubscribed: yes
X-SW-Source: 2018-02/txt/msg00290.txt.bz2

On 2018-02-21 03:27, Yao Qi wrote:
> On Sat, Feb 17, 2018 at 3:50 AM, Simon Marchi <simon.marchi@polymtl.ca> 
> wrote:
>> I think it would make sense to move the remaining dump-related things 
>> (the
>> register_dump class, the register_dump::dump implementation) to
>> regcache-dump.c.
>> 
> 
> register_dump::dump accesses 'struct regcache_desc', which is declared 
> in
> regcache.c, so that register_dump::dump can't be moved to  
> regcache-dump.c.

Is there any reason we can't move struct regcache_descr to regcache.h?