From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 4BA5A3858C5E for ; Thu, 9 Mar 2023 21:25:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BA5A3858C5E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4PXj0H4yzsz42Mh for ; Thu, 9 Mar 2023 21:25:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PXj0H48Svz3MhV for ; Thu, 9 Mar 2023 21:25:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678397151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TtqTAkmBaxiiTs+g53x3DPAd8yyatpP4iLJyvWttvWs=; b=ERJr7eG9RRGLXEkAxVhyL65mdqrNK686/b2QlvwjElsk8f5fF0jMOHnObhHDSpKJ1zSOQo 2TBqJgHAI4PwrISyLV7BTcZ6P30CuqqWDesTNENndklaPXsthdqWu3gD39zMKztGx6SkvS ufS0fTcoJcdaGNuWLeqWFl00YdDGxjBytc8KdWQtNaes8DWThzcs3XrQ095rl5FPO0UpBb QDLtm2DV49sRvgIyBo2SF9kJKzM8Vzihfx+pygXk64BvZNHq2BMAaasyKZPgiw2fXQqGKV OYvN7/8xOsUDukpspnyBiyI8I8eVU8pK9Iq8boQHiruxHzLlTu25iSNwk4/YGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678397151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TtqTAkmBaxiiTs+g53x3DPAd8yyatpP4iLJyvWttvWs=; b=O8F7dCsDriLyjLvfA/ykNzlpkns+QCF65gr80iq6LfAnNKvmRRNzI1209sfZDWm4lh5we+ 7b+h0lPW0GXigPExpRtZtViOrzvJJHDF3T9ZoFdR57k7/WB4GsP/OOHEFV4tcTY4lgAqcO FqdTyc5BBkS/8DKOpiSgFKUm4Wi8DTgZw5JffVa8mIoljwEHC4xgV7dZctVOgy5Te/WzfM tt8VijY54mVkeXdF924Dq/DXR21BPeDwEHIn7miABHqr64t1QMFG1319EyxzDOslV0o8UZ t42OnqkymK7VutY+blvkQYzWJM9JLPbf0L8FCKchPr77qsjyDh+kZHdNvKFlpQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678397151; a=rsa-sha256; cv=none; b=UEkk3sCYIIk6jOe3ghUEyYJ2PYAe//uE8jTG1TNdhFuYRYvDl1wyyVXeHOOxVPxpIDvHoi Z7b/SZCNhiX6QmWVUvJh+iYdjIraRn28ZC3oC7prS2BYMICQA30bX3AOsTMZtvihbo6m+z kIyA/h/kzDzhKbpAwpvsZIQpwHj7H67fyh0pN/JkAvycPDLYPFI+P7OXwXbBrJTIhs8YJ+ yC47+geE/DiWMnp1EAMsqYx/T2Mrkokt7OUPR//x1UpnPswOYkfV+qA57Bsg1Ks7dSbmwl jf1JpBQAQZ0wpZX+qfztkM1glQgFATgVmSABVBa2kpIgpt7zpKaNlR95HQeRBQ== Received: from [IPV6:2601:648:8680:16b0:f07c:89ba:6199:d0c4] (unknown [IPv6:2601:648:8680:16b0:f07c:89ba:6199:d0c4]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PXj0H1mPszfX6 for ; Thu, 9 Mar 2023 21:25:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Thu, 9 Mar 2023 13:25:50 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] PR gdb/30214: Prefer local include paths to system include paths Content-Language: en-US From: John Baldwin To: gdb-patches@sourceware.org References: <20230309212341.55302-1-jhb@FreeBSD.org> In-Reply-To: <20230309212341.55302-1-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/9/23 1:23 PM, John Baldwin wrote: > Some systems may install binutils headers into a system location > (e.g. /usr/local/include on FreeBSD) which may also include headers > for other external packages used by GDB such as zlib or zstd. If a > system include path such as /usr/local/include is added before local > include paths to directories within a clone or release tarball, then > headers from the external binutils package are used which can result > in build failures if the external binutils package is out of sync with > the version of GDB being built. > > To fix, sort the include paths in INTERNAL_CFLAGS_BASE to add CFLAGS > for "local" componenets before external components. > --- > gdb/Makefile.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index 6e39383eb93..40497541880 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -629,8 +629,8 @@ INTERNAL_CPPFLAGS = $(CPPFLAGS) @GUILE_CPPFLAGS@ @PYTHON_CPPFLAGS@ \ > # INTERNAL_CFLAGS is the aggregate of all other *CFLAGS macros. > INTERNAL_CFLAGS_BASE = \ > $(GLOBAL_CFLAGS) $(PROFILE_CFLAGS) \ > - $(GDB_CFLAGS) $(OPCODES_CFLAGS) $(READLINE_CFLAGS) $(ZLIBINC) \ > - $(ZSTD_CFLAGS) $(BFD_CFLAGS) $(INCLUDE_CFLAGS) $(LIBDECNUMBER_CFLAGS) \ > + $(GDB_CFLAGS) $(OPCODES_CFLAGS) $(BFD_CFLAGS) $(INCLUDE_CFLAGS) \ > + $(READLINE_CFLAGS) $(ZLIBINC) $(ZSTD_CFLAGS) $(LIBDECNUMBER_CFLAGS) \ > $(INTL_CFLAGS) $(INCGNU) $(INCSUPPORT) $(LIBBACKTRACE_INC) \ > $(ENABLE_CFLAGS) $(INTERNAL_CPPFLAGS) $(SRCHIGH_CFLAGS) \ > $(TOP_CFLAGS) $(PTHREAD_CFLAGS) $(DEBUGINFOD_CFLAGS) $(GMPINC) \ This came out of a thread on gdb@. It is a candidate for gdb-13-branch as well as master. -- John Baldwin