From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 65178385841C for ; Thu, 12 Jan 2023 18:32:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 65178385841C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B3F371E110; Thu, 12 Jan 2023 13:32:38 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1673548358; bh=Kaae2262el/eiCfiJznqkb9f2NAySjjq2UuZSwYkLg0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=VPqsezR1nIGIQzNw9rvZqltWrjgGBKooqAfUwhQ4N02gmnV/lH0apoYQZJ2Vd1xSO YGFnm6FK84SZG4m79q543m/q1/lYbpUA8Lc2+8YBP4YLRwsWjuj5WTxidPXyVhq/EX wPXltvVxCXcMNI441H+LvvAZSzMSQGnJ5bAl3iGo= Message-ID: Date: Thu, 12 Jan 2023 13:32:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] Disable ptype/o for dynamic types Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230111184237.2917382-1-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20230111184237.2917382-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/11/23 13:42, Tom Tromey via Gdb-patches wrote: > A user pointed out that "ptype/o" of a certain Ada type -- while in C > mode -- caused gdb to crash. > > The bug here is that dynamic types can't really be printed this way. > This patch avoids the bug by disabling the "/o" feature in this case. > > Note that using "ptype/o" in this way makes sense for the time being, > because the Ada code doesn't support the "/o" feature (yet); and in > any case gdb should not crash. LGTM: Approved-By: Simon Marchi Simon