From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EB40B3858D32 for ; Sat, 11 Feb 2023 13:46:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB40B3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A37D41E112; Sat, 11 Feb 2023 08:46:06 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1676123166; bh=dmAmGAOIJLC6Yw/urzRKh7sXMtE8iDxpxD1Dss9BleQ=; h=Date:Subject:To:References:From:In-Reply-To:From; b=ObZvkdQ8JRUCUp2yImgoIEmrXKq2FPcBNJxVm747OSTvv3l4sagQG5T6uVcSIMchG IbmcyiywULswYlw7exHqO07chXzAOm5zWqp07Mk6dOwlwlCZFwKBgCRcg4ZHY2OXWL qXMvV2q79+sV22HMFdrsGSI7z3V0KdLdI4fT1xr4= Message-ID: Date: Sat, 11 Feb 2023 08:46:06 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 42/48] Turn various value copying-related functions into methods Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230209-submit-value-fixups-2023-v2-0-b0b27fd97177@tromey.com> <20230209-submit-value-fixups-2023-v2-42-b0b27fd97177@tromey.com> From: Simon Marchi In-Reply-To: <20230209-submit-value-fixups-2023-v2-42-b0b27fd97177@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > -/* Copy LENGTH bytes of SRC value's (all) contents > - (value_contents_all) starting at SRC_OFFSET byte, into DST value's > - (all) contents, starting at DST_OFFSET. If unavailable contents > - are being copied from SRC, the corresponding DST contents are > - marked unavailable accordingly. DST must not be lazy. If SRC is > - lazy, it will be fetched now. > - > - It is assumed the contents of DST in the [DST_OFFSET, > - DST_OFFSET+LENGTH) range are wholly available. */ > - > void > -value_contents_copy (struct value *dst, LONGEST dst_offset, > - struct value *src, LONGEST src_offset, LONGEST length) > +value::contents_copy (struct value *dst, LONGEST dst_offset, > + LONGEST src_offset, LONGEST length) Missing /* See value.h. */ Otherwise: Approved-By: Simon Marchi Simon