From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by sourceware.org (Postfix) with ESMTPS id 67250385842A for ; Wed, 8 Feb 2023 17:55:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67250385842A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f42.google.com with SMTP id e3so836555wrs.10 for ; Wed, 08 Feb 2023 09:55:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XcpCArm/Ue5RqpaH9ZDzRi/14ENaVVHbI/Ddg97pGRU=; b=uNK/vRH7CsiuaHASlQMN0Ba7FbLX16Iu0yTxg8pEtpQB7XVODdRh+38LP+G3kMx384 k7tTEi13yEC5Cmb+Vn+57hVWD17GHLHJ/ggIYNm+9xbVh+fzpIs3Jgxoy0BFn/aUvuWH aCv68sjlVtb3k03n62D+fTrvDLGPR2UREd4sUjTrBW8b/apPcvZvnMpCoADNzBeH3DKS 7TPWVGMX+uKJN+/oZMqZF4tL0+gQqtWvqF3cfRdYwfeOv4ilWQcGkl2CwYfp9WXotSoQ Hpxsp+c/foPjoenWiXxqIJdfso/DeIAq9myY7XZLeMeYEoJOdnetHb3i9WTtaspE07wp mwWQ== X-Gm-Message-State: AO0yUKVhjAQqgxEvMlduPNFQBaXtk7bOpiiUCHwlPMpEoLGAAWVN+HUT jTnK89OwWgWigHn25IayzPgAwvRtlNdKlg== X-Google-Smtp-Source: AK7set8jShcVvm63bIqXeP+OAWA5iGAjCqK97fwu9WE75yx4eroS/mU4AXNscaU+MLeQkY4Olt+ltQ== X-Received: by 2002:adf:f484:0:b0:2c3:e34d:a331 with SMTP id l4-20020adff484000000b002c3e34da331mr8068907wro.36.1675878912095; Wed, 08 Feb 2023 09:55:12 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id e6-20020a5d6d06000000b002be099f78c0sm14938678wrq.69.2023.02.08.09.55.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 09:55:11 -0800 (PST) Subject: Re: [PATCH 2/3] gdb: show task number in describe_other_breakpoints To: Andrew Burgess , gdb-patches@sourceware.org References: <8716dc72011765a13c3eee0b60a262fbcbd48d41.1675869497.git.aburgess@redhat.com> From: Pedro Alves Message-ID: Date: Wed, 8 Feb 2023 17:55:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <8716dc72011765a13c3eee0b60a262fbcbd48d41.1675869497.git.aburgess@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-02-08 3:23 p.m., Andrew Burgess via Gdb-patches wrote: > # Now, insert a breakpoint that should stop only if task 3 stops, and > -# extract its number. > -gdb_breakpoint "break_me task 3" message > -set bp_number [get_integer_valueof "\$bpnum" -1] > -if {$bp_number < 0} { > - return > -} > +# extract its number. Use gdb_test here so that we can validate that > +# the 'Breakpoint ... also set at' line correctly includes the task > +# number of the prevoius breakpoint. prevoius -> previous Otherwise, Approved-By: Pedro Alves Thanks, Pedro Alves > +gdb_test "break break_me task 3" \ > + [multi_line \ > + "Note: breakpoint $bp_number \\(task 1\\) also set at pc $hex\\." \ > + "Breakpoint $decimal at $hex: \[^\r\n\]+"] > +set bp_number [get_integer_valueof "\$bpnum" "INVALID" \ > + "get number of breakpoint for task 3"] > gdb_test "info breakpoints" "foo.adb:${decimal}\r\n\\s+stop only in task 3" \ > "check info breakpoints for task 3 breakpoint" > >