From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 305BD3858C2C for ; Tue, 4 Jan 2022 18:56:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 305BD3858C2C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 204IuqCK031855 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 4 Jan 2022 13:56:56 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 204IuqCK031855 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id DE3031ECEB; Tue, 4 Jan 2022 13:56:51 -0500 (EST) Message-ID: Date: Tue, 4 Jan 2022 13:56:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] [AArch64] Fix PR gdb/28681 Content-Language: en-US To: Luis Machado , gdb-patches@sourceware.org References: <20220104172254.3665546-1-luis.machado@linaro.org> <35890e99-0fc3-49b3-4eb1-59cdf606c2e1@polymtl.ca> <1e813eab-3b10-6f78-4375-d72feace6e7c@linaro.org> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 4 Jan 2022 18:56:52 +0000 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 18:56:59 -0000 > How about "gdb: on aarch64 non-trivial C++ objects are returned in memory"? Sounds good. Although if I had to be picky, I'd say it's not perfect because it just states a fact (as in "the sky is blue"), and doesn't describe the code change the patch does. I would go with something like "gdb/aarch64: fix return value location of non-trivial C++ objects". The commit message would then say that the architecture's ABI describes that this kind of object must be returned in memory, but GDB currently erroneously returns it in registers, and that the patch fixes that. Simon