From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 4B0E8388A800 for ; Wed, 13 May 2020 00:52:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4B0E8388A800 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C8DB11E79B; Tue, 12 May 2020 20:52:56 -0400 (EDT) Subject: Re: [PATCH v3 6/6] gdbsupport: Drop now unused function 'stringify_argv' To: Michael Weghorn , gdb-patches@sourceware.org References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200512154211.1311364-1-m.weghorn@posteo.de> <20200512154211.1311364-6-m.weghorn@posteo.de> From: Simon Marchi Message-ID: Date: Tue, 12 May 2020 20:52:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200512154211.1311364-6-m.weghorn@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2020 00:52:58 -0000 On 2020-05-12 11:42 a.m., Michael Weghorn via Gdb-patches wrote: > The function did not properly escape special characters > and all uses have been replaced in previous commits, so > drop the now unused function. > > gdbsupport/ChangeLog: > > 2020-05-12 Michael Weghorn > > * common-utils.cc, common-utils.h (stringify_argv): Drop > now unused function stringify_argv > --- > gdbsupport/common-utils.cc | 23 ----------------------- > gdbsupport/common-utils.h | 4 ---- > 2 files changed, 27 deletions(-) > > diff --git a/gdbsupport/common-utils.cc b/gdbsupport/common-utils.cc > index ed05d619c7..b5e4d2928e 100644 > --- a/gdbsupport/common-utils.cc > +++ b/gdbsupport/common-utils.cc > @@ -375,29 +375,6 @@ free_vector_argv (std::vector &v) > > /* See gdbsupport/common-utils.h. */ > > -std::string > -stringify_argv (const std::vector &args) > -{ > - std::string ret; > - > - if (!args.empty () && args[0] != NULL) > - { > - for (auto s : args) > - if (s != NULL) > - { > - ret += s; > - ret += ' '; > - } > - > - /* Erase the last whitespace. */ > - ret.erase (ret.end () - 1); > - } > - > - return ret; > -} > - > -/* See gdbsupport/common-utils.h. */ > - > ULONGEST > align_up (ULONGEST v, int n) > { > diff --git a/gdbsupport/common-utils.h b/gdbsupport/common-utils.h > index ba03427c6f..30ee412365 100644 > --- a/gdbsupport/common-utils.h > +++ b/gdbsupport/common-utils.h > @@ -154,10 +154,6 @@ extern const char *skip_to_space (const char *inp); > freeing all the elements. */ > extern void free_vector_argv (std::vector &v); > > -/* Given a vector of arguments ARGV, return a string equivalent to > - joining all the arguments with a whitespace separating them. */ > -extern std::string stringify_argv (const std::vector &argv); > - > /* Return true if VALUE is in [LOW, HIGH]. */ > > template > -- > 2.26.2 > This LGTM too. Simon