From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00076.outbound.protection.outlook.com [40.107.0.76]) by sourceware.org (Postfix) with ESMTPS id 9B2A93830661 for ; Tue, 7 Jun 2022 12:41:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B2A93830661 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KlYZ7Cruiib2+ttvXhcePbWcLFUiuM8UoXgFXM5CMMky9SjrmQZK/TNGI+7lwr+EYyhLSYUYorbLZnkysz9koUUXPDcasPVo6+0K3CTQeCE8niJLs7Cp0jCoVEPREAjKe4zT6uUAqNEBWWnr4iQeSx4TAUwfnYqCT8+Hjhnju1YWjvKYSx0a6sB9tsr0guPMT5uPQaz7HlSsJLSe9p9N2lEvdk8mJhXlep9MdMl7uHA9aotQ97cUkNSHSFlFl+boSnU/w893qTQiACTULksV+oZLGPx/OHaVRaYfTBCBmTziVsXsmrH3Oa05XTR28Cx1Cmfb/DpraCrwbc5STIA+PQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=adGu8ngNSQjC5LDX0AP1L4dsy70/Tppj9fkvck8O+Kg=; b=ISHesVxJu0bWUNWb9qoLCgwfyhSn9kXn2+dtM4cjvI9XeMUOUDihRuR441Ut5JUAQ5i/NfAIYfy7/Vs/NpQqolP9QZzKWLAWpv3lVtEEYK2FwLMSOg9XrdKOifzh2egV7MrFeBXpieLYDvE64jfUJix9y0ZizGl3hv2RL9+8SCeMcSGLr9gOURz0ZZxkLHvF1DT4VfzvGgzbJYtx0r3qdgZsYgGLTIZ99l4tgqQTdJEDadVQ/rB75/uCfM2FcSUfwAwdRJ6Q3IqzpooVdMegBfn0iEfHtGgzOhyqwYJ24kaFslEup6QJ1cVzIy1jYPBn/QUhvwymvVGASpptTF0t9A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM6PR08CA0039.eurprd08.prod.outlook.com (2603:10a6:20b:c0::27) by DB6PR0801MB1960.eurprd08.prod.outlook.com (2603:10a6:4:76::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.15; Tue, 7 Jun 2022 12:41:47 +0000 Received: from AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:c0:cafe::d1) by AM6PR08CA0039.outlook.office365.com (2603:10a6:20b:c0::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.14 via Frontend Transport; Tue, 7 Jun 2022 12:41:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT017.mail.protection.outlook.com (10.152.16.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12 via Frontend Transport; Tue, 7 Jun 2022 12:41:46 +0000 Received: ("Tessian outbound 5b5a41c043d3:v120"); Tue, 07 Jun 2022 12:41:45 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1d790dbae7e63781 X-CR-MTA-TID: 64aa7808 Received: from 74ee9921d46e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D8820E3D-CD2F-411B-8BF4-2D0E44C9BEF6.1; Tue, 07 Jun 2022 12:41:39 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 74ee9921d46e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Jun 2022 12:41:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SCY/Zdx3JoXKoZlp4s0XSAivQWbQLLxHQXvyrNCHcNDauVPto2PYEfh6yVUcT2yUlc1hrpI4O9uhIi2D2bRVRRBr2ncPFzto8dgtq7K97qeagW3vmzFYK9PMvyncrUMtmpFRKZNPkqzXUEZjajFCMicNrymBotCS0iLMzNGrfnGekRo/mE7b4NC9xUxojoNVA/WQLNhdZrVgWTnVe4UGotjhh+BKkO6IjgbRyI0q6FaJMO8VwnXFW8DUqjr39WDep7Gt4fltJDCSQoMVpLPI8QIiRjRn5RR+UWgcUUZElGBSgr8pCoy8nn5tE7wHOOjklOVyWgKm6tJPiakCIvn16Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=adGu8ngNSQjC5LDX0AP1L4dsy70/Tppj9fkvck8O+Kg=; b=gpqxvW2U6r2YV6fNSBqJlH2fXpvD7DVkFY7gRp2RY6C0cOOgW0IFngRFRLyxzklOZZGTB4NoRRfHwNHqtKw2Elq2kmE2i/fmLCTT0EjyVbYOCEOXsp04XVLHwXK+a8G74xY/yPsiKSq1eYxV/vdfOooUARKUlKN3wloYnESXACC3IiedTUhLDF5FVTIc1VrxDBCTVMJoWe+rJ2Zlgl+nQ69ROxMn9QyahdUfGVaWS/KFB7zmau6iWHYFQwSuulNFpq7v0Motr7t1s8I3Ds9vr4AY6DWqU4kWaPDVlAK6R7Pw3VBMfOGbCGvLdb3mCPL/kLm3hgpue8Oz4rK8VhjN1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM9PR08MB6913.eurprd08.prod.outlook.com (2603:10a6:20b:302::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 7 Jun 2022 12:41:38 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::9545:ff73:df89:3e50]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::9545:ff73:df89:3e50%7]) with mapi id 15.20.5314.019; Tue, 7 Jun 2022 12:41:38 +0000 Message-ID: Date: Tue, 7 Jun 2022 13:41:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] gdb/arm: Simplify logic for updating addresses Content-Language: en-US To: Yvan Roux , gdb-patches@sourceware.org Cc: Torbjorn SVENSSON References: <20220602142100.GB23363@gnbcxd0114.gnb.st.com> From: Luis Machado In-Reply-To: <20220602142100.GB23363@gnbcxd0114.gnb.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0034.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::22) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 45ff1a0d-bdda-4ba6-b9ab-08da48831575 X-MS-TrafficTypeDiagnostic: AM9PR08MB6913:EE_|AM5EUR03FT017:EE_|DB6PR0801MB1960:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oP4+zl4tf7UqLf7Qd1HOjgZJwQeU+N/5SNxqLf+lW2FxLQMJJhXMliCAcCCObNuqsRwkVy/3GpiPmGusUhAebfzVphrp51bFfXcHwomUPOZl0Btiyq8gNGlFnqg93rqP5vyRPDqenRX8z7PZQKqQh+axGdgVwR0U6pJerWeVEWBOipoFCD5pE6sFupz7EfRTtrhyMAVleQDc8TtVYvIPTHTTs9GAHI6si9+NYxSoTY94JsD/9CegLCK35SHNcIzhLF0H4dFmBNQQWt8epL9vKNFxuGl6qgyw7ERNzpTDVATLQJBGm6u/9gSvG+P/7GxkKEHg8WZaKzcdXfFxiCg4DO/JUQKq1dYnegw/B47MCKuriFauJqE/w6WWeF30EfZXig1KJZRa8xpg3h8pX2hgizNh6MAVxRpUYWnLFt5iDon82J3wputZm5DlZXkMd7sEQLSgTKnBvAdM1EMcGktcgdAiSo0xp6qqtDY81+h9PtZTd0/v4+UAiq8VaiKNcJxZgq8NtKqUZwYWdFXfEb55Kpni5jQvIFpimHYCyX9UrUTc/oEawzVFOTnLVe+0tmgOZU2vVJwbC8GDdvqkUJAx26AmlLgBqWmMHzD4+jrK5l5oPAxMMrYPufZs0MYoiawqTtFdWDLwGthNSKySD/uL3T4iyCHRO67LneMmB4TAPR6q5wJr4pc7E1UkOS3C7zS9UarM7lbOD8jOUbLq2ShU7g59ZOwq0+fCdClyos4taf4UWuQyv6LTkGrLI3ZEZbiH X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(31696002)(316002)(66476007)(8676002)(6666004)(66946007)(186003)(4326008)(44832011)(66556008)(2616005)(6506007)(53546011)(26005)(86362001)(2906002)(6486002)(508600001)(38100700002)(83380400001)(5660300002)(8936002)(31686004)(36756003)(6512007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6913 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: be9f6438-18ed-4d76-1495-08da48831071 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c9T/2jtTuuo/Q1DteJhO1zdVWWHTpl+0maRYRXKtNCvCwKTbgAm/vWppbcshPx1O1WLTRrhW6cJJIumPaQaauBczyTC0i2ssnxNQw15rn7vvTlzJuuy1rP7Vx3dGFn+9ENcen5gLyzzCQUV5ZArcgod51/8ZC3HHdgLIB9spK2FcquE67+UbiNBKmBJi3ZhspgkNGeV+fIUyVBQhT6wIGgjlhban+8hpgb7iJAOsgaDA0B4judrs8yyhAgCoxDGv5Hi1m05uAgBNQVX2STxasobSikuEK5GMkBpy7u+xDt8H0qRlLf1V/as3eW4bBz2azC0bo9c5QltBzq5sgywkWWDu1cH2W7uiSOlDl18O3j9yd+n7ZnSkxiCY2ZcvPCKtTET5Tm9ZWF7fQeGA6DxTRMa1q9AXzgo+657A3UmQO4vRMyoT4M6AoMPHejAR2nLN6APDkKmXbc7sInvPFi25fZ3AJPktW5hqwfzBaZZ7YSxxG1w2noUJs69Dg6Eca0e25npwoJrrHezzR8EIXjHImCSbPuOb0d19ttvudP5rzHIBY+a5+HXxaygeBIMRz+cZEt6zz8GdDS0nDMTewuGKL56jpJWEYaFqb4ZIqbdYJX/4jGejyxNK9LlY/4UUd9qNIKi2VDMJcxnToyq20bu6SBHCzIDd0q9tIU53Nbss6jb9yeyAZ90IHzN8JmdynRfCo4t5prQHnC26WCGGWp851Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(40460700003)(6666004)(2616005)(53546011)(336012)(47076005)(6506007)(81166007)(8936002)(5660300002)(2906002)(31686004)(44832011)(36756003)(82310400005)(508600001)(8676002)(31696002)(83380400001)(4326008)(356005)(6486002)(6512007)(86362001)(36860700001)(26005)(186003)(316002)(70206006)(70586007)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2022 12:41:46.3673 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45ff1a0d-bdda-4ba6-b9ab-08da48831575 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1960 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 12:41:56 -0000 On 6/2/22 15:21, Yvan Roux wrote: > Hi, > > Small performance improvment by fetching the previous SP value only improvment -> improvement > once before the loop and reuse it to avoid fetching at every > iteration. > > Signed-off-by: Torbj�rn SVENSSON > Signed-off-by: Yvan Roux > --- > gdb/arm-tdep.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 50ec41a66b1..23e3ad4a072 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -2177,7 +2177,7 @@ arm_make_prologue_cache (struct frame_info *this_frame) > { > int reg; > struct arm_prologue_cache *cache; > - CORE_ADDR unwound_fp; > + CORE_ADDR unwound_fp, prev_sp; > > cache = FRAME_OBSTACK_ZALLOC (struct arm_prologue_cache); > arm_cache_init (cache, this_frame); > @@ -2191,14 +2191,15 @@ arm_make_prologue_cache (struct frame_info *this_frame) > arm_gdbarch_tdep *tdep = > (arm_gdbarch_tdep *) gdbarch_tdep (get_frame_arch (this_frame)); > > - arm_cache_set_active_sp_value (cache, tdep, unwound_fp + cache->framesize); > + prev_sp = unwound_fp + cache->framesize; > + arm_cache_set_active_sp_value (cache, tdep, prev_sp); > > /* Calculate actual addresses of saved registers using offsets > determined by arm_scan_prologue. */ > for (reg = 0; reg < gdbarch_num_regs (get_frame_arch (this_frame)); reg++) > if (cache->saved_regs[reg].is_addr ()) > - cache->saved_regs[reg].set_addr (cache->saved_regs[reg].addr () > - + arm_cache_get_prev_sp_value (cache, tdep)); > + cache->saved_regs[reg].set_addr (cache->saved_regs[reg].addr () + > + prev_sp); > > return cache; > } Thanks. This is OK.