From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 8EFB73882661 for ; Tue, 21 Nov 2023 22:22:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8EFB73882661 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8EFB73882661 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700605342; cv=pass; b=N3qbe4Xsy4sK384VM0u+CgyPaFKt+K4129d/jVc9nADTsfqa1P8kCq0bzt6zFs9DlmrCvTruGw643HRC9Z09C21ygjgPn8/pFb6AXVRlXRhHZSWv14YVmR/yi3uMXhAPGRCUH9gZqGt7Iu6TUXXrGr62Gi2azcTTSRnUh9EFI/0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700605342; c=relaxed/simple; bh=+ydommVVJ9uqf0JE+QGQBZw6ZLHXcmahuzkI/JyOGdI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=x6NMEE+vBP8L4TeBqhttp7qQC6d9tiQ2IyvFi+pr8SE3S2PZ4IRI2dMVx3+b12IdrBNT+EC+tQlWlI+fgLnCcPypUdVJI97Sb8tfwOhdv+MAT9Nb4Gluo46MtRVSlFJ25KX7zmJb/FFmnlH4bqWRqejN2QyAT+gXfWVqna42cIc= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4SZf4r2hpdz4frV for ; Tue, 21 Nov 2023 22:22:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SZf4r1s7Lz4JMw for ; Tue, 21 Nov 2023 22:22:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700605340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZoVAj7dS/5YR/HamwUChw5/Q3bERgXDvtsIHunrIr8M=; b=OD6n0V1KYH74+4xT9PwS7CgB+rYzKrlBxT+xWLZiZlxbqMqfQV5zTk/VDoHXP2UDv47Nbg wSc4DXvekbRFqSKzfFtbd0olk2vRZmEsshl0B0/XpuF1Kvq4c6PPcNJMgdMkdWaMfPwhmY 4QPh+qwVtKOJi0cEJMZfDEZCb7xL2JpIATvVRtEJM+CNrwJjL1wjcRmDpwzevSCFKSf9kC vSFCNZYFH/R2C1zIljG+aFObwMWjrmghTw2wTVdxmtAlA0muf03SxRfG8wMX8XF0zFdJSF firr1gTQc/k0bWD3Kj8qzNoLH0av1p4jKbH3zXxRePAArglpBcMO5nx3+wMbHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700605340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZoVAj7dS/5YR/HamwUChw5/Q3bERgXDvtsIHunrIr8M=; b=A276vsnbxW2y8G39GYIEvMesjIwNbqGuTBkMQEuhrDyWLOun8uzbtvif0cZCt2Tc4XTnpP op/QqxSJfpoiNyVNB/L77v1yKo99BfndbpyaBiAarKRSJflJiJwVdipotEXE4Y2H0p7b5m diWXDK0s1mgyctI5ukUNVQ0F6I2NhKKdILgyyK+987G+cNJKWM+3CejzLelgbQfaOyiVy1 yWJeGvV55hzl72bHU0MkYEhpJuQnvWNaMk1wR0qUA7n+W21zPDEewWkP+HIKMTggrgaqLR welnQ26rg+m33B2z9dhjj1X4yRI9nNQTI97qT8xWMcWB8b1fAjRH8O2Ea4N+jQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1700605340; a=rsa-sha256; cv=none; b=JiB7LR6ToAm+LQKmdpiaqf1I0YOyVSkzp+SAs5F4qRmsJyHcuNj6z1H+FpV7/vwQYlQlzB LjHrWtPVviv/u3cs0w2Y+3Vv0fUeECkWMSATUeTrAzmkyEVmC458o8+/Pkoh2FY1YGUnDo 4hWQdq1xmdZoZxbLS82Roo7wIV4WhgsYCN6O7K7wIq/4Lb9IJ779du92K/H5NsTzDBpdtM rWhPC0xNYRKcXXqR8z+I6qSbPn4SYyUNSwz+Kj0Nibldm1l7OSnNURa1L0KKs6APnOXpvd D4pwUBjgovc1QSvuKaBlEnbG2JMj1OXfgAIyqZFy4xyI7d3oRMNN1tTW2oO8/Q== Received: from [IPV6:2601:648:8384:fd00:9c4:9ca2:ebcd:98c6] (unknown [IPv6:2601:648:8384:fd00:9c4:9ca2:ebcd:98c6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SZf4q6SqHz1SYl for ; Tue, 21 Nov 2023 22:22:19 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 21 Nov 2023 14:22:18 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i386: Use a fallback XSAVE layout for remote targets Content-Language: en-US From: John Baldwin To: gdb-patches@sourceware.org References: <20231121220931.48497-1-jhb@FreeBSD.org> In-Reply-To: <20231121220931.48497-1-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/21/23 2:09 PM, John Baldwin wrote: > If a target provides a target description including registers from the > XSAVE extended region, but does not provide an XSAVE layout, use a > fallback XSAVE layout based on the included registers. This fallback > layout matches GDB's behavior in earlier releases which assumes the > layout from Intel CPUs. > > This fallback layout is currently only used for remote targets since > native targets which support XSAVE provide an explicit layout derived > from CPUID. > > PR gdb/30912 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30912 This fixes the regression for me locally. It would perhaps be cleaner to isolate the regression to the remote target by moving the new logic in i386_gdbarch_init into remote::fetch_x86_xsave_layout. The one caveat of that is getting access to the right tdesc. I could perhaps change target::fetch_x86_xsave_layout to pass down the tdesc pointer (or maybe the gdbarch_info?). Alternatively it might be sufficient to just use target_current_description() as the tdesc in remote.c? It wasn't clear to me if the relevant tdesc in this case was always the same as target_current_description() (though I suspect it probably is). -- John Baldwin