From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 54428385DC17 for ; Mon, 20 Nov 2023 09:54:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 54428385DC17 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 54428385DC17 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700474098; cv=none; b=S+Qd/QsMGMLSzFwNrLldfnUPHaX9nZpq4owetnEBhFzbeTLbe7dMzymCZ+JVhyEtwUMp7kLxPQaKU5AIZ+/itJQLSb/U4lq62Z1hsdLe+FjcnkGxiwuYq2l4ynPIGmvGyTePHAnSGdduOtu43RqAudaVjRF44Gp74YsFZXRw/UY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700474098; c=relaxed/simple; bh=Jn9rZVV0OiWaQHMkY9savs0G0nB9IXKS2+q48yTXY40=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=BPbgQX7H3rUzrl/7zMnBObtkEQggpVJc12kiseTAQU77syUAoi78ZnsT7pl0pid7XS6TwFm1CAaD6Lk8sle4Ke8DY0STDmJSe46KghCkzUWpcc17Ld+Sx88FPJwMKiVXOV3gvdF5i8Z+ufqk78ZEgETF3INrCGfYREuCPLiMFIs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700474096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RQRK8UEgbfuMnUOjq7Y39d4ek/LT7zNMBLtwacGc4Jg=; b=CAHsY/AXv0z28XXBr1XESDVWUDwhdqiAJ6rozed9mXvR7XbdMvnNIkkZM80ib/fLPC9CJJ Jzfpo5Dyojm7WYME36DVfnHAdYMKPAeAxVnApPZkGdvHfElIeFjjtM5GmDWtPJVs9mNoqu IfDJYXTgNhxj5DaWFh1CxND1mY09PU8= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-384-Ix-jGNJrOY-PvIeLPvCCKA-1; Mon, 20 Nov 2023 04:54:54 -0500 X-MC-Unique: Ix-jGNJrOY-PvIeLPvCCKA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c8767e6074so15566901fa.0 for ; Mon, 20 Nov 2023 01:54:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700474092; x=1701078892; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RQRK8UEgbfuMnUOjq7Y39d4ek/LT7zNMBLtwacGc4Jg=; b=DIl8RDt5aaTB5jp40tr1i2IfPEq1EoGKeaTAd9ld9qk93S3RN/pejI1ARNUPy+O84N cVLQ7wmQFMcw9cjglXrDpa5p0DEW1tCzSr3iwLo/hrpZhf3SLZ8IpH2dreIutma6bkfq mHLysNIAB8YabhJT9pn440wyMxZrNSU2uq1IZXcP/CGjGRXq71kCA8jwk2cCukEFLqV2 OM5f4mDSKP4Tnvo2+TWAR9MzAJq/ro7XOmM08rZY2QytJwhXWSJTTes21HwqlDUca7Ah hM0OyW8QF1mF9rG5Bg4pHzXnRi/7sAu/pZ9bacdvxNZ5+3Q3NYy+R/L1U2MYOcrNx5fv pobQ== X-Gm-Message-State: AOJu0YxwBTfrm+s4sqgis8JvvSOG0DbtNR6mU2+BmuR9pDgXVENWj5Ne 7t+5H8ft1wlDfa+5r25hmSulcsVyPiwiT1H4dxfSQjH0jZ/VRXentM9ycHOPt/DC0a06zrAwSPE PF7DI/4XKqdnbFcOvcRNg4uulHa7gwg== X-Received: by 2002:ac2:51b5:0:b0:4fe:7e7f:1328 with SMTP id f21-20020ac251b5000000b004fe7e7f1328mr4891237lfk.16.1700474092788; Mon, 20 Nov 2023 01:54:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHn4hvGGW2bfASQdqG6GDVXuNGTkwaGsFLGl3RfjyZ5OHPZHbQKKNve3VR3KyHwZ6YZalAs2g== X-Received: by 2002:ac2:51b5:0:b0:4fe:7e7f:1328 with SMTP id f21-20020ac251b5000000b004fe7e7f1328mr4891227lfk.16.1700474092446; Mon, 20 Nov 2023 01:54:52 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id t11-20020a05600001cb00b0032de6f95fb3sm10657525wrx.40.2023.11.20.01.54.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Nov 2023 01:54:51 -0800 (PST) Message-ID: Date: Mon, 20 Nov 2023 10:54:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 0/2] Improving frame printing with recursive calls To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231107124150.116140-2-blarsen@redhat.com> <871qcola1j.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <871qcola1j.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17/11/2023 15:38, Tom Tromey wrote: >>>>>> "Guinevere" == Guinevere Larsen writes: > Guinevere> This started with the first patch, just fixing PR record/29178. However, > Guinevere> Kevin pointed out that I could reuse some of the local variables to make > Guinevere> the function as a whole simpler, which I did on patch 2. > Guinevere> My changes on v3 introduced a regression in a dwarf2 test. I gave some > Guinevere> time for people to comment on Kevin's solution (then forgot about this > Guinevere> patch), but since no one disagreed, this new version changes thetest, > Guinevere> rather than the code. > > These look reasonable to me. Thank you. > Approved-By: Tom Tromey > Thanks, I pushed these! -- Cheers, Guinevere Larsen She/Her/Hers