From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E13333858D34 for ; Thu, 2 Jul 2020 23:56:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E13333858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 621351EA7E; Thu, 2 Jul 2020 19:56:15 -0400 (EDT) Subject: Re: [PATCH 6/7] Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str From: Simon Marchi To: Jon Turney , gdb-patches@sourceware.org References: <20200701213225.14144-1-jon.turney@dronecode.org.uk> <20200701213225.14144-7-jon.turney@dronecode.org.uk> Message-ID: Date: Thu, 2 Jul 2020 19:56:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jul 2020 23:56:16 -0000 On 2020-07-02 7:53 p.m., Simon Marchi wrote: > On 2020-07-01 5:32 p.m., Jon Turney wrote: >> Move windows_core_xfer_shared_libraries() and windows_core_pid_to_str() >> to windows-tdep, use in amd64-windows-tdep.c to handle Cygwin x86_64 >> core dumps. > > As a convention, the _initialize function is always at the bottom of the file, > so I'd put the new functions in windows-tdep.c just above it. > > Were the functions copied as-is, or did you need to make changes to support 64-bits? > > Simon > Well, right after writing this I saw patch 7, "Add handling for 64-bit module addresses in Cygwin core dumps". Now you know that I read series in a very linear fashion :). So, I suppose that in this patch, the functions are copied as-is, and are not suitable yet for the 64-bit cores? Simon