From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18024 invoked by alias); 18 Jan 2019 08:33:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18014 invoked by uid 89); 18 Jan 2019 08:32:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=uniquely, H*c:iso-8859-2, pls X-HELO: mail.pl.sii.eu Received: from mail.pl.sii.eu (HELO mail.pl.sii.eu) (91.227.21.9) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Jan 2019 08:32:57 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.pl.sii.eu (Postfix) with ESMTP id E02C62D75; Fri, 18 Jan 2019 09:32:54 +0100 (CET) Received: from mail.pl.sii.eu ([127.0.0.1]) by localhost (mail.pl.sii.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t7blTybreZjh; Fri, 18 Jan 2019 09:32:54 +0100 (CET) Received: from PRDSWEX16W2.SIIPOLSKA.PL (PRDSWEX16W2.SIIPOLSKA.PL [10.254.15.206]) by mail.pl.sii.eu (Postfix) with ESMTPS id CC1DC2C69; Fri, 18 Jan 2019 09:32:54 +0100 (CET) Received: from PRDSWEX16W1.SIIPOLSKA.PL (10.254.15.205) by PRDSWEX16W2.SIIPOLSKA.PL (10.254.15.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1531.3; Fri, 18 Jan 2019 09:32:53 +0100 Received: from PRDSWEX16W1.SIIPOLSKA.PL ([fe80::3c9b:ace1:3462:3aae]) by PRDSWEX16W1.SIIPOLSKA.PL ([fe80::3c9b:ace1:3462:3aae%9]) with mapi id 15.01.1531.003; Fri, 18 Jan 2019 09:32:53 +0100 From: =?iso-8859-2?Q?Pawe=B3_W=F3dkowski?= To: Richard Bunt , "gdb-patches@sourceware.org" CC: nd Subject: Re: [PATCH v2 3/7] Fortran: Accessing fields of inherited types via fully qualified name. Date: Fri, 18 Jan 2019 08:33:00 -0000 Message-ID: References: <1542663530-140490-1-git-send-email-pwodkowski@pl.sii.eu> <1542663530-140490-3-git-send-email-pwodkowski@pl.sii.eu> <88ec6786-8834-7da2-207a-7392fd657e41@arm.com> <53cac622aea64147b2c1cd25feb16bdd@pl.sii.eu> <687ae24a-511f-1d32-025d-3c1e996a8e28@arm.com> <6a36a05571e94d01aafa6735e9f194ef@pl.sii.eu> Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019-01/txt/msg00420.txt.bz2 On 2019-01-16 12:11, Richard Bunt wrote: > I have no further comments on v2 and look forward to v3. >=20 > Many thanks, Great, I tough that this was forgotten ;) If you don't mind I will decouple this feature from unrelated patches=20 in this series. I will send v3 shortly. Pawel >=20 > Rich. >=20 > On 12/9/18 8:40 PM, Pawe=B3 W=F3dkowski wrote: >> On 06.12.2018 16:02, Richard Bunt wrote: >>> Hi Pawe=B3, >>> >>> I was testing with gfortran 7.3.0 and ifort 18.2. On the latter I obser= ve >>> 2 kfails relating to the missing extends in the ptype output. However, = this >>> is because I do not have patch 4 applied. I will take a closer look at = this >>> patch with ifort 18.2 since I can analyze the implementation in action. >>> >> >> Ok, will wait (perhaps Wednesday) with v3. Pls, let know if there is >> something more to change. >> >> btw, I have ifort 19.0.1.144 20181018 >> >> >>> On 12/4/18 9:05 PM, Pawe=B3 W=F3dkowski wrote: >>> >>>>>> +gdb_test "whatis wp_vla" "type =3D " >>> >>> A small nit while I'm here: >>> GDB tests needs to be uniquely identifiable, see https://sourceware.org= /gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique >>> >>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to brea= kpoint: ! After value assignment >>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: continue to brea= kpoint: ! Before vla allocation >>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp%point%c= oo >>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: ptype wp_vla(1)%= point%coo >>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp >>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point >>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp%point%coo >>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1) >>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%point >>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: p wp_vla(1)%poin= t%coo >>> 1 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp >>> 2 (gdb) PASS: gdb.fortran/oop-extend-type.exp: whatis wp_vla >>> >>> >> >> Thx for the link. I will fix this. >> >> Pawel >> >>> Many thanks, >>> >>> Rich. >>> >> >=20