From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23015 invoked by alias); 24 Jan 2018 16:57:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23005 invoked by uid 89); 24 Jan 2018 16:57:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,UNSUBSCRIBE_BODY autolearn=ham version=3.3.2 spammy=Keeping X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Jan 2018 16:57:34 +0000 Received: from ESESSHC010.ericsson.se (Unknown_Domain [153.88.183.48]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id CB.C0.27591.BFAB86A5; Wed, 24 Jan 2018 17:57:31 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.48) with Microsoft SMTP Server (TLS) id 14.3.352.0; Wed, 24 Jan 2018 17:57:30 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.62.3] (192.75.88.130) by DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.5; Wed, 24 Jan 2018 16:57:28 +0000 Subject: Re: [PATCH 10/15] Class regcache_readonly To: Yao Qi CC: GDB Patches References: <1512125286-29788-1-git-send-email-yao.qi@linaro.org> <1512125286-29788-11-git-send-email-yao.qi@linaro.org> From: Simon Marchi Message-ID: Date: Wed, 24 Jan 2018 16:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0501CA0084.namprd05.prod.outlook.com (2603:10b6:803:22::22) To DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d828dcbf-df32-48a9-c160-08d5634b8da7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;3:uLZFjGYrrB2j+4AEOMCEU8/epcPwRFq0s1WgujCWrXOlSQNVgYNoAiOoIMWkN1ILO3rBT+uXSnyPIH/O//Cd1VNDhlCLVqXtodz19+aVqd1C+Jz7a21hFzhQsXQw3iya9/9ipLlIf8/6SLGVLtmlB3S6d7DI2S7WSe9lDl3AkQpHpLRwdinsAwrbskbB3Nke4J88UBXF4C/FTCcK4lXxfBRU/IEtTS39vSgfG1cAGOBf2Lv8RsnlzutSfydNaQAK;25:NZ+0RvpNk+6Z81CdOSJ0F2B8OGa95I0B52EePNcwpU9RYOnaHlc7O331aPVBHHllQn4gqzlmqxLqJ6vLZu4RZvLoEt2XzaBy7ao4KdGQwjvc6x1DWVB4OWvH8aM0am1bdwj0iP0ucu+h39u9G8WrJoSvwaOrPrtIU/hW4o4Xzu3hAIZb6bT+iBPt2RrqU8jr0i40FqpCsHdXDSsMNfiZtIy9w6JEGygA4Z1pV6ia1dyQ0MmcrCPNl4j+c7r4KH6K4H+E9snOa/jKRPDLg3u/EThwWG7C6QyDdwjPJxnhBxweBiz+h/DXk1jfAAaQ/YB/PXNa68EYDT51nWdK0uLZCg==;31:hG6P/M/AFphp98F7Ncy5i9db63HnXlZOcogIf+INS3y6Ay6PtEGYIz/8G32jyFOErgG0X90y/61D2zzJZVsqfnntM1YTkqpwCHPKItcFokihKu7IwrlnuUb7tDGQ3+ZwIy5ViBLSiPaxsJMlVAhxVp7MH70791lQYc2F4tvVcMCSJgN3sATSQbnbHBa+TZkkG+W2kAptlPkA534Oe6QtIVHtVgKM9rPwH6PHsNUOFQo= X-MS-TrafficTypeDiagnostic: DBXPR07MB320: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;20:Jk4f3SUEXvA+60VpknQf5odfNN1gy8FOGBnQ9VbqiUQs4YUMhJUahtUIWGEhInkjaZkz/fiCGrML3urU8W0SCBhy3ps5p0Xdg+e3rxx1ktoivHXURTPUs27i+L4IQZKUulSxaDdXthQMpvdWq9ZTylEyFa2V5d6Obqc3r790EJqHKbz300b4elFOU91dP5IVEXPP49Z998sCcOD0SOTJt4v1s53BgJl42w5d9jYM0T4ZzaKE+ZScws0aYCHmjMrUL3XUyVMjxDRrG3Z8+HO4GK6Dc26kfQKlckNTShvVGZF3EEdZ72VvEu9FDiCjv+vhP82RHqyGNA2jsJEgZ2sZK2iiuVRgFQaMTq9cJIOVRj9s2pwOJ64haZtdTjnGGn2iZeQFUs+JIEmHNsLwIdoADCTkeVqF7skcRJdKKfpzvecS0oeG2YDQdo8mEQodiicTQdNHlVA1lGmXrA9lor0uYAM7PoMTfnOL/EvmZ410yatRpInqmZj4qaYVgKKBxcpk;4:ki1IhMIjA2K61xDAqWynv1DRPan+43o4LWohVDj1VDfEDZhx11kjec6EpvXROOlqIsER0LezdJjKbB3qkKeRh68sXlOS+Z9IkaZdRV4hsYQHhR1TIpVy2cxFr3HdzlSalA8M6raeJADqWPU7R9YVYDAu/yd5AYtzAxVW91TKLYDPSWGJccBzeTv3J0j1Yhv/D/QejQng+KUIxlNdLEpo482kHQE997MXTQeDrxi+6nG3O4gwHYvVPbuVlYcnvJmeXHP3YcShkwrRsqUiGW7guuGrRt+OectDaVY42yKqNNukaaLw05gyLUlgwZpFanRh X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231023)(2400081)(944501161)(6041288)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:DBXPR07MB320;BCL:0;PCL:0;RULEID:;SRVR:DBXPR07MB320; X-Forefront-PRVS: 056297E276 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(396003)(346002)(376002)(366004)(39380400002)(39860400002)(199004)(189003)(377424004)(39060400002)(2906002)(105586002)(1411001)(36756003)(478600001)(230700001)(3846002)(6486002)(83506002)(86362001)(93886005)(25786009)(229853002)(6116002)(6306002)(97736004)(4326008)(47776003)(66066001)(16576012)(58126008)(31686004)(316002)(65806001)(59450400001)(966005)(65956001)(68736007)(8936002)(53936002)(53546011)(386003)(49976009)(26005)(6916009)(2950100002)(5890100001)(6666003)(6246003)(5660300001)(23676004)(305945005)(16526018)(81156014)(8676002)(52146003)(52116002)(81166006)(7736002)(106356001)(2486003)(31696002)(76176011)(50466002)(64126003)(65826007)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB320;H:[142.133.62.3];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQlhQUjA3TUIzMjA7MjM6ekFZdndqVU9tR3ZlMkNCZSszeFlUOVFGK2Zk?= =?utf-8?B?djhBTWhoSjk0cXRrZXNPRVUxVjJlSVQ0SmFzV2RITVRoV2lLNFpqSGZGOXQ5?= =?utf-8?B?dDVOUkVwMDVWZkFmVWRRQzBVdmZwWDRsOXJPTW9RdC9jd2UxR0ZtQzgrejZN?= =?utf-8?B?TjFyMjRscmpXdzczSHJsamdlZkJNc2huQUJ1RjRZN2VvaG1rZXo4bVRpa0g5?= =?utf-8?B?TVhRNFJxQ0NIenByN1FJbzkxVUdSNmhTM0d5b2U3YjdiTy95MjQ3Q042cGZG?= =?utf-8?B?WUxzbnpEV1BrQkcwNXppTGJGbXY4d1pXZ1BZZU1rYlNYU2Rrc3Iva3cxZ2kr?= =?utf-8?B?eUsrRUpOdjN2ZFl6OGJMdWhZUDdScWFacytUMi9CelpFa21xb0NORWVlVTU2?= =?utf-8?B?UWtHVUV6b2VmRHVKUnpPbzVwN2pPNFVKY09ZTEFCczYrQTdVQzR4U0JUUVh0?= =?utf-8?B?bEpDRFB6eXhNUHU4Y2MzbDJiMEJGZThSakF3cWRjeXZkRzFhZnFyWFJ2dmkz?= =?utf-8?B?T2RmdXpzSVI2VWJDZm04akJralcxM2VqMzVZb2JFcHdYM0RpaUwySnBndlVh?= =?utf-8?B?SVVybGNwWjlSM0hnSFEvVmtkTDJGNHplRE9UV0llRHIyMHlPNnhwQU1xdE1L?= =?utf-8?B?MXBjOVIzUjJ6VWs3OFR3NG9KZkliNUtvOGVZZWVmaEhoekVUMFlZZEI5SWts?= =?utf-8?B?cnNWbFcrS1I4T1RwWXh5dnU3cXlkSzBTK2RSVjlQZSthdlNUdFM0dmxpRUFV?= =?utf-8?B?WkM5NkhzL28yaDNaSWx4ZVFkczVaTFNsZU1DZThJK1AvUllGTmV5Z29vRFdx?= =?utf-8?B?NlBuWVMxN0svSHpxdy9MeS9pckxXYVpneDF0K3FHSUpSMkh5Y3RZbkY2VWlI?= =?utf-8?B?M01Ub0x5YnFIN1ZZdi9uUHpqTnZ4MkU1bG5GZm1PV2p4VklZYzBraUh3Vi9s?= =?utf-8?B?S2syNW9pQi9sbFUyRmJBVnZJZVFIbUxTQVNwcmdRQ2psbGRtNGN5Sjg3L0d5?= =?utf-8?B?bjhSVU54OWQyK082NmcxbVlHY2hEVEl4S1p6ckZObkUzdUhHcDZkWkJYR3ov?= =?utf-8?B?bExCamV0aFJqRnNCb2szUjJiM2UrOXRFQWxzYy9Ta04vNEFuRkQvMjZzOWVP?= =?utf-8?B?eWpQUXFqRE5xN25hSk5GMHo5YklNMmdrRFM3U2FVRi9NbkR0SlEwN1FPMXRK?= =?utf-8?B?MUpFbWJBTVBYbm9XWFIyTDJEQ0k3SWtCc25HWHF0TERmUndXL3diT2h3TnBV?= =?utf-8?B?M3U1cXo5OVJOMnNPZk1iL1FabXlnU1lncHB4d2I1enRQS1ZGeG00SmVLUXJw?= =?utf-8?B?Y1dOcWVjbDVMeDhSSFFFa2VIbXNIMFphNVVobTI5em5xWmJYRXBNaGU5Wk5n?= =?utf-8?B?NzdHUmtsaTc1OTM1cU9QUkd6L1l1K1JVdmJjbWJFRHpFSlNlTW5VWUFBWG9j?= =?utf-8?B?WjFXWGMxV3NQMzFLQWRNNk91ZDE1VXdwWmNkUDdGdjhFaGNZdHRvbERLY0hk?= =?utf-8?B?M1NDRzNJMUN0Znc3YWF3M250bUtWUVZMMTlsdUpFRTRYdGxuVnRaSGRjMEJr?= =?utf-8?B?TmpoNjlIVEVNZXAvU3dLMzVXU2hHbkVSdlZKK3pwNjdSVytkY1RCREt5ZDhS?= =?utf-8?B?RWVMWS9hSW41amxUWldvUTQ0QWZTa1ZKZStGUFR6NTNSRjZjMEQ0dE9oQ0JB?= =?utf-8?B?eVBSdk85KytTQndzYTBsZ2R4dC9lQXFsbmhaenBvZ2hiSGk5UEI2VVlzdnkw?= =?utf-8?B?SFc4VFdjRGVCYXllMURuZVZsalZUaS9OMlNFVGZaNVNDWllRRS9tN1dTcmRn?= =?utf-8?B?N1RlMENHWWFVZFlsSDdPOW41WkhZMnJOQ0ltSTN4dTZram1mcm1PZEZDM0pi?= =?utf-8?B?aXRCSlhoV2U4R1hBQUhjTjlrOEgvTkQ3UHUrMk1rN0VZUm9xUnpBYlRNT0Vo?= =?utf-8?B?bHFNTWNnNWgwYkpISGVwWW9qTkF4STR5cmZDSHpaZDNXSGx3bHJvS2VwY1Mr?= =?utf-8?B?OWx2c1FOVjdaZXdJUVY3UkZNUHo2UlMybm1zdyswdDQraTFEZDBCa2creHFB?= =?utf-8?B?Zi9tekdWQ2VJWjNYb3EwOHFya2FBWlNVK3psRE16eDc2eHJLUTdtVGc4Vm13?= =?utf-8?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;6:UBdfoLAesi5oIHeXRy9dBfrbNOa+byDIMqGIW33KlHKy0k2cskzUNLL756QY5kDZrcZRZbUsU/JhMHe0ZE1dXohwS7WlzgjTyozKYAEKW1yVAba7EOrF0YbQP1sYvl8tIhYI6fbS8uj7j+NUUnPqIjk5DcPS9ngvnrEoDDylVx3Zv/4vktbwmrWBq30xxVYtM75yRMj+Dha5YxK3BgFN1Gnu6FNAUWPqxVKXz1tjylwjNPTeNkaJgkvdRDFFXIyyaa7bMoLpLZ+LU8XT0ByFuIyByCXMYjQdjDC/k2+gnruTUWxJHvG2o4ThXNIlJ88TVA5FgsTXk3ln7udG9fFM81721zX8c7eHvq8Aj9qUTMM=;5:oKNl8k+N/1mPnFoi5cRHS3uq+op9lV6VTXMyGSBBApKsopBNVS9Zb7by0hKmrA4TH1If+A8+gXGh9aW5ZEqHZrdgNbpCHta2bJKQwpA6/QGJ0jA6Lqabk6rR0nC9lUixLUZHP+XTowEsTwpkHQ7biSOWSqwxMvr/8GYMfw3g+lg=;24:EycWmfazd36xRFKsVZIMSx5SII1LZ/juAqIFD7F3jTgJrnUidZxAy/CAYYlqqnqHCTwfw/sgyi1gVSQqoBJHHt4ldrZxxo6NYeZDYmAz2Ig=;7:Eu+t3qbeDfP2vICxyUCxd7oaCFTWVsxBuQcjdJ/0UUBGsMpvOBzeJkNZo5IlUKXzqMo3120zqtgCXfG6bCQ/0CZ1nOj9oeTVBQOz9kq4YQaPtk+zrGLc9J5mQznIHal78f8E/jwokRn7eEeWAPuFL5vVFz+GfLfW3qwTQmyieao/xNrklNqHnFTOy6XvjYkHVfxxhjwCN5++HH47MARY7IttwswHUGP3vnGpX05779I6q0OkSBjacq+fXH3zlkHc SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2018 16:57:28.3227 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d828dcbf-df32-48a9-c160-08d5634b8da7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB320 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00481.txt.bz2 On 2018-01-24 04:42 AM, Yao Qi wrote: > On Wed, Jan 24, 2018 at 3:05 AM, Simon Marchi wrote: >> On 2017-12-01 05:48 AM, Yao Qi wrote: >>> This patch adds a new class (type) for readonly regcache, which is >>> created via regcache::save. regcache_readonly inherts from >>> regcache_read. >> >> Hi Yao, >> >> Just a note about the naming. IIUC, the important thing about this >> kind of regcache is that it's detached from any target. Did you >> think about naming it detached_regcache or something like that ? >> > > This kind of regcache is both detached and readonly. As I said in > https://sourceware.org/ml/gdb-patches/2017-07/msg00031.html, > detached and readonly are orthogonal in design. We have four > different kinds of regcache, > > - readony detached regcache, this is what "class regcache_readonly" > about. It has several uses, 1) record infcall state, 2) give a > regcache view to frame, > > - read-write detached regcache, this is what "class reg_buffer_rw" > about. It is used jit.c and record-full.c, where GDB keeps a detached > regcache, but can read and write to it. > > - read-write attached regcache, that is what "class regcache" about. It > is attached to target, read and write will go through target, > > - readonly attached regcache. It can be used for target 'core', but this > piece is not included in this series, > > so in this patch series, "readonly" implies "detached". > > The major motivation of this patch series is to differentiate these kinds > of regcache by different types, instead of by fields "m_readonly_p" or > "m_detached_p" in "class regcache". Just pitching some ideas, I don't think I understand the situation as well as you do. I assume we want to keep the "regcache" type to mean read/write and attached, since that's the most common use case. Keeping this will reduce the amount of changes needed throughout the code base. We can then qualify the other types based on how they differ from "read/write" and "attached". That would give us (in the same order as your list above): - readonly_detached_regcache - detached_regcache - regcache - readonly_regcache This would give a predictable naming, and makes it maybe easier to know what to expect from each type. The graph you used in message 0/15 would become: reg_buffer ^ | ------+----- ^ | readable_regcache (abstract) ^ | ------+------ ^ ^ | | detached_regcache readonly_detached_regcache ^ | regcache Simon