From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2074.outbound.protection.outlook.com [40.107.115.74]) by sourceware.org (Postfix) with ESMTPS id 6E0283858D37 for ; Thu, 2 Mar 2023 21:03:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E0283858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GKr0vAVaHSneFJNeswTJ22y/Si57zkbO+dQQW0dnGbako++lCfuQfHE0Gmu9wPTnaBYt9dw5LxdnLVqM5qxHUQKnLg+trhXRRAZvJJRp04JMjVjS/NAWz8+ay5ns7bVxFjjV29dEhquBGyj5QrgvBTkEIceBDfcCMN9sBLpfj10jWEaIxjNHh3H1fzdHKMpgCy13Bu38xRS4YrBu+MMWq4F6ys+Zuzvl6r8p1ABnJSYOExKcZSAIQBBMg1FM3SSUaMQD/RVHPsTOiw22Ts7jCTPJ9iD7FmipP5IiR4bkyu4kFWMxV8vtO/oDkFKp2ikOnfj/yBuDw6uh5S63AuGEoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+lCmE/YRsY+8vd/rtr/XR9EovGnE7oCb6+DwW/lf/m0=; b=irMGAsmPqVgfyNTzrm5YL0IGIQZivBafh9CCYRCtPE8kD+tLzYlDzcylaJinO6Ree7ne4FEmMH5T9LVgZkxH7CjMnmDgN1eb+irduN/KlS6hO29QQ/UxMNlgPjBwU7RKrGdTelQAIOTsoVDZW5NZ5dFjZoZwuuGW1ipDCXYkADaVzAoDgO2Tus+aH4Rs2AsYx+p43om+zJd9mAUD9CnDjDty0x9/iGgUQ7H2vPU7vVBrGiT1ZGlD1g/563bnkMWwHOz9sDC67gWCwgvHbnl2ARTfUQmRtDLD+mTzGVjQ/w6FUJ6r+pz7MQgqM7mzRXVfnz1czFfW0H9aowu5GhvHAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lCmE/YRsY+8vd/rtr/XR9EovGnE7oCb6+DwW/lf/m0=; b=eJpYelm7FWd4oMAzdkEVpLu+0Ft0Dg3eE1XukshXnBs0EtrDIAlvgSQPGHcqdCjcPhdRmgzcboMVpV0G99wCe4euHlOzc5WIGeeeh1V5VXZ8UG9zRFaZarmXS8kANI2z/JwBd3sooyNDv8z1rkHtIPIgifFc+LXWxD08VfhC4flEnQmRKp+2BNOsSOgYnnGH5LPR9UuBGedY0O9L0JWzU7sNE2zQFHx7jzhWhyRxbFEPEJOfZZhqkTGEOpZTgM7enS2IM8i2qQS22s9I5aXd4YYVia43rS7wcs7X4wOEGBcaSrYaZvrT2tnFK8nOrLjjhOk68ua7QILKw0tsxPJsxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YQBPR0101MB5582.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:41::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.18; Thu, 2 Mar 2023 21:03:14 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2e20:aebe:9849:7408]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2e20:aebe:9849:7408%5]) with mapi id 15.20.6156.019; Thu, 2 Mar 2023 21:03:14 +0000 Message-ID: Date: Thu, 2 Mar 2023 16:03:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] gdb: fix -Wmaybe-uninitialized warning in value.c Content-Language: fr To: Tom Tromey , Simon Marchi via Gdb-patches References: <20230302202655.117124-1-simon.marchi@efficios.com> <874jr2c1h4.fsf@tromey.com> From: Simon Marchi In-Reply-To: <874jr2c1h4.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: QB1P288CA0015.CANP288.PROD.OUTLOOK.COM (2603:10b6:c00:2d::28) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YQBPR0101MB5582:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ce903a2-63c5-4947-7b8e-08db1b6189d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 44sZ2yR/R8YGsfqk/K7krQ2K6MYLhV1xZhFBQYb4fAWIBCdCZmIeC4kFVRxd1vnxepriw7jZwxvkXb/ZdCcSG5w6pfgvsKX81X+jpkcnfwSGZcnVmOv3DgNOgkly1xwW44Ca0TybFV7eXsqvnMeSrkcHDEKRBNR3YIn0Rxmz2AsVtxeZIVUy0Nwj3sARU2eRC9aWAd0XRk7z5rcb1merkuCkBRlpG+65P7xcQMWEwv8uCdN/9lMfcx9/Jr0tfsFCfQq2k0v4py73jrMtWGxE2fJZLGLJEfygjLDSmUFrEcS6ehncC+y9/G8u9NhQCN1h4mV4ivE9+8JoIW/MFxRls+H4x191DUgxTWL4jjAjHqlY59Qm/oKOs0rnjKxchm85TFpyXto7OxvyyegsFLAXr9zvGIfxVjHuNdK4CtVLNq5t28P1Ft1BzG6zLMyMLCCpXHgV/ucowYfz7LreJKTABvaE8tYZZ4r+BawMX7zUZ5wl+uZNLKWFykwZPsb4I2tO5Afus1dk0KkBzaECSXilNfv31x/LCwPvdaq0ft17SXdSvDsg+oY5leVGAKFog+7HsEMTXzK78CVXxd9/r4JYIgKgDL0hsVHtnd0de10TM3NWleYl60zKrZP6apl01X8Tpt0mw5ch8DWn2+dlY8V4ItomwHh4K5BVh/QJVns1xisA41sdqZ/tVZai4V7MU6b5nhUUahMNkqJ9ygZR//X4J5RWDsq2kpUjJlgnaW5GSGI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(39830400003)(396003)(366004)(376002)(346002)(136003)(451199018)(38100700002)(31696002)(36756003)(66946007)(41300700001)(66476007)(4744005)(2906002)(66556008)(8936002)(8676002)(5660300002)(44832011)(2616005)(53546011)(6506007)(6512007)(186003)(26005)(83380400001)(110136005)(478600001)(316002)(31686004)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHdvQU5OMWc3bTFnT05SNURueldML3RCbm9wZFdRajU2VEZDSmFNYzg4MzNH?= =?utf-8?B?T1ZQWnlXOXZTUG8xU0k2eHNWeHFNaEVpS3VBaXgwVWVpWUhqc3dzVStyaFdy?= =?utf-8?B?MjAwSUhTVmZESURVVXBVUWNEYndmcTJSMjl0VUUxMmJjbjJaSi8xbGl4WUtS?= =?utf-8?B?RWo0RnJmMDV0djZHWVdEc3huZ2lxc1g0YWgvTEw0aURhOUg4aU5FZ3BVREhW?= =?utf-8?B?V21BajdVTEF3OWgyVytuY0h0SWt5U211ajhJb1JRQmJ0Z1FKLzQvazErTExF?= =?utf-8?B?NmR5N3NzNmc3WWVLZERFb0o0bGttSFlMQW9LZjIxdklCMi9sNkZZb3luWUgr?= =?utf-8?B?dGF5d0VPbm9tODQ4c1JRVHloQTJYdEdmQTZSa1ovTXo4cWNRQU0vdVJyUjhV?= =?utf-8?B?ZC9mU2l4ZEo5Vmd0aTg0Y2hvaFErUjNlWTV2ZmJOajFzWGRLaGNVNlcvbmtZ?= =?utf-8?B?b3RkUlQwQWhNWlI2YkZUalRvMlFwNU5sSkExeldpdGZVMTY0NDNoNSsvQkV5?= =?utf-8?B?bE1heWJsYTkwU1hiRkZmci9md0JDdG9TeTgvL1oxREczMmZyRm5PUVN2aGRM?= =?utf-8?B?aEx3Wnp0NHhqTThIQjV4WVFQUWREbXR0OVZEYndyVFhkVFU4dkJvRlZvdnM1?= =?utf-8?B?dDcrMFZiNUhCWnhJd2hlK3dvdG9Rc0F1YjJvN1FPcUVUN2Z1dElxY2tBWFpL?= =?utf-8?B?eTV1K2NFZzJHaTJiZ2xqd3lDOU5iZzN1QnlSaVZFNzRTckcrT1J5RENnVS9a?= =?utf-8?B?VFM4eXR3SWtGTzR2MEttN2FoL1Y2SkZReVZzcTByQkVhNmNBOC94UGpNeUls?= =?utf-8?B?dXZsenIwWFhrNmE2a0ZDVTZOMUFNaEI4WXUrRXhNeHNTUHVacUtRTEtTZWNz?= =?utf-8?B?V2FXbVhuRlpjaE1vSlZ0ZlMya0VkTlFnODhzd1BkMk9acnBmSlV1MGxoY0RM?= =?utf-8?B?Q2k0ZWJZVjBKMFNsTTEyK0NSUitJVFZZbytIb0FONm9jSFBRaWZIMXhKTVNn?= =?utf-8?B?MDNxTWJBZjhjbkRLZ3dKTW9MaWVOOFMreDVINVlxQzB2Tm8xM3kvWW1lRlZY?= =?utf-8?B?bHplRnFRVFJCRmk0bTArZys4WjgzeUVjcy9PWk1aNE5wMDhaWkhpMlFkVXJP?= =?utf-8?B?K0VmdGptbDZtTVFVRlRRa1VlVjc0c1paQXEvdll5eUw3ZzROeEZXSlRSR1hW?= =?utf-8?B?RWdZd3lDMVhlQlh1VXNZeXNuVjdmSmJRdU0wMExGc1B1OGQvMEVwcEd1My9p?= =?utf-8?B?ekkrbk9zMU9CcitiekJhbExmRFQ5a2haSU5oMGQwd3VOMFc5L3RBNTdQdW50?= =?utf-8?B?dmRCUjFva3NzM3B5UHJGaU50SjJQL1MvR0N2bkRoOGhvMXAxUU9OVk5xOUFn?= =?utf-8?B?aDVPc0VxN2NZWmhta1Jsb1VSeGZjSUxqbFY0SmVOb0ZZeTlZTHF0NHFIUFZt?= =?utf-8?B?QWdEWHUxanpnNk53MHdoWFNlb2xZSnZxZ1pWY3dQVFBRa0RRYUJpdlgzL0ZE?= =?utf-8?B?eDgwbE53WEphNXUrWlQ1ZDFFS0pta21ZNitmNDhJa0lFRmR2ZEVKNlRETmsz?= =?utf-8?B?QlNwRE81ck5HZjdvRllULzc0eU5hamp0R3NzMFhaazdSc1N2cVpUYnhtNzlB?= =?utf-8?B?alFiZjN5ZkdXZy9idktFK3NaOElKQ09PLzU3b05GWmdpT082cUVhb21SVE9N?= =?utf-8?B?enFESGZtUmxUOC9kTUlhMDg1bzBjZ04wNlJpeCtwRzgvcUVrUGpjUkdvOS8w?= =?utf-8?B?Vmt5RkhtNExsc3dyZjc4WG5lcWpHTTRyTUI0S0xJY29ldlQ5V0lndVFWWW93?= =?utf-8?B?czJCYnVzWXFIL041ODlpMkhnL2o3bGZ4QTZka0JTOElpdHAvSkw4aUt1enRF?= =?utf-8?B?V0VtM2xKOXpyRlNaZXRCemphdVBRQmZILzlIcml4MUFBanJXdFZJaEU3QldD?= =?utf-8?B?V29WdE9zOHJTRWxuV3NLYXNmQWFXYW1PZWxHd1BvTVhwL1lRdi9WenEwSTVw?= =?utf-8?B?Ni9jV0FzbXBWbXNZME1wRlNmb3EvTFN5OVJ2aFdFbHpkTHhTYkZGeFJqUTlC?= =?utf-8?B?MkE4NUV2enVQNTBqeGFvbmpNck5kVzU5SEsyd1FTZmFkUHZuYkJuaUxlVjRK?= =?utf-8?B?bmppNXpvUGd3UGNpQ1VMRlRsbHN4ZmorZXFqY0l2dVZQQVY0WC8rSzRFRWxD?= =?utf-8?B?R3c9PQ==?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ce903a2-63c5-4947-7b8e-08db1b6189d2 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2023 21:03:14.2669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wpkARYpbvnv/UdVcYR7ClnUBz6SS7f2FlN8kULsEMOl1fuXyhsdk6w6FwY4kibAxvNHsSVGANwYAB0IjeJ/dRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB5582 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/2/23 16:00, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> This is because the union field internalvar::u is not initialized when > Simon> constructing the temporary internalvar object above. That object is then used > Simon> for move-construction, and the (implicit) move constructor copies the > Simon> uninitialized bytes of field u over from the temporary object to the new > Simon> internalvar object. The compiler therefore complains that we use uninitialized > Simon> bytes. I don't think it's really a problem, because the internalvar object is > Simon> in the `kind == INTERNALVAR_VOID` state, in which the contents of the union is > Simon> irrelevant. Still, mute the warning by default-initializing the union. > > Seems fine to me. > Reviewed-By: Tom Tromey > > Tom Pushed, thanks. Simon