From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1CF3A39BDC16 for ; Fri, 11 Jun 2021 16:35:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1CF3A39BDC16 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-Pv4PucvRO3COfQLRwf7a3Q-1; Fri, 11 Jun 2021 12:35:50 -0400 X-MC-Unique: Pv4PucvRO3COfQLRwf7a3Q-1 Received: by mail-qk1-f199.google.com with SMTP id v16-20020ae9e3100000b02903aafadba721so7379275qkf.6 for ; Fri, 11 Jun 2021 09:35:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:from:organization:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=QIuqJ/dbbo6+4cho7xuCVIBgu7Elolc6lOzGzFsfyT8=; b=fw72uN+uwpnfaTwseWpbE5KB56eapi2Vrdtx8WP/Up6+H056Nb1ufkygY+XkYPS2ui 5/FVE6O7CUvemgSpN3cQbSvW81togZpMbmSXiXIq8BaWH6kAg5Qef/jpFOlhFIOfqcOR XaqxW76+LCqGZowHy4z2H5prJ+hPjLO8vvIDzeycn5tXpWCHSjoSRj8kQqE2P2zlR5oV mSkittJ+Por/g/S2wGU3Z/YLwEhZf2XsC/XLMvp6+YaOLrBjpCsJ4iE8GqekrLxAjFHx X/SZuQXjb5uMpgg+yMZtcu+AgnH5fqkklmGUDCT90efvqVjXDCNb16mY6oX9s6Nktyqk 6c9g== X-Gm-Message-State: AOAM530eVFOJBm0WSMHN+Qdpo/G7Sbq2zt4pclY3S1Q3V1Q32sGX/DxS p5XM2WcYa7BNBU5iifwYDlCCk2MjLwVTUNLp+82vSVWES8dh4mNabt86MLXMktgn+g8DGrI9fXP +AgwLs1SjhpV8jJ61bolqH34jWx5gGvk65pAir63WYEPkpkBaVLZabr64tiQ+C8RC8T4X59A= X-Received: by 2002:a05:6214:1021:: with SMTP id k1mr5794782qvr.4.1623429349611; Fri, 11 Jun 2021 09:35:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymYw2XtGnQ00ra0rql2jz8DKCoDYE/ceNryHgalwG/8psbSzmaPJdmUOi6Gxi9j0DFHckeLA== X-Received: by 2002:a05:6214:1021:: with SMTP id k1mr5794771qvr.4.1623429349409; Fri, 11 Jun 2021 09:35:49 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id x15sm4790838qkh.19.2021.06.11.09.35.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 09:35:48 -0700 (PDT) To: kevinb@redhat.com, "gdb-patches@sourceware.org" Subject: Re: [PATCH 4/4] mi-sym-info.exp: Increase timeout for 114-symbol-info-functions From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Fri, 11 Jun 2021 12:35:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 1 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FAKE_REPLY_A1, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 16:35:55 -0000 > Loading libc.so's symbols increased the amount of time needed for > 114-symbol-info-function to fetch symbols, causing a timeout during my > testing. I enclosed the entire block with a "with_timeout_factor 4", > which fixes the problem for me. (Using 2 also fixed it for me, but it > might not be enough when running this test on slower machines.) Looks good to me. Tested on x86_64 Fedora Rawhide with new glibc. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-sym-info.exp (114-symbol-info-function test): Increase > timeout. > --- > gdb/testsuite/gdb.mi/mi-sym-info.exp | 56 ++++++++++++++-------------- > 1 file changed, 29 insertions(+), 27 deletions(-) > > diff --git a/gdb/testsuite/gdb.mi/mi-sym-info.exp b/gdb/testsuite/gdb.mi/mi-sym-info.exp > index 18f85182a7b..dcd6f7d9187 100644 > --- a/gdb/testsuite/gdb.mi/mi-sym-info.exp > +++ b/gdb/testsuite/gdb.mi/mi-sym-info.exp > @@ -123,33 +123,35 @@ gdb_test_multiple $cmd $testname -prompt "${mi_gdb_prompt}$" { > # (from the symbol table). There's often so much output output from > # this command that we overflow expect's buffers, avoid this by > # fetching the output piece by piece. > -set testname "List all functions" > -set cmd "114-symbol-info-functions --include-nondebug" > -set state 0 > -gdb_test_multiple $cmd ${testname} -prompt "${mi_gdb_prompt}$" { > - -re "114\\^done,symbols=\{" { > - if { $state == 0 } { set state 1 } > - exp_continue > - } > - -re "debug=\\\[${symtab_re}" { > - if { $state == 1 } { set state 2 } > - exp_continue > - } > - -re ",${symtab_re}" { > - exp_continue > - } > - -re "\\\],nondebug=\\\[" { > - if { $state == 2 } { set state 3 } > - exp_continue > - } > - -re "\{address=${qstr},name=${qstr}\}," { > - exp_continue > - } > - -re "\{address=${qstr},name=${qstr}\}\\\]\}\r\n${mi_gdb_prompt}$" { > - if { $state == 3 } { > - pass $gdb_test_name > - } else { > - fail $gdb_test_name > +with_timeout_factor 4 { > + set testname "List all functions" > + set cmd "114-symbol-info-functions --include-nondebug" > + set state 0 > + gdb_test_multiple $cmd ${testname} -prompt "${mi_gdb_prompt}$" { > + -re "114\\^done,symbols=\{" { > + if { $state == 0 } { set state 1 } > + exp_continue > + } > + -re "debug=\\\[${symtab_re}" { > + if { $state == 1 } { set state 2 } > + exp_continue > + } > + -re ",${symtab_re}" { > + exp_continue > + } > + -re "\\\],nondebug=\\\[" { > + if { $state == 2 } { set state 3 } > + exp_continue > + } > + -re "\{address=${qstr},name=${qstr}\}," { > + exp_continue > + } > + -re "\{address=${qstr},name=${qstr}\}\\\]\}\r\n${mi_gdb_prompt}$" { > + if { $state == 3 } { > + pass $gdb_test_name > + } else { > + fail $gdb_test_name > + } OK. Confirmed this is the same code just indented with a higher timeout factor. > } > } > } > -- > 2.31.1 -- Cheers, Carlos.