From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id C12B03858D38 for ; Mon, 11 Mar 2024 10:14:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C12B03858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C12B03858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710152072; cv=none; b=a7SCr1qHALOW0f6/iGDWGaImRgZXtyVSccU9iQuqGsZI7Hh0GX71W2LQdUuROIlFZhWDMu/2VE1fFcxiiUgjKtrAtFvVXtXE/+Y06EklCEFjhMSQVJaMJdVRF2h7zBJ3rt2D4sOAq0CXN+hWJ2uhdLkEDDy6g2hKdpUPjMHqa4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710152072; c=relaxed/simple; bh=qatM9TSXBNBgh35aVRlxEVhnKZ/5Evd7c+7SVICSsMY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=SOiEaZ0W/9CF02pgn9mnL/D9EGdwhGNYhIyY5Dp7S1OhCK3nWY9mqFmGRRsmPv0+lkPeoEXzPCLQQRC+RpaitF1nv4FGKhNKrNsN6mHlTFabQqwViDE+Q1006KVIykP2bljOUQ/cpUgMp4SbMv5Oh5XILDya+Rhh0omj3Bq3dcE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B7E7134AED; Mon, 11 Mar 2024 10:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710152069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u2bOWGyf0MQmbJX5yO6a1adaCMqsfZmT9rtVEyxWb/A=; b=w0s7ffolwGiYWdG8TCjprFw/agq0/wml0+aXD58jqnO0KtGCF2UjcjdWHXe6Hvbb364agK XZcfqdgWVcqGflHU4kSHNG57Zt/PxrcYmYVlkZ5AXLSbNcHlyt76rNGByHybbjHV0OL/ks zxjlGsiPQVDHPfbZilSiQ40pEq1RAnM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710152069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u2bOWGyf0MQmbJX5yO6a1adaCMqsfZmT9rtVEyxWb/A=; b=yb4VxuniYgzHMEMKxryTD+HKaRzPT94jxdj8WU59ZWr+hOB4t3C83dPsLz5/8+tg7vRxoW p+kT2XpBVo0hoIAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710152069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u2bOWGyf0MQmbJX5yO6a1adaCMqsfZmT9rtVEyxWb/A=; b=w0s7ffolwGiYWdG8TCjprFw/agq0/wml0+aXD58jqnO0KtGCF2UjcjdWHXe6Hvbb364agK XZcfqdgWVcqGflHU4kSHNG57Zt/PxrcYmYVlkZ5AXLSbNcHlyt76rNGByHybbjHV0OL/ks zxjlGsiPQVDHPfbZilSiQ40pEq1RAnM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710152069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u2bOWGyf0MQmbJX5yO6a1adaCMqsfZmT9rtVEyxWb/A=; b=yb4VxuniYgzHMEMKxryTD+HKaRzPT94jxdj8WU59ZWr+hOB4t3C83dPsLz5/8+tg7vRxoW p+kT2XpBVo0hoIAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9D323136BA; Mon, 11 Mar 2024 10:14:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id E/q6JIXZ7mXsFQAAD6G6ig (envelope-from ); Mon, 11 Mar 2024 10:14:29 +0000 Message-ID: Date: Mon, 11 Mar 2024 11:15:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/6] gdb/testsuite: Add kfail in gdb.threads/threadcrash.exp on 32-bit arm targets Content-Language: en-US To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org References: <20240308093342.26745-1-tdevries@suse.de> <20240308093342.26745-7-tdevries@suse.de> <7bee9f96-d421-4d5e-b1ac-6f603bdff516@suse.de> <87plw4ff9m.fsf@linaro.org> From: Tom de Vries In-Reply-To: <87plw4ff9m.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=w0s7ffol; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=yb4Vxuni X-Spamd-Result: default: False [-3.30 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_GOOD(-0.10)[text/plain]; URIBL_BLOCKED(0.00)[suse.de:email,suse.de:dkim,linaro.org:url]; BAYES_HAM(-3.00)[100.00%]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,linaro.org:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: -3.30 X-Rspamd-Queue-Id: B7E7134AED X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/9/24 00:57, Thiago Jung Bauermann wrote: > > Hello Tom, > > Thank you for this series! > > Tom de Vries writes: > >> On 3/8/24 10:33, Tom de Vries wrote: >>> + if { $have_kfail } { >>> + kfail $test >>> + } else { >> >> This needs and additional fixup: >> ... >> diff --git a/gdb/testsuite/gdb.threads/threadcrash.exp >> b/gdb/testsuite/gdb.threads/threadcrash.exp >> index 7839f5c358e..3679cdc69fa 100644 >> --- a/gdb/testsuite/gdb.threads/threadcrash.exp >> +++ b/gdb/testsuite/gdb.threads/threadcrash.exp >> @@ -123,7 +123,8 @@ proc do_full_test { phase } { >> } else { >> set have_kfail [expr [string equal $phase gcore] && [is_aarch32_target]] >> if { $have_kfail } { >> - kfail $test >> + kfail corefiles/31294 $test >> + return >> } else { >> fail $test >> } >> ... >> >> Thiago, you mentioned you could reproduce the problem, can you check whether this catches >> it? > > I applied the patch series plus the fixup above to upstream commit > 2755241d02d7 ("Add return value to DAP scope"), and I actually can't > reproduce the problem anymore, not sure why. The threads' backtraces > look reasonable. The only "??" are in linux/arm/clone.S:74 from > libc.so.6. > > I put the gdb.log here, if there's interest: > > https://people.linaro.org/~thiago.bauermann/gdb-pr-31294/gdb.log Hi Thiago, thanks for checking. Ideally, we need to either: - confirm that the problem still exists, and test and commit the kfail, or - confirm that the problem doesn't exist, drop the kfail patch and close the PR. So, can you try to confirm one or the other, f.i. going back to an earlier commit where you were able to reproduce the problem, running in a loop, try with/without debug info, etc. AFAIU, you're the only one who can do this because the behaviour hasn't been spotted outside linaro. If it turns out that we can't confirm either existence or non-existence, I suppose we'll have to drop the kfail patch, leave the PR open and wait for it to appear again. I went ahead and committed the series apart from this patch, which reflects that situation. Thanks, - Tom