From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110412 invoked by alias); 13 Dec 2019 21:11:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110402 invoked by uid 89); 13 Dec 2019 21:11:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:362 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 21:11:07 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id xBDLB0lx018361 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Dec 2019 16:11:05 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca xBDLB0lx018361 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1576271465; bh=YWwhInD6hQr6ZElQPvPP4s09D8TX/4CNiite+Cy0aK0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Z6vkqlFSoYaPQlMScdrYzTQQ0W77qV2jHHcj0d15TUraOIrndauKIEx4jGkdMbAeC l6ub1sJmXseXpQxSeiGVVcFdgsCNtxFIqV6Keuy2+9S4c6IdldwCB5PYt7TbTg3Mk6 xD7yIxVJmqeM4+fvXJiyVJ7gMyrqo+EOnHo026Ac= Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 09FE11E573; Fri, 13 Dec 2019 16:11:00 -0500 (EST) Subject: Re: [PATCH 3/7] jit: c++-ify gdb_symtab To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20191213060323.1799590-1-simon.marchi@polymtl.ca> <20191213060323.1799590-4-simon.marchi@polymtl.ca> <87zhfwuehb.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Fri, 13 Dec 2019 21:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <87zhfwuehb.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00614.txt.bz2 On 2019-12-13 4:01 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> + gdb_symtab (const char *file_name) > Simon> + : file_name (file_name != nullptr ? file_name : "") > Simon> + {} > > This should probably be "explicit". Good point, I made this change locally. Simon