From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by sourceware.org (Postfix) with ESMTPS id 17F263858403 for ; Wed, 2 Mar 2022 19:10:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 17F263858403 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f45.google.com with SMTP id a5-20020a05600c224500b003832be89f25so1894668wmm.2 for ; Wed, 02 Mar 2022 11:10:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=kcAazoJ1P1ltZ5bMfW5xhlQDnYC7e/2FLJZ4FDTb9DQ=; b=NFQbso2PAARkPqy9YuNMuCD09Mm2VcMxvF3GgmWOeKyiUopl6D8IbioQj4O9/Ht7mZ tQx9Ds4XoMYjHsJCTOwCoyWwhhJr4i2cKBP30ZFGZkEs9tXuMKbzjP0o+dhk4sh7SOFa 9nL/FlJuwMTSTrIrT0NrQfMaSzDkehQcqmckvkh6+OiuquO4zEIEit9UUTjO1hJJ2UXb ZQIGtaHzbRNVKsQqkelh2PGfpy+8j/7KdAcXTvy8xMuM6PEp+fQhh582VbHmaIwixIPM QO4iZuYqV7DFTGNCGrSyIdVAdJ7QhEQWnVuicsJqpjFKX1X5YM9/Rlc6VK6HYokHuqbm rgJw== X-Gm-Message-State: AOAM533sEWtaXuEZZwC7OAwEYW2h3VbQ6NFXTWnQLLXIfFVoeT0o5BDg rbJIq2lNXFOz3yduNeey67M= X-Google-Smtp-Source: ABdhPJwXTG7Bg6Kw5IcekeonfKjOOvlIDS0jb4X2O7/lZRqRMYerkO5JAebQK2Tth+YvOgh9CypS7A== X-Received: by 2002:a1c:c907:0:b0:37b:f983:5d4e with SMTP id f7-20020a1cc907000000b0037bf9835d4emr1039441wmb.174.1646248225965; Wed, 02 Mar 2022 11:10:25 -0800 (PST) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id d8-20020a056000114800b001f045f3435asm3125221wrx.108.2022.03.02.11.10.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Mar 2022 11:10:24 -0800 (PST) Message-ID: Date: Wed, 2 Mar 2022 19:10:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 08/11] add xfails to gdb.base/complex-parts.exp when testing with clang Content-Language: en-US To: Bruno Larsen , gdb-patches@sourceware.org References: <20220126195053.69559-1-blarsen@redhat.com> <20220126195053.69559-9-blarsen@redhat.com> From: Pedro Alves In-Reply-To: <20220126195053.69559-9-blarsen@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 19:10:28 -0000 On 2022-01-26 19:50, Bruno Larsen via Gdb-patches wrote: > clang doesn't add encoding to the name of complex variables, only says > that the type name is complex, making the relevant tests fail. > This patch adds the xfails to the tests that expect the variable name to > include it. > --- > gdb/testsuite/gdb.base/complex-parts.exp | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/complex-parts.exp b/gdb/testsuite/gdb.base/complex-parts.exp > index e67fd482268..b4bb542f218 100644 > --- a/gdb/testsuite/gdb.base/complex-parts.exp > +++ b/gdb/testsuite/gdb.base/complex-parts.exp > @@ -30,8 +30,13 @@ gdb_test "p z1" " = 1.5 \\+ 4.5i" > gdb_test "p z2" " = 2.5 \\+ -5.5i" > gdb_test "p z3" " = 3.5 \\+ 6.5i" > > +# The following 3 tests are boken for clang. boken -> broken clang -> Clang (uppercase) > +# More info on https://github.com/llvm/llvm-project/issues/52996 on -> at Period at end of sentence. OK with these tweaks. Thanks, Pedro Alves > +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* } > gdb_test "ptype z1" " = complex double" > +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* } > gdb_test "ptype z2" " = complex float" > +if {[test_compiler_info clang-*-*]} { setup_xfail *-*-* } > gdb_test "ptype z3" " = complex long double" > > with_test_prefix "double imaginary" {