From: Tom de Vries <tdevries@suse.de>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: [PATCH, TEST REQUEST][gdb/testsuite] Fix ERROR in gdb.ctf/funcreturn.exp
Date: Fri, 20 May 2022 12:10:15 +0200 [thread overview]
Message-ID: <ec59dd30-027d-3651-2540-471cab60b162@suse.de> (raw)
In-Reply-To: <20220519123445.2756177-1-pedro@palves.net>
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
[ Re: [PATCH 0/2] gdb: Fix DUPLICATE and PATH regressions throughout ]
On 5/19/22 14:34, Pedro Alves wrote:
> Patch #1 adds "gdb_test -nopass" as mentioned here:
>
> https://sourceware.org/pipermail/gdb-patches/2022-May/189189.html
>
> Patch #2 fixes DUPLICATE/PATH regressions throughout.
>
Related fix in gdb.ctf.
Can somebody with working ctf setup test this for me?
Thanks,
- Tom
[-- Attachment #2: 0001-gdb-testsuite-Fix-ERROR-in-gdb.ctf-funcreturn.exp.patch --]
[-- Type: text/x-patch, Size: 2320 bytes --]
[gdb/testsuite] Fix ERROR in gdb.ctf/funcreturn.exp
On openSUSE Tumbleweed (with gcc-12, enabling ctf tests) I run into:
...
ERROR: tcl error sourcing src/gdb/testsuite/gdb.ctf/funcreturn.exp.
ERROR: tcl error code NONE
ERROR: Unexpected arguments: \
{print v_double_func} \
{[0-9]+ = {double \(\)} 0x[0-9a-z]+.*} \
{print double function} \
}
...
The problem is a curly brace as fourth argument to gdb_test, which errors out
due to recently introduced more strict argument checking in gdb_test.
Fix the error by removing the brace.
Though this fixes the error for me, due to PR29160 I get only FAILs, so I can't
claim proper testing on x86_64-linux.
---
gdb/testsuite/gdb.ctf/funcreturn.exp | 26 ++++++++++++--------------
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/gdb/testsuite/gdb.ctf/funcreturn.exp b/gdb/testsuite/gdb.ctf/funcreturn.exp
index 8f2723bdb89..fe4e045d0ce 100644
--- a/gdb/testsuite/gdb.ctf/funcreturn.exp
+++ b/gdb/testsuite/gdb.ctf/funcreturn.exp
@@ -106,14 +106,13 @@ if ![target_info exists no_long_long] {
# Sun /bin/cc calls this a function returning double.
if {!$gcc_compiled} then {setup_xfail "*-sun-sunos4*"}
- gdb_test "print v_float_func" \
- "$decimal = \{float \\(\\)\} 0x\[0-9a-z\]+.*" \
- "print float function"
+gdb_test "print v_float_func" \
+ "$decimal = \{float \\(\\)\} 0x\[0-9a-z\]+.*" \
+ "print float function"
- gdb_test "print v_double_func" \
- "$decimal = \{double \\(\\)\} 0x\[0-9a-z\]+.*" \
- "print double function" \
-}
+gdb_test "print v_double_func" \
+ "$decimal = \{double \\(\\)\} 0x\[0-9a-z\]+.*" \
+ "print double function"
# test whatis command with functions return type
gdb_test "whatis v_char_func" \
@@ -180,11 +179,10 @@ if ![target_info exists no_long_long] {
# Sun /bin/cc calls this a function returning double.
if {!$gcc_compiled} then {setup_xfail "*-sun-sunos4*"}
- gdb_test "whatis v_float_func" \
- "type = float \\($void\\)" \
- "whatis float function"
+gdb_test "whatis v_float_func" \
+ "type = float \\($void\\)" \
+ "whatis float function"
- gdb_test "whatis v_double_func" \
- "type = double \\($void\\)" \
- "whatis double function" \
-}
+gdb_test "whatis v_double_func" \
+ "type = double \\($void\\)" \
+ "whatis double function"
next prev parent reply other threads:[~2022-05-20 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 12:34 [PATCH 0/2] gdb: Fix DUPLICATE and PATH regressions throughout Pedro Alves
2022-05-19 12:34 ` [PATCH 1/2] Add -nopass option to gdb_test/gdb_test_multiple Pedro Alves
2022-05-19 12:34 ` [PATCH 2/2] gdb: Fix DUPLICATE and PATH regressions throughout Pedro Alves
2022-05-20 10:10 ` Tom de Vries [this message]
2022-06-04 9:19 ` [committed][gdb/testsuite] Fix ERROR in gdb.ctf/funcreturn.exp Tom de Vries
2022-05-24 15:18 ` [PATCH 0/2] gdb: Fix DUPLICATE and PATH regressions throughout Simon Marchi
2022-05-25 12:47 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec59dd30-027d-3651-2540-471cab60b162@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).