From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 435C1383C7DA for ; Tue, 13 Dec 2022 16:43:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 435C1383C7DA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 13BA41E112; Tue, 13 Dec 2022 11:43:26 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1670949807; bh=yy5iVowQdM61MB612N/1/ZVQxh4ho94y6jqTBW223O4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PMo+BsjPOLZnaUm9tEXGxWhay86DsUkYi1g+A4VCM0s4DYd/LT4uyv5BMHoEaEM0R iYeHKsogsCxwTu4pyVGVXWFqv221VflucDK7VHLPt2r53uyJ/MpR0Yty+8vA9tRLK1 ainmtNcX7OCnKYkQ/8OOiOA9TORFaZEoz+zb5rN4= Message-ID: Date: Tue, 13 Dec 2022 11:43:26 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] gdb: fix command lookup in execute_command () To: Tom Tromey , Jan Vrany via Gdb-patches Cc: Jan Vrany , luis.machado@arm.com References: <1a96057b-afd6-1e90-15c9-ee106a2998c7@arm.com> <20221213112241.621889-1-jan.vrany@labware.com> <878rjbfinm.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <878rjbfinm.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/13/22 10:05, Tom Tromey wrote: >>>>>> "Jan" == Jan Vrany via Gdb-patches writes: > > Jan> The below patch should fix this case - with it on my system > Jan> gdb.base/define.exp passes. > > Jan> Alternatively I may just revert the commit until better solution > Jan> is found. > > This patch looks ok to me, but could you say whether you ran all the > tests or just define.exp? Given the history I think a full regression > test is warranted. > > thanks, > Tom I'll run the patch through my CI job, where I am seeing the define.exp failures currently. Simon